Skip to content

Commit 19c03b9

Browse files
committed
Check node type for lib/utils/imports.collectImportBindings
1 parent ca4c97e commit 19c03b9

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

lib/utils/imports.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ function collectImportBindings(node, imports) {
77

88
if (sourceName) {
99
return node.specifiers.filter((specifier) => {
10-
return importedBindings.includes(specifier.imported.name);
10+
return 'ImportSpecifier' === specifier.type && importedBindings.includes(specifier.imported.name);
1111
}).map((specifier) => specifier.local.name);
1212
}
1313

tests/lib/rules/no-side-effect-cp.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,15 @@ ruleTester.run('no-side-efffect-cp', rule, {
2020
ecmaVersion: 6,
2121
sourceType: 'module'
2222
}
23+
},
24+
{
25+
code: `
26+
import EmberObject from '@ember/object';
27+
export default EmberObject();`,
28+
parserOptions: {
29+
ecmaVersion: 6,
30+
sourceType: 'module'
31+
}
2332
}
2433
],
2534
invalid: [

0 commit comments

Comments
 (0)