Cleanup action-cp stuff

Author: chadhietala

lib/rules/no-action-cp.js

@@ -1,62 +1,31 @@
 import { get } from '../utils/get';
-import { getCaller } from '../utils/caller';
-
-
-function isCPDesc(node, method) {
-  if (node.type !== "FunctionExpression") {
-    return false;
-  }
-
-  if (get(node, "parent.key.name") !== method) {
-    return false;
-  }
-
-  let grandParent = get(node, "parent.parent");
-  if (!grandParent) {
-    return false;
-  }
-  if (grandParent.type !== "ObjectExpression") {
-    return false;
-  }
-  var greatGrandParent = pParent.parent; // more parents!
-  if (greatGrandParent.type !== "CallExpression") {
-    return false;
-  }
-  var callee = greatGrandParent.callee;
-  if (greatGrandParent.type === "Identifier" && callee.name === "computed") {
-    return true;
-  }
-  if (callee.type === "MemberExpression") {
-    var caller = getCaller(callee);
-    return caller === "Ember.computed" || caller === "Em.computed";
-  }
-  return false; // don't know how you could get here
-}
-
-function _isCpGetter2(node) {
-  if (node.type !== "FunctionExpression") {
-    return false;
-  }
-  var parent = node.parent;
-  if (parent.type !== "CallExpression") {
-    return false;
-  }
-  var callee = parent.callee;
-  if (callee.type === "Identifier" && callee.name === "computed") {
-    return true;
-  }
-  if (callee.type === "MemberExpression") {
-    var caller = n.getCaller(callee);
-    return caller === "Ember.computed" || caller === "Em.computed";
-  }
-  return false;
-}
-
-function isCpGetter(node) {
-  return isCPDesc(node, 'get') || isCPAccessor(node)
-}
+import { getCaller, cleanCaller } from '../utils/caller';
+import { isCPGetter } from '../utils/computer-property';
 
+const SENDERS = ['send', 'sendAction', 'sendEvent', 'Em.sendEvent', 'Ember.sendEvent'];
 
 export default function noActionCp(context) {
-
+  let inCPGettter = false;
+
+  return {
+    FunctionExpression(node) {
+      if (isCPGetter(node)) {
+        inCPGettter = true;
+      }
+    },
+    'FunctionExpression:exit'(node) {
+      if (isCPGetter(node)) {
+        inCPGettter = false;
+      }
+    },
+    CallExpression(node) {
+      if (inCPGettter) {
+        let caller = cleanCaller(getCaller(node));
+
+        if (SENDERS.indexOf(caller) !== -1) {
+          context.report(node, 'Do not send events or actions in Computed Properties. This will cause data flow issues in the application, where the accessing of a property causes some side-effect. You should only send actions on behalf of user initiated events. Please see the following guide for more infromation: http://github.com/chadhietala/ember-best-practices/files/guides/no-action-cp.md');
+        }
+      }
+    }
+  };
 }

lib/utils/caller.js

@@ -21,3 +21,22 @@ export function getCaller(node) {
   }
   return callee.name;
 }
+
+function endsWith(str, suffix) {
+  return str.indexOf(suffix, str.length - suffix.length) !== -1;
+}
+
+export function cleanCaller(caller) {
+  if (!caller) {
+    return '';
+  }
+
+  [".call", ".apply"].forEach((application) => {
+    if (endsWith(caller, application)) {
+      let i = caller.lastIndexOf(application);
+      caller = caller.substr(0, i);
+    }
+  });
+
+  return caller;
+}

lib/utils/computer-property.js

@@ -0,0 +1,66 @@
+function isCPDesc(node, method) {
+  if (node.type !== 'FunctionExpression') {
+    return false;
+  }
+
+  if (get(node, 'parent.key.name') !== method) {
+    return false;
+  }
+
+  let grandParent = get(node, 'parent.parent');
+  if (!grandParent) {
+    return false;
+  }
+  if (grandParent.type !== 'ObjectExpression') {
+    return false;
+  }
+  let greatGrandParent = pParent.parent; // more parents!
+  if (greatGrandParent.type !== 'CallExpression') {
+    return false;
+  }
+  let callee = greatGrandParent.callee;
+  if (greatGrandParent.type === 'Identifier' && callee.name === 'computed') {
+    return true;
+  }
+  if (callee.type === 'MemberExpression') {
+    let caller = getCaller(callee);
+    return caller === 'Ember.computed' || caller === 'Em.computed';
+  }
+  return false; // don't know how you could get here
+}
+
+
+function isPrototypeExtCP(node) {
+  if (node.type !== 'FunctionExpression') {
+    return false;
+  }
+
+  return get(node, 'parent.property.name');
+}
+
+function isCPAccessor(node) {
+  if (node.type !== 'FunctionExpression') {
+    return false;
+  }
+
+  let parent = node.parent;
+  if (parent.type !== 'CallExpression') {
+    return false;
+  }
+
+  let callee = parent.callee;
+  if (callee.type === 'Identifier' && callee.name === 'computed') {
+    return true;
+  }
+
+  if (callee.type === 'MemberExpression') {
+    let caller = n.getCaller(callee);
+    return caller === 'Ember.computed' || caller === 'Em.computed';
+  }
+  return false;
+}
+
+export function isCPGetter(node) {
+  return isCPDesc(node, 'get') || isCPAccessor(node) || isPrototypeExtCP(node);
+}
+