[Expiremental] Adding rule to black list 2.0.0 hooks

Author: chadhietala

config/expiremental.js

@@ -0,0 +1,17 @@
+module.exports = {
+  parserOptions: {
+    ecmaVersion: 6,
+    sourceType: 'module'
+  },
+  env: {
+    'browser': true
+  },
+  plugins: [
+    'ember-best-practices'
+  ],
+  extends: require.resolve('./recommended.js'),
+  rules: {
+    // Expiremental rules
+    'ember-best-practices/no-2.0.0-hooks': 2
+  }
+};

lib/rules/no-2.0.0-hooks.js

@@ -0,0 +1,22 @@
+// TODO
+// Write docs for this once we feel it should be recommended.
+const MESSAGE = 'Do not use the 2.0.0 hooks as they are not conducive to the programming model.';
+const MISTAKE_HOOKS = ['didInitAttrs', 'didReceiveAttrs', 'didUpdateAttrs', 'didRender', 'willUpdate', 'didUpdate', 'willRender'];
+
+module.exports = {
+  meta: {
+    message: MESSAGE
+  },
+  create(context) {
+    return {
+      ObjectExpression(node) {
+        node.properties.forEach((property) => {
+          let name = property.key.name;
+          if (MISTAKE_HOOKS.indexOf(name) > -1) {
+            context.report(property, MESSAGE);
+          }
+        });
+      }
+    };
+  }
+};

tests/lib/rules/no-2.0.0-hooks.js

@@ -0,0 +1,139 @@
+const rule = require('../../../lib/rules/no-2.0.0-hooks');
+const MESSAGE = rule.meta.message;
+const RuleTester = require('eslint').RuleTester;
+const ruleTester = new RuleTester();
+
+ruleTester.run('no-2.0.0-hooks', rule, {
+  valid: [
+    {
+      code: `
+        export default Ember.Component({
+          foo: 'bar',
+          baz: false,
+          actions: {
+            userInput() {
+              this.set('baz', true);
+            }
+          }
+        });`,
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module'
+      }
+    }
+  ],
+  invalid: [
+    {
+      code: `
+        export default Ember.Component({
+          didInitAttrs() {
+            this._super(...arguments);
+            this.nope = true;
+          }
+        });`,
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module'
+      },
+      errors: [{
+        message: MESSAGE
+      }]
+    },
+    {
+      code: `
+        export default Ember.Component({
+          didReceiveAttrs() {
+            this._super(...arguments);
+            this.nope = true;
+          }
+        });`,
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module'
+      },
+      errors: [{
+        message: MESSAGE
+      }]
+    },
+    {
+      code: `
+        export default Ember.Component({
+          didUpdateAttrs() {
+            this._super(...arguments);
+            this.nope = true;
+          }
+        });`,
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module'
+      },
+      errors: [{
+        message: MESSAGE
+      }]
+    },
+    {
+      code: `
+        export default Ember.Component({
+          didRender() {
+            this._super(...arguments);
+            this.nope = true;
+          }
+        });`,
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module'
+      },
+      errors: [{
+        message: MESSAGE
+      }]
+    },
+    {
+      code: `
+        export default Ember.Component({
+          didUpdate() {
+            this._super(...arguments);
+            this.nope = true;
+          }
+        });`,
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module'
+      },
+      errors: [{
+        message: MESSAGE
+      }]
+    },
+    {
+      code: `
+        export default Ember.Component({
+          willUpdate() {
+            this._super(...arguments);
+            this.nope = true;
+          }
+        });`,
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module'
+      },
+      errors: [{
+        message: MESSAGE
+      }]
+    },
+    {
+      code: `
+        export default Ember.Component({
+          willRender() {
+            this._super(...arguments);
+            this.nope = true;
+          }
+        });`,
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module'
+      },
+      errors: [{
+        message: MESSAGE
+      }]
+    }
+  ]
+});