Skip to content

Commit 388bdfe

Browse files
rwjbluerwjblue
authored
Merge pull request #89 from nlfurniss/dry-parserOptions
DRY up `parserOptions`
2 parents 0efebd7 + b91b67e commit 388bdfe

11 files changed

+120
-332
lines changed

‎tests/lib/rules/no-2.0.0-hooks.js

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
const rule = require('../../../lib/rules/no-2.0.0-hooks');
22
const MESSAGE = rule.meta.message;
33
const RuleTester = require('eslint').RuleTester;
4-
const ruleTester = new RuleTester();
4+
const ruleTester = new RuleTester({
5+
parserOptions: {
6+
ecmaVersion: 6,
7+
sourceType: 'module'
8+
}
9+
});
510

611
ruleTester.run('no-2.0.0-hooks', rule, {
712
valid: [
@@ -15,11 +20,7 @@ ruleTester.run('no-2.0.0-hooks', rule, {
1520
this.set('baz', true);
1621
}
1722
}
18-
});`,
19-
parserOptions: {
20-
ecmaVersion: 6,
21-
sourceType: 'module'
22-
}
23+
});`
2324
}
2425
],
2526
invalid: [
@@ -111,10 +112,6 @@ ruleTester.run('no-2.0.0-hooks', rule, {
111112
this.nope = true;
112113
}
113114
});`,
114-
parserOptions: {
115-
ecmaVersion: 6,
116-
sourceType: 'module'
117-
},
118115
errors: [{
119116
message: MESSAGE
120117
}]

‎tests/lib/rules/no-attrs-snapshot.js

Lines changed: 8 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
const rule = require('../../../lib/rules/no-attrs-snapshot');
22
const MESSAGE = rule.meta.message;
33
const RuleTester = require('eslint').RuleTester;
4-
const ruleTester = new RuleTester();
4+
const ruleTester = new RuleTester({
5+
parserOptions: {
6+
ecmaVersion: 6,
7+
sourceType: 'module'
8+
}
9+
});
510

611
ruleTester.run('no-attrs-snapshot', rule, {
712
valid: [
@@ -21,11 +26,7 @@ ruleTester.run('no-attrs-snapshot', rule, {
2126
this.set('updated', false);
2227
}
2328
}
24-
});`,
25-
parserOptions: {
26-
ecmaVersion: 6,
27-
sourceType: 'module'
28-
}
29+
});`
2930
},
3031
{
3132
code: `
@@ -43,11 +44,7 @@ ruleTester.run('no-attrs-snapshot', rule, {
4344
this.set('updated', false);
4445
}
4546
}
46-
});`,
47-
parserOptions: {
48-
ecmaVersion: 6,
49-
sourceType: 'module'
50-
}
47+
});`
5148
}
5249
],
5350
invalid: [
@@ -67,10 +64,6 @@ ruleTester.run('no-attrs-snapshot', rule, {
6764
}
6865
}
6966
});`,
70-
parserOptions: {
71-
ecmaVersion: 6,
72-
sourceType: 'module'
73-
},
7467
errors: [{
7568
message: MESSAGE
7669
}]
@@ -91,10 +84,6 @@ ruleTester.run('no-attrs-snapshot', rule, {
9184
}
9285
}
9386
});`,
94-
parserOptions: {
95-
ecmaVersion: 6,
96-
sourceType: 'module'
97-
},
9887
errors: [{
9988
message: MESSAGE
10089
}]

‎tests/lib/rules/no-attrs.js

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
const rule = require('../../../lib/rules/no-attrs');
22
const MESSAGE = rule.meta.message;
33
const RuleTester = require('eslint').RuleTester;
4-
const ruleTester = new RuleTester();
4+
const ruleTester = new RuleTester({
5+
parserOptions: {
6+
ecmaVersion: 6,
7+
sourceType: 'module'
8+
}
9+
});
510

611
ruleTester.run('no-attrs', rule, {
712
valid: [
@@ -12,11 +17,7 @@ ruleTester.run('no-attrs', rule, {
1217
this._super(...arguments);
1318
this.alias = this.concrete;
1419
}
15-
});`,
16-
parserOptions: {
17-
ecmaVersion: 6,
18-
sourceType: 'module'
19-
}
20+
});`
2021
}
2122
],
2223
invalid: [
@@ -28,10 +29,6 @@ ruleTester.run('no-attrs', rule, {
2829
this.alias = this.attrs.concrete;
2930
}
3031
});`,
31-
parserOptions: {
32-
ecmaVersion: 6,
33-
sourceType: 'module'
34-
},
3532
errors: [{
3633
message: MESSAGE
3734
}]
@@ -45,10 +42,6 @@ ruleTester.run('no-attrs', rule, {
4542
}
4643
}
4744
});`,
48-
parserOptions: {
49-
ecmaVersion: 6,
50-
sourceType: 'module'
51-
},
5245
errors: [{
5346
message: MESSAGE
5447
}]

‎tests/lib/rules/no-broken-super-chain.js

Lines changed: 13 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,12 @@ const rule = require('../../../lib/rules/no-broken-super-chain');
22
const RuleTester = require('eslint').RuleTester;
33

44
const { noSuper, tooManySupers } = rule.meta.messages;
5-
const ruleTester = new RuleTester();
5+
const ruleTester = new RuleTester({
6+
parserOptions: {
7+
ecmaVersion: 6,
8+
sourceType: 'module'
9+
}
10+
});
611

712
ruleTester.run('no-broken-super-chain', rule, {
813
valid: [
@@ -16,11 +21,7 @@ ruleTester.run('no-broken-super-chain', rule, {
1621
somethingNotInit() {
1722
this.alias = this.concrete;
1823
}
19-
});`,
20-
parserOptions: {
21-
ecmaVersion: 6,
22-
sourceType: 'module'
23-
}
24+
});`
2425
},
2526
{
2627
code: `
@@ -29,11 +30,7 @@ ruleTester.run('no-broken-super-chain', rule, {
2930
this._super(...arguments);
3031
this.get('foo');
3132
}
32-
});`,
33-
parserOptions: {
34-
ecmaVersion: 6,
35-
sourceType: 'module'
36-
}
33+
});`
3734
},
3835
{
3936
code: `
@@ -48,35 +45,23 @@ ruleTester.run('no-broken-super-chain', rule, {
4845
somethingNotInit() {
4946
this.alias = this.concrete;
5047
}
51-
});`,
52-
parserOptions: {
53-
ecmaVersion: 6,
54-
sourceType: 'module'
55-
}
48+
});`
5649
},
5750
{
5851
code: `
5952
export default Ember.Service.extend({
6053
init() {
6154
this.alias = this.concrete;
6255
}
63-
});`,
64-
parserOptions: {
65-
ecmaVersion: 6,
66-
sourceType: 'module'
67-
}
56+
});`
6857
},
6958
{
7059
code: `
7160
export default Ember.Component.extend({
7261
didInsertElement() {
7362
this.updateBlurHandler(true);
7463
}
75-
});`,
76-
parserOptions: {
77-
ecmaVersion: 6,
78-
sourceType: 'module'
79-
}
64+
});`
8065
},
8166
{
8267
code: `
@@ -85,11 +70,7 @@ ruleTester.run('no-broken-super-chain', rule, {
8570
this._super(...arguments);
8671
this.updateBlurHandler(true);
8772
}
88-
});`,
89-
parserOptions: {
90-
ecmaVersion: 6,
91-
sourceType: 'module'
92-
}
73+
});`
9374
},
9475
{
9576
code: `
@@ -100,11 +81,7 @@ ruleTester.run('no-broken-super-chain', rule, {
10081
}
10182
});
10283
103-
export default foo;`,
104-
parserOptions: {
105-
ecmaVersion: 6,
106-
sourceType: 'module'
107-
}
84+
export default foo;`
10885
}
10986
],
11087
invalid: [
@@ -115,10 +92,6 @@ ruleTester.run('no-broken-super-chain', rule, {
11592
this.alias = this.concrete;
11693
}
11794
});`,
118-
parserOptions: {
119-
ecmaVersion: 6,
120-
sourceType: 'module'
121-
},
12295
errors: [{
12396
message: noSuper
12497
}]
@@ -130,10 +103,6 @@ ruleTester.run('no-broken-super-chain', rule, {
130103
this.get('foo');
131104
}
132105
});`,
133-
parserOptions: {
134-
ecmaVersion: 6,
135-
sourceType: 'module'
136-
},
137106
errors: [{
138107
message: noSuper
139108
}]
@@ -147,10 +116,6 @@ ruleTester.run('no-broken-super-chain', rule, {
147116
// this.alias = this.concrete;
148117
// }
149118
// });`,
150-
// parserOptions: {
151-
// ecmaVersion: 6,
152-
// sourceType: 'module'
153-
// }
154119
// },
155120
// TODO
156121
// {
@@ -161,10 +126,6 @@ ruleTester.run('no-broken-super-chain', rule, {
161126
// this._super(...arguments);
162127
// }
163128
// });`,
164-
// parserOptions: {
165-
// ecmaVersion: 6,
166-
// sourceType: 'module'
167-
// },
168129
// errors: [{
169130
// message: noThisBeforeSuper
170131
// }]
@@ -178,10 +139,6 @@ ruleTester.run('no-broken-super-chain', rule, {
178139
this._super(...arguments);
179140
}
180141
});`,
181-
parserOptions: {
182-
ecmaVersion: 6,
183-
sourceType: 'module'
184-
},
185142
errors: [{
186143
message: tooManySupers
187144
}]
@@ -194,10 +151,6 @@ ruleTester.run('no-broken-super-chain', rule, {
194151
// this.updateBlurHandler(true);
195152
// }
196153
// });`,
197-
// parserOptions: {
198-
// ecmaVersion: 6,
199-
// sourceType: 'module'
200-
// },
201154
// errors: [{
202155
// message: noSuper
203156
// }]

0 commit comments

Comments
 (0)