Skip to content

Commit 617b935

Browse files
committed
Fix repository URL
Now the repository is moved from "chadhietala/ember-best-practices" to "ember-best-practices/eslint-plugin-ember-best-practices".
1 parent aa4f083 commit 617b935

9 files changed

+9
-9
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ ember install ember-cli-eslint
3737

3838
The `ember-cli-eslint` addon blueprint generates a .eslintrc.js configuration file at the root of the project.
3939

40-
Add the plugin's [recommended](https://github.com/chadhietala/ember-best-practices/blob/master/config/recommended.js) configuration to the list of extensions:
40+
Add the plugin's [recommended](https://github.com/ember-best-practices/eslint-plugin-ember-best-practices/blob/master/config/recommended.js) configuration to the list of extensions:
4141

4242
```
4343
// .eslintrc.js

lib/rules/no-attrs-snapshot.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ function hasAttrsSnapShot(node) {
1919
return (methodName === 'didReceiveAttrs' || methodName === 'didUpdateAttrs') && hasParams;
2020
}
2121

22-
const MESSAGE = 'Do not use the attrs snapshot that is passed in `didReceiveAttrs` and `didUpdateAttrs`. Please see the following guide for more information: https://github.com/chadhietala/ember-best-practices/blob/master/guides/rules/no-attrs-snapshot.md';
22+
const MESSAGE = 'Do not use the attrs snapshot that is passed in `didReceiveAttrs` and `didUpdateAttrs`. Please see the following guide for more information: https://github.com/ember-best-practices/eslint-plugin-ember-best-practices/blob/master/guides/rules/no-attrs-snapshot.md';
2323

2424
module.exports = {
2525
docs: {

lib/rules/no-attrs.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ function isAttrs(node) {
1313
return node.property.name === 'attrs' && node.object.type === 'ThisExpression';
1414
}
1515

16-
const MESSAGE = 'Do not use this.attrs. Please see the following guide for more information: https://github.com/chadhietala/ember-best-practices/blob/master/guides/rules/no-attrs.md';
16+
const MESSAGE = 'Do not use this.attrs. Please see the following guide for more information: https://github.com/ember-best-practices/eslint-plugin-ember-best-practices/blob/master/guides/rules/no-attrs.md';
1717

1818
module.exports = {
1919
docs: {

lib/rules/no-global-jquery.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ function isGlobalJquery(node) {
1313
return node.callee && node.callee.name === '$';
1414
}
1515

16-
const MESSAGE = 'Do not use global `$`. Use `Ember.$` instead. Please see the following guide for more information: https://github.com/chadhietala/ember-best-practices/blob/master/guides/rules/no-global-jquery.md';
16+
const MESSAGE = 'Do not use global `$`. Use `Ember.$` instead. Please see the following guide for more information: https://github.com/ember-best-practices/eslint-plugin-ember-best-practices/blob/master/guides/rules/no-global-jquery.md';
1717

1818
module.exports = {
1919
docs: {

lib/rules/no-lifecycle-events.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
const { collectObjectPatternBindings } = require('../utils/destructed-binding');
88
const { getEmberImportBinding } = require('../utils/imports');
99

10-
const MESSAGE = 'Do not use events for lifecycle hooks. Please use the actual hooks instead: https://github.com/chadhietala/ember-best-practices/blob/master/guides/rules/no-lifecycle-events.md';
10+
const MESSAGE = 'Do not use events for lifecycle hooks. Please use the actual hooks instead: https://github.com/ember-best-practices/eslint-plugin-ember-best-practices/blob/master/guides/rules/no-lifecycle-events.md';
1111
// TODO: Pull these from somewhere?
1212
const LIFECYCLE_HOOKS = [
1313
'didDestroyElement',

lib/rules/no-observers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ function isObserver(node) {
1010
|| (callee && callee.name === 'observer');
1111
}
1212

13-
const MESSAGE = 'Do not use observers. Consider using computed properties instead. Please see following guide for more information: https://github.com/chadhietala/ember-best-practices/blob/master/guides/rules/no-observers.md';
13+
const MESSAGE = 'Do not use observers. Consider using computed properties instead. Please see following guide for more information: https://github.com/ember-best-practices/eslint-plugin-ember-best-practices/blob/master/guides/rules/no-observers.md';
1414

1515
module.exports = {
1616
docs: {

lib/rules/no-side-effect-cp.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ const { collectObjectPatternBindings } = require('../utils/destructed-binding');
1010

1111
let SIDE_EFFECTS = ['this.send', 'this.sendAction', 'this.sendEvent', 'Em.sendEvent', 'Ember.sendEvent', 'this.trigger', 'this.set', 'Ember.set', 'Em.set', 'this.setProperties', 'Ember.setProperties', 'Em.setProperties'];
1212

13-
const MESSAGE = 'Do not send events or actions in Computed Properties. This will cause data flow issues in the application, where the accessing of a property causes some side-effect. You should only send actions on behalf of user initiated events. Please see the following guide for more information: https://github.com/chadhietala/ember-best-practices/blob/master/guides/rules/no-side-effect-cp.md';
13+
const MESSAGE = 'Do not send events or actions in Computed Properties. This will cause data flow issues in the application, where the accessing of a property causes some side-effect. You should only send actions on behalf of user initiated events. Please see the following guide for more information: https://github.com/ember-best-practices/eslint-plugin-ember-best-practices/blob/master/guides/rules/no-side-effect-cp.md';
1414

1515
module.exports = {
1616
docs: {

lib/rules/require-dependent-keys.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
const { get } = require('../utils/get');
7-
const MESSAGE = 'Do not use Computed Properties without dependent keys. If you want the property to be set only once, initialize it in init(). Please see following guide for more information: https://github.com/chadhietala/ember-best-practices/blob/master/guides/rules/require-dependent-keys.md';
7+
const MESSAGE = 'Do not use Computed Properties without dependent keys. If you want the property to be set only once, initialize it in init(). Please see following guide for more information: https://github.com/ember-best-practices/eslint-plugin-ember-best-practices/blob/master/guides/rules/require-dependent-keys.md';
88

99
function isMissingDependentKeys(name, node, context) {
1010
if (name === 'computed' && node.arguments.length === 1) {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"test": "nyc mocha --recursive tests",
1313
"test-server": "mocha --recursive --growl --watch tests"
1414
},
15-
"repository": "chadhietala/ember-best-practices",
15+
"repository": "ember-best-practices/eslint-plugin-ember-best-practices",
1616
"engines": {
1717
"node": ">= 6.0.0"
1818
},

0 commit comments

Comments
 (0)