|
| 1 | +/** |
| 2 | + * @fileOverview Require the use of ember-lifeline's lifecycle aware methods over Ember.run.*. |
| 3 | + */ |
| 4 | + |
| 5 | +const { getCaller, cleanCaller } = require('../utils/caller'); |
| 6 | +const { getEmberImportBinding } = require('../utils/imports'); |
| 7 | +const { collectObjectPatternBindings } = require('../utils/destructed-binding'); |
| 8 | + |
| 9 | +let DISALLOWED_OBJECTS = ['Ember.run', 'run']; |
| 10 | +let RUN_METHODS = ['later', 'next', 'debounce', 'throttle']; |
| 11 | +const LIFELINE_METHODS = ['runTask', 'runTask', 'debounceTask', 'throttleTask']; |
| 12 | + |
| 13 | +function getMessage(actualMethodUsed) { |
| 14 | + let method = actualMethodUsed.split('.').pop(); |
| 15 | + let lifelineEquivalent = LIFELINE_METHODS[RUN_METHODS.indexOf(method)]; |
| 16 | + |
| 17 | + return `Please use ${lifelineEquivalent} from ember-lifeline instead of ${actualMethodUsed}.`; |
| 18 | +} |
| 19 | + |
| 20 | +function mergeDisallowedCalls(objects) { |
| 21 | + return objects |
| 22 | + .reduce((calls, obj) => { |
| 23 | + RUN_METHODS.forEach((method) => { |
| 24 | + calls.push(`${obj}.${method}`); |
| 25 | + }); |
| 26 | + |
| 27 | + return calls; |
| 28 | + }, []); |
| 29 | +} |
| 30 | + |
| 31 | +module.exports = { |
| 32 | + docs: { |
| 33 | + description: 'Please use the lifecycle-aware tasks from ember-lifeline instead of Ember.run.*.', |
| 34 | + category: 'Best Practices', |
| 35 | + recommended: false |
| 36 | + }, |
| 37 | + meta: { |
| 38 | + message: getMessage |
| 39 | + }, |
| 40 | + create(context) { |
| 41 | + let emberImportBinding; |
| 42 | + let disallowedCalls = mergeDisallowedCalls(DISALLOWED_OBJECTS); |
| 43 | + |
| 44 | + return { |
| 45 | + ImportDefaultSpecifier(node) { |
| 46 | + emberImportBinding = getEmberImportBinding(node); |
| 47 | + }, |
| 48 | + |
| 49 | + ObjectPattern(node) { |
| 50 | + if (emberImportBinding) { |
| 51 | + disallowedCalls = disallowedCalls.concat( |
| 52 | + mergeDisallowedCalls( |
| 53 | + collectObjectPatternBindings(node, { |
| 54 | + [emberImportBinding]: ['run'] |
| 55 | + }) |
| 56 | + ) |
| 57 | + ); |
| 58 | + } |
| 59 | + }, |
| 60 | + |
| 61 | + MemberExpression(node) { |
| 62 | + let caller = cleanCaller(getCaller(node)); |
| 63 | + |
| 64 | + if (disallowedCalls.includes(caller)) { |
| 65 | + context.report(node, getMessage(caller)); |
| 66 | + } |
| 67 | + } |
| 68 | + }; |
| 69 | + } |
| 70 | +}; |
0 commit comments