Skip to content

Commit 7b4585d

Browse files
authored
Merge pull request #50 from mriska/patch-3
Fix typo: incuring -> incurring
2 parents 6a8a75d + 473a638 commit 7b4585d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

guides/rules/no-lifecycle-events.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# No Lifecycle Events
22

3-
Ember tracks changes and notifies listeners of those changes. This is quite powerful and prevents the need for “glue” code to propagate changes. This also enables granular updates, rather than whole-world rebuild scenarios. This comes at a downside, we can easily trigger these “update” code-paths on accident, when they are not required. This comes largely at a performance cost. For example, if during initial render we also cause a re-render, then this is wasteful. Ember keeps getting better at detecting these cases and informing the developer. Unfortunately it is not perfect yet. When we use the lifecycle events we are incuring double work as we must event and also call the method hooks on the object. Because of this we should simply do the work in a [lifecycle hook](https://guides.emberjs.com/v2.10.0/components/the-component-lifecycle/).
3+
Ember tracks changes and notifies listeners of those changes. This is quite powerful and prevents the need for “glue” code to propagate changes. This also enables granular updates, rather than whole-world rebuild scenarios. This comes at a downside, we can easily trigger these “update” code-paths on accident, when they are not required. This comes largely at a performance cost. For example, if during initial render we also cause a re-render, then this is wasteful. Ember keeps getting better at detecting these cases and informing the developer. Unfortunately it is not perfect yet. When we use the lifecycle events we are incurring double work as we must event and also call the method hooks on the object. Because of this we should simply do the work in a [lifecycle hook](https://guides.emberjs.com/v2.10.0/components/the-component-lifecycle/).
44

55
```
66
// Good

0 commit comments

Comments
 (0)