Merge pull request #44 from eddie-ruva/send-action

Implements rule to catch sendAction calls

Author: trentmwillis

config/experimental.js

@@ -12,6 +12,7 @@ module.exports = {
   extends: require.resolve('./recommended.js'),
   rules: {
     // Experimental rules
-    'ember-best-practices/no-2.0.0-hooks': 2
+    'ember-best-practices/no-2.0.0-hooks': 2,
+    'ember-best-practices/no-send-action': 2
   }
 };

guides/rules/no-send-action.md

@@ -0,0 +1,9 @@
+# No sendAction()
+
+**TL;DR: Use closure actions instead of bubbling actions via sendAction**
+
+Before v1.13 Ember's only way to deal with actions was through a bubbling system by calling `sendAction` or `send`. This changed when closure actions got introduced into the system and changed the paradigm to simpler JS function calls.
+
+References:
+[Ember 1.13 release post](http://emberjs.com/blog/2015/06/12/ember-1-13-0-released.html#toc_closure-actions)
+[Ember Best Practices: Stop bubbling actions and use closure actions by Dan McClain](https://dockyard.com/blog/2015/10/29/ember-best-practice-stop-bubbling-and-use-closure-actions)

lib/rules/no-send-action.js

@@ -0,0 +1,32 @@
+/**
+ * @fileOverview Disallow use of sendAction
+ * @author Edilberto Ruvalcaba
+ */
+'use strict';
+
+const { get } = require('../utils/get');
+
+function isSendActionFnCall(node) {
+  return get(node, 'callee.property.name') === 'sendAction';
+}
+
+const MESSAGE = 'Do not use send action. Consider using closure actions to work with JS functions instead of relying on the old action system. Please see following guide for more information: https://github.com/ember-best-practices/eslint-plugin-ember-best-practices/blob/master/guides/rules/no-send-action.md';
+
+module.exports = {
+  docs: {
+    description: 'Disallow use of sendAction',
+    category: 'Best Practices'
+  },
+  meta: {
+    message: MESSAGE
+  },
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (isSendActionFnCall(node)) {
+          context.report(node, MESSAGE);
+        }
+      }
+    };
+  }
+};

tests/lib/rules/no-send-action.js

@@ -0,0 +1,46 @@
+const rule = require('../../../lib/rules/no-send-action');
+const MESSAGE = rule.meta.message;
+const RuleTester = require('eslint').RuleTester;
+const ruleTester = new RuleTester();
+
+ruleTester.run('no-send-action', rule, {
+  valid: [
+    {
+      code: `
+        function anotherFunction() {
+        }
+
+        export default Ember.Component({
+          actions: {
+            userInput() {
+              anotherFunction();
+              this.myAction();
+            }
+          }
+        });`,
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module'
+      }
+    }
+  ],
+  invalid: [
+    {
+      code: `
+        export default Ember.Component({
+          actions: {
+            userInput() {
+              this.sendAction('myAction');
+            }
+          }
+        });`,
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module'
+      },
+      errors: [{
+        message: MESSAGE
+      }]
+    }
+  ]
+});