Skip to content

Commit ced43e5

Browse files
committed
Fixing require-dependent-keys
1 parent c55b8e0 commit ced43e5

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

config/recommended.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ module.exports = {
1616
'ember-best-practices/no-observers': 2,
1717
'ember-best-practices/require-dependent-keys': 2,
1818
'ember-best-practices/no-lifecycle-events': 2,
19-
'ember-best-practices/no-timers': 2,
20-
'ember-best-practices/no-unguarded-document': 2,
2119
'ember-best-practices/no-attrs-snapshot': 2
2220
}
2321
};

lib/rules/require-dependent-keys.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* @author Chad Hietala
44
*/
55

6+
const { get } = require('../utils/get');
67
const MESSAGE = 'Do not use Computed Properties without dependent keys. Please see following guide for more information: https://github.com/chadhietala/ember-best-practices/blob/master/guides/rules/require-dependent-keys.md';
78

89
function isMissingDependentKeys(name, node, context) {
@@ -23,7 +24,7 @@ module.exports = {
2324
create(context) {
2425
return {
2526
CallExpression(node) {
26-
let name = node.callee.name || node.callee.property.name;
27+
let name = get(node, 'callee.name') || get(node, 'callee.property.name');
2728
isMissingDependentKeys(name, node, context);
2829
}
2930
};

0 commit comments

Comments
 (0)