[Bugfix] - Fixes #47

Author: scalvert

lib/rules/no-global-jquery.js

@@ -3,6 +3,10 @@
  */
 'use strict';
 
+const { getEmberImportBinding } = require('../utils/imports');
+const { collectObjectPatternBindings } = require('../utils/destructed-binding');
+
+const MESSAGE = 'Do not use global `$` or `jQuery`. Use `Ember.$` instead. Please see the following guide for more information: https://github.com/ember-best-practices/eslint-plugin-ember-best-practices/blob/master/guides/rules/no-global-jquery.md';
 const ALIASES = ['$', 'jQuery'];
 
 /**
@@ -14,8 +18,6 @@ function isGlobalJquery(node) {
   return node.callee && ALIASES.includes(node.callee.name);
 }
 
-const MESSAGE = 'Do not use global `$` or `jQuery`. Use `Ember.$` instead. Please see the following guide for more information: https://github.com/ember-best-practices/eslint-plugin-ember-best-practices/blob/master/guides/rules/no-global-jquery.md';
-
 module.exports = {
   docs: {
     description: 'Disallow the use of global `$`',
@@ -26,9 +28,28 @@ module.exports = {
     message: MESSAGE
   },
   create(context) {
+    let emberImportBinding;
+    let deconstructedAssignment = null;
+
+    function isDeconstructed(node) {
+      return node && node.callee && node.callee.name === deconstructedAssignment;
+    }
+
     return {
+      ImportDefaultSpecifier(node) {
+        emberImportBinding = getEmberImportBinding(node);
+      },
+
+      ObjectPattern(node) {
+        if (emberImportBinding) {
+          deconstructedAssignment = collectObjectPatternBindings(node, {
+            [emberImportBinding]: ['$']
+          }).pop();
+        }
+      },
+
       CallExpression(node) {
-        if (isGlobalJquery(node)) {
+        if (!isDeconstructed(node) && isGlobalJquery(node)) {
           context.report(node, MESSAGE);
         }
       }

tests/lib/rules/no-global-jquery.js

@@ -56,6 +56,86 @@ ruleTester.run('no-global-jquery', rule, {
         ecmaVersion: 6,
         sourceType: 'module'
       }
+    },
+    {
+      code: `
+        import Ember from 'ember';
+
+        const { $ } = Ember;
+
+        export default Ember.Component({
+          init() {
+            this.el = $('.test');
+          }
+        });`,
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module'
+      },
+      errors: [{
+        message: MESSAGE
+      }]
+    },
+    {
+      code: `
+        import Ember from 'ember';
+
+        const { $ } = Ember;
+
+        export default Ember.Component({
+          actions: {
+            valid() {
+              this.inv1 = $('.invalid1');
+            }
+          }
+        });`,
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module'
+      },
+      errors: [{
+        message: MESSAGE
+      }]
+    },
+    {
+      code: `
+        import Ember from 'ember';
+
+        const { $: foo } = Ember;
+
+        export default Ember.Component({
+          init() {
+            this.el = foo('.test');
+          }
+        });`,
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module'
+      },
+      errors: [{
+        message: MESSAGE
+      }]
+    },
+    {
+      code: `
+        import Ember from 'ember';
+
+        const { $: foo } = Ember;
+
+        export default Ember.Component({
+          actions: {
+            valid() {
+              this.inv1 = foo('.invalid1');
+            }
+          }
+        });`,
+      parserOptions: {
+        ecmaVersion: 6,
+        sourceType: 'module'
+      },
+      errors: [{
+        message: MESSAGE
+      }]
     }
   ],
   invalid: [