Merge pull request #88 from nlfurniss/fix-anonymous-once

Fix no-anonymous-once not recognizing context function

Author: chadhietala

lib/rules/no-anonymous-once.js

@@ -6,6 +6,7 @@
 const { getCaller, cleanCaller, isCallingWithApply, isCallingWithCall } = require('../utils/caller');
 const { collectObjectPatternBindings } = require('../utils/destructed-binding');
 const { getEmberImportBinding } = require('../utils/imports');
+const { get } = require('../utils/get');
 const MESSAGE
   = `The uniqueness once offers is based on function uniqueness, each invocation of this line will always create a new
      function instance, resulting in uniqueness checks, that will never be hit. Please replace with a named function.
@@ -49,9 +50,14 @@ function normalizeArguments(caller, args) {
 
   return mut;
 }
-
+/**
+ * Determines whether a function is anonymous based on whether it was a name
+ * or if it is a method on the current context.
+ * @param {ASTNode} fn
+ * @return {Boolean}
+ */
 function isAnonymousFunction(fn) {
-  return fn && !fn.name;
+  return !(get(fn, 'name') || get(fn, 'object.type') === 'ThisExpression');
 }
 
 function isString(node) {

tests/lib/rules/no-anonymous-once.js

@@ -44,6 +44,76 @@ ruleTester.run('no-anonymous-once', rule, {
             run.once.call(this, noop);
           }
         });`
+    },
+    {
+      code: `
+        export default Ember.Component({
+          cb: () => {
+            // do stuff
+          },
+
+          perform() {
+            Ember.run.once(this, 'cb');
+          }
+        });`
+    },
+    {
+      code: `
+        export default Ember.Component({
+          cb: () => {
+            // do stuff
+          },
+
+          perform() {
+            Ember.run.once(this, this.cb);
+          }
+        });`
+    },
+    {
+      code: `
+        function cb() {
+          //do stuff
+        }
+        export default Ember.Component({
+          perform() {
+            Ember.run.once(this, cb);
+          }
+        });`
+    },
+    {
+      code: `
+        export default Ember.Component({
+          cb: () => {
+            // do stuff
+          },
+
+          perform() {
+            Ember.run.scheduleOnce('afterRender', this, 'cb');
+          }
+        });`
+    },
+    {
+      code: `
+        export default Ember.Component({
+          cb: () => {
+            // do stuff
+          },
+
+          perform() {
+            Ember.run.scheduleOnce('afterRender', this, this.cb);
+          }
+        });`
+    },
+    {
+      code: `
+        function cb() {
+          //do stuff
+        }
+        export default Ember.Component({
+          perform() {
+            Ember.run.scheduleOnce('afterRender', this, cb);
+          }
+        });`
     }
   ],
   invalid: [