Merge pull request #24 from chadhietala/graceful-gets

[Bugfix] Cautiously path into AST nodes

Author: chadhietala

lib/rules/no-attrs-snapshot.js

@@ -1,5 +1,7 @@
+const { get } = require('../utils/get');
+
 function hasAttrsSnapShot(node) {
-  let methodName = node.parent.key.name;
+  let methodName = get(node, 'parent.key.name');
   let hasParams = node.params.length > 0;
   return (methodName === 'didReceiveAttrs' || methodName === 'didUpdateAttrs') && hasParams;
 }

lib/rules/no-unguarded-document.js

@@ -1,9 +1,10 @@
 const { isGuarded } = require('../utils/fast-boot');
+const { get } = require('../utils/get');
 
 const MESSAGE = 'Do not use unguarded document references. Please see the following guide for more infromation: http://github.com/chadhietala/ember-best-practices/files/guides/no-unguarded-document.md';
 
 function isDocumentReference(node) {
-  return node.callee.object.name === 'document';
+  return get(node, 'callee.object.name') === 'document';
 }
 
 module.exports = {
@@ -19,4 +20,4 @@ module.exports = {
       }
     };
   }
-};
+};