Merge pull request #79 from nlfurniss/lint-callexpression

Add linting for CallExpessions like $.ajax()

Author: chadhietala

guides/rules/no-jquery-methods.md

@@ -2,22 +2,28 @@
 
 **TL;DR** The intent of this rule is to identify any blacklisted jQuery methods as deprecated.
 
-Provides the ability to blacklist a set of jQuery methods for deprecation. 
+Provides the ability to blacklist a set of jQuery methods for deprecation.
 The eventual goal being a complete removal of jQuery.
 
 # Usage
 
-Pass an argument array containing the specific blacklisted jQuery methods your consuming application is flagging for. 
+Pass an argument array containing the specific blacklisted jQuery methods your consuming application is flagging for.
 
 ```js
 const BLACKLIST = [
- -  'add',
- -  'addBack',
- -  'after',
- -  'ajaxComplete'
+  'add',
+  'addBack',
+  'after',
+  'ajaxComplete'
 ];
 
 rules: {
-  'ember-best-practices/no-jquery-methods': [2, BLACKLIST]
+  'ember-best-practices/no-jquery-methods': ['error', BLACKLIST]
 }
 ```
+To help generate this blacklist array, you can run this snippet in the console of your app:
+```js
+// In the dev tools console of your app.
+let $methods = [...new Set(Object.keys($).concat(Object.keys($.fn)))];
+copy(`'${$methods.join('\',\r\n\'')}'`)
+```

lib/rules/no-jquery-methods.js

@@ -6,7 +6,7 @@
 const { get } = require('../utils/get');
 
 function getMessage(blackListName) {
-  return `The use of ${blackListName} method has been deprecated.`;
+  return `The use of jQuery's ${blackListName} method has been deprecated.`;
 }
 
 function isJQueryCaller(node, name = null) {
@@ -53,6 +53,14 @@ module.exports = {
         jQueryLocalName = jQueryLocalName === get(node, 'init.name') ? varDecIDName : null;
       },
 
+      CallExpression(node) {
+        const calleeName = get(node, 'callee.property.name');
+        const parentCalleeName = get(node, 'callee.object.property.name');
+        if (BLACKLIST.includes(calleeName) && parentCalleeName === '$') {
+          context.report({ node: node.callee.property, message: getMessage(`${parentCalleeName}.${calleeName}()`) });
+        }
+      },
+
       MemberExpression(node) {
         let propertyName = get(node, 'property.name');
         let blackListName = BLACKLIST.includes(propertyName) ? propertyName : false;

tests/lib/rules/no-jquery-methods.js

@@ -34,7 +34,25 @@ ruleTester.run('no-jquery-methods', rule, {
         export default Ember.Component({
           init() {
             const myObj = {};
-            myObj[${BLACKLISTMETHOD}]();      
+            myObj[${BLACKLISTMETHOD}]();
+          }
+        });`,
+      options: [BLACKLISTMETHOD]
+    },
+    {
+      code: `
+        export default Ember.Component({
+          init() {
+            this.$.notBlacklistedMethod();
+          }
+        });`,
+      options: [BLACKLISTMETHOD]
+    },
+    {
+      code: `
+        export default Ember.Component({
+          init() {
+            Ember.$.notBlacklistedMethod();
           }
         });`,
       options: [BLACKLISTMETHOD]
@@ -109,7 +127,7 @@ ruleTester.run('no-jquery-methods', rule, {
         export default Ember.Component({
           init() {
             const myJQueryObj = this.$();
-            myJQueryObj[${BLACKLISTMETHOD}]();      
+            myJQueryObj[${BLACKLISTMETHOD}]();
           }
         });`,
       options: [BLACKLISTMETHOD],
@@ -130,6 +148,30 @@ ruleTester.run('no-jquery-methods', rule, {
       errors: [{
         message: getMessage(BLACKLISTMETHOD)
       }]
+    },
+    {
+      code: `
+        export default Ember.Component({
+          init() {
+            this.$.add();
+          }
+        });`,
+      options: [BLACKLISTMETHOD],
+      errors: [{
+        message: getMessage(`$.${BLACKLISTMETHOD}()`)
+      }]
+    },
+    {
+      code: `
+        export default Ember.Component({
+          init() {
+            Ember.$.add();
+          }
+        });`,
+      options: [BLACKLISTMETHOD],
+      errors: [{
+        message: getMessage(`$.${BLACKLISTMETHOD}()`)
+      }]
     }
   ]
 });