Skip to content

Commit f5937b2

Browse files
authored
Merge pull request #3 from chadhietala/fix-readme
Fixing README and adding a list rules we want to implement
2 parents 770e62e + 960018c commit f5937b2

File tree

2 files changed

+40
-15
lines changed

2 files changed

+40
-15
lines changed

README.md

Lines changed: 29 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -12,26 +12,40 @@ This adds more guard rails for Ember. Just because something "works" does not me
1212
# Why
1313
As we've scaled out to over hundreds developers and hundrends of lines of code it has become clear that more "development time" guidance is required. While the guides do a good job about getting started, it's good to have some friction to make sure the app code is aligned with how Ember works.
1414

15-
## Installation
15+
## Using the plugin with Ember CLI
1616

17-
* `git clone <repository-url>` this repository
18-
* `cd ember-strict-mode`
19-
* `npm install`
20-
* `bower install`
17+
### Installation
2118

22-
## Running
19+
Install the plugin as a dev dependency in your Ember CLI project.
2320

24-
* `ember serve`
25-
* Visit your app at [http://localhost:4200](http://localhost:4200).
21+
```
22+
npm install --save-dev eslint-plugin-ember-suave
23+
```
2624

27-
## Running Tests
25+
This will make the plugin available to ESLint.
2826

29-
* `npm test` (Runs `ember try:each` to test your addon against multiple Ember versions)
30-
* `ember test`
31-
* `ember test --server`
27+
Next, install the [ember-cli-eslint](https://github.com/ember-cli/ember-cli-eslint) addon so that your app can be linted during development and testing. This will also uninstall [ember-cli-jshint](https://github.com/ember-cli/ember-cli-jshint) since there is no need to have both linters running at the same time.
3228

33-
## Building
29+
```
30+
ember install ember-cli-eslint
31+
```
3432

35-
* `ember build`
33+
### Configuration
3634

37-
For more information on using ember-cli, visit [http://ember-cli.com/](http://ember-cli.com/).
35+
The `ember-cli-eslint` addon blueprint generates a .eslintrc.js configuration file at the root of the project.
36+
37+
Add the plugin's [recommended](https://github.com/chadhietala/eslint-plugin-ember-best-practices/blob/master/config/recommended.js) configuration to the list of extensions:
38+
39+
```
40+
// .eslintrc.js
41+
42+
module.exports = {
43+
// ...
44+
extends: [
45+
'eslint:recommended',
46+
'plugin:ember-best-practices/recommended'
47+
],
48+
rules: {
49+
}
50+
};
51+
```

RULES.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Pending Rules
2+
3+
These are rules we would like to enforce:
4+
5+
no-attrs-snapshots
6+
no-timers
7+
no-mixins
8+
no-sub-classes
9+
detect-stateless-service
10+
eager-injections
11+
no-send-action

0 commit comments

Comments
 (0)