Skip to content

Commit 0cabc4f

Browse files
committed
Fix onKeydown typo
1 parent 24ab917 commit 0cabc4f

File tree

4 files changed

+20
-6
lines changed

4 files changed

+20
-6
lines changed

addon/components/bs-form/element/control/power-select-multiple.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
@onClose={{@onClose}}
3232
@onFocus={{@onFocus}}
3333
@onInput={{@onInput}}
34-
@onKeyDown={{@onKeyDown}}
34+
@onKeydown={{@onKeydown}}
3535
@onOpen={{@onOpen}}
3636
@options={{@options}}
3737
@optionsComponent={{@optionsComponent}}

addon/components/bs-form/element/control/power-select.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
@onClose={{@onClose}}
3232
@onFocus={{@onFocus}}
3333
@onInput={{@onInput}}
34-
@onKeyDown={{@onKeyDown}}
34+
@onKeydown={{@onKeydown}}
3535
@onOpen={{@onOpen}}
3636
@options={{@options}}
3737
@optionsComponent={{@optionsComponent}}

tests/integration/components/bs-form/element/control/power-select-multiple-test.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { module, test } from 'qunit';
22
import { setupRenderingTest } from 'ember-qunit';
3-
import { render, click, find, findAll } from '@ember/test-helpers';
3+
import { render, click, find, findAll, triggerKeyEvent } from '@ember/test-helpers';
44
import hbs from 'htmlbars-inline-precompile';
55
import { clickTrigger } from 'ember-power-select/test-support/helpers';
66

@@ -132,13 +132,20 @@ module(
132132
});
133133

134134
test('it passes power-select @options', async function (assert) {
135+
let lastKeyPress = null;
136+
this.set('onKeydown', function (select, event) {
137+
lastKeyPress = event.keyCode;
138+
return true;
139+
});
135140
await render(hbs`
136141
<BsForm as |form|>
137142
<form.element @controlType="power-select-multiple" @property="prop2" @options={{this.options}} @placeholder="something" as |el|>
138-
<el.control @searchEnabled={{false}} @triggerClass="form-control" />
143+
<el.control @onKeydown={{this.onKeydown}} @searchEnabled={{false}} @triggerClass="form-control" />
139144
</form.element>
140145
</BsForm>`);
141146
assert.dom('.form-control').exists();
147+
await triggerKeyEvent('.form-control', 'keydown', 'X');
148+
assert.strictEqual(lastKeyPress, 88);
142149
await clickTrigger();
143150
assert.dom('.ember-power-select-search-input').doesNotExist();
144151
});

tests/integration/components/bs-form/element/control/power-select-test.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { module, test } from 'qunit';
22
import { setupRenderingTest } from 'ember-qunit';
3-
import { render, click, find, findAll } from '@ember/test-helpers';
3+
import { render, click, find, findAll, triggerKeyEvent } from '@ember/test-helpers';
44
import hbs from 'htmlbars-inline-precompile';
55
import { clickTrigger } from 'ember-power-select/test-support/helpers';
66

@@ -112,13 +112,20 @@ module(
112112
});
113113

114114
test('it passes power-select options', async function (assert) {
115+
let lastKeyPress = null;
116+
this.set('onKeydown', function (select, event) {
117+
lastKeyPress = event.keyCode;
118+
return true;
119+
});
115120
await render(hbs`
116121
<BsForm as |form|>
117122
<form.element @controlType="power-select" @property="prop2" @options={{this.options}} @placeholder="something" as |el|>
118-
<el.control @searchEnabled={{false}} @triggerClass="form-control" />
123+
<el.control @onKeydown={{this.onKeydown}} @searchEnabled={{false}} @triggerClass="form-control" />
119124
</form.element>
120125
</BsForm>`);
121126
assert.dom('.form-control').exists();
127+
await triggerKeyEvent('.form-control', 'keydown', 'X');
128+
assert.strictEqual(lastKeyPress, 88);
122129
await clickTrigger();
123130
assert.dom('.ember-power-select-search-input').doesNotExist();
124131
});

0 commit comments

Comments
 (0)