Skip to content

Commit f825000

Browse files
authored
Merge pull request #361 from ember-bootstrap/upgrade-blueprint-files-to-ember-cli-4.10
upgrade blueprint files to Ember CLI 4.10
2 parents edb19a4 + 0da47d4 commit f825000

25 files changed

+246
-299
lines changed

.ember-cli

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,11 @@
55

66
Setting `disableAnalytics` to true will prevent any data from being sent.
77
*/
8-
"disableAnalytics": false
8+
"disableAnalytics": false,
9+
10+
/**
11+
Setting `isTypeScriptProject` to true will force the blueprint generators to generate TypeScript
12+
rather than JavaScript by default, when a TypeScript version of a given blueprint is available.
13+
*/
14+
"isTypeScriptProject": false
915
}

.eslintignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,7 @@
1919
# ember-try
2020
/.node_modules.ember-try/
2121
/bower.json.ember-try
22+
/npm-shrinkwrap.json.ember-try
2223
/package.json.ember-try
24+
/package-lock.json.ember-try
25+
/yarn.lock.ember-try

.eslintrc.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,10 @@ module.exports = {
4141
browser: false,
4242
node: true,
4343
},
44-
plugins: ['node'],
45-
extends: ['plugin:node/recommended'],
44+
extends: ['plugin:n/recommended'],
4645
},
4746
{
48-
// Test files:
47+
// test files
4948
files: ['tests/**/*-test.{js,ts}'],
5049
extends: ['plugin:qunit/recommended'],
5150
},

.github/workflows/ci.yml

Lines changed: 43 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -3,76 +3,83 @@ name: CI
33
on:
44
push:
55
branches:
6+
- main
67
- master
78
- renovate/*
89
tags:
910
- '*'
10-
pull_request:
11+
pull_request: {}
1112
schedule:
1213
- cron: '0 4 * * 5' # Fridays at 4am
1314

15+
concurrency:
16+
group: ci-${{ github.head_ref || github.ref }}
17+
cancel-in-progress: true
18+
1419
jobs:
1520
test:
16-
name: Tests
21+
name: "Tests"
1722
runs-on: ubuntu-latest
23+
timeout-minutes: 10
1824

1925
steps:
20-
- name: Checkout code
21-
uses: actions/checkout@v3
22-
- name: Setup node.js
26+
- uses: actions/checkout@v3
27+
- name: Install Node
2328
uses: actions/setup-node@v3
2429
with:
25-
node-version: 14
26-
- name: Install dependencies
27-
uses: bahmutov/npm-install@v1
30+
node-version: 14.x
31+
cache: yarn
32+
- name: Install Dependencies
33+
run: yarn install --frozen-lockfile
2834
- name: Lint
2935
run: yarn lint
30-
- name: Test
36+
- name: Run Tests
3137
run: yarn test:ember
3238

33-
test-no-lock:
34-
name: Floating Dependencies
39+
floating:
40+
name: "Floating Dependencies"
3541
runs-on: ubuntu-latest
36-
needs:
37-
- test
42+
timeout-minutes: 10
43+
3844
steps:
39-
- name: Checkout code
40-
uses: actions/checkout@v3
41-
- name: Setup node.js
42-
uses: actions/setup-node@v3
45+
- uses: actions/checkout@v3
46+
- uses: actions/setup-node@v3
4347
with:
44-
node-version: 14
45-
- name: Install dependencies
46-
uses: bahmutov/npm-install@v1
47-
with:
48-
useLockFile: false
49-
- name: Test
48+
node-version: 14.x
49+
cache: yarn
50+
- name: Install Dependencies
51+
run: yarn install --no-lockfile
52+
- name: Run Tests
5053
run: yarn test:ember
5154

52-
test-try:
53-
name: Additional Tests
55+
try-scenarios:
56+
name: ${{ matrix.try-scenario }}
5457
runs-on: ubuntu-latest
55-
needs:
56-
- test
58+
needs: "test"
59+
timeout-minutes: 10
60+
5761
strategy:
5862
fail-fast: false
5963
matrix:
60-
scenario:
64+
try-scenario:
6165
- ember-lts-3.28
6266
- ember-lts-4.4
6367
- ember-lts-4.8
6468
- ember-release
6569
- ember-beta
6670
- ember-canary
6771
- ember-classic
72+
# - embroider-safe
73+
# - embroider-optimized
74+
6875
steps:
69-
- name: Checkout code
70-
uses: actions/checkout@v3
71-
- name: Setup node.js
76+
- uses: actions/checkout@v3
77+
- name: Install Node
7278
uses: actions/setup-node@v3
7379
with:
74-
node-version: 14
75-
- name: Install dependencies
76-
uses: bahmutov/npm-install@v1
77-
- name: Test
78-
run: yarn ember try:one ${{ matrix.scenario }}
80+
node-version: 14.x
81+
cache: yarn
82+
- name: Install Dependencies
83+
run: yarn install --frozen-lockfile
84+
- name: Run Tests
85+
run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}

.gitignore

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,4 +23,10 @@
2323
# ember-try
2424
/.node_modules.ember-try/
2525
/bower.json.ember-try
26+
/npm-shrinkwrap.json.ember-try
2627
/package.json.ember-try
28+
/package-lock.json.ember-try
29+
/yarn.lock.ember-try
30+
31+
# broccoli-debug
32+
/DEBUG/

.npmignore

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,14 @@
1414
/.eslintignore
1515
/.eslintrc.js
1616
/.git/
17+
/.github/
1718
/.gitignore
1819
/.prettierignore
1920
/.prettierrc.js
2021
/.template-lintrc.js
2122
/.travis.yml
2223
/.watchmanconfig
2324
/bower.json
24-
/config/ember-try.js
2525
/CONTRIBUTING.md
2626
/ember-cli-build.js
2727
/testem.js
@@ -33,4 +33,7 @@
3333
# ember-try
3434
/.node_modules.ember-try/
3535
/bower.json.ember-try
36+
/npm-shrinkwrap.json.ember-try
3637
/package.json.ember-try
38+
/package-lock.json.ember-try
39+
/yarn.lock.ember-try

.prettierignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,12 @@
1414
/coverage/
1515
!.*
1616
.eslintcache
17+
.lint-todo/
1718

1819
# ember-try
1920
/.node_modules.ember-try/
2021
/bower.json.ember-try
22+
/npm-shrinkwrap.json.ember-try
2123
/package.json.ember-try
24+
/package-lock.json.ember-try
25+
/yarn.lock.ember-try

.prettierrc.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
'use strict';
22

33
module.exports = {
4-
singleQuote: true,
4+
overrides: [
5+
{
6+
files: '*.{js,ts}',
7+
options: {
8+
singleQuote: true,
9+
},
10+
},
11+
],
512
};

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@
2222
* `ember serve`
2323
* Visit the dummy application at [http://localhost:4200](http://localhost:4200).
2424

25-
For more information on using ember-cli, visit [https://ember-cli.com/](https://ember-cli.com/).
25+
For more information on using ember-cli, visit [https://cli.emberjs.com/release/](https://cli.emberjs.com/release/).

README.md

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
Integrate [Ember Power Select](http://www.ember-power-select.com/) into your [Ember Bootstrap](https://www.ember-bootstrap.com)
88
forms.
99

10-
Compatibility
11-
------------------------------------------------------------------------------
10+
## Compatibility
1211

1312
* Ember Power Select v6 or above
1413
* Ember Bootstrap v5 or above
@@ -17,8 +16,7 @@ Compatibility
1716
* Node.js v14 or above
1817

1918

20-
Installation
21-
------------------------------------------------------------------------------
19+
## Installation
2220

2321
```bash
2422
ember install ember-bootstrap-power-select
@@ -28,8 +26,7 @@ This will additionally install `ember-power-select` into your app, and setup its
2826
Bootstrap theme, either by importing the appropriate Less or Sass file (if you use one of these preprocessors), or by
2927
editing your `ember-cli-build.js` to include the static theme CSS (if you use plain CSS).
3028

31-
Usage
32-
------------------------------------------------------------------------------
29+
## Usage
3330

3431
With this addon installed, you have a new `controlType` of `power-select` available. Use the `options` property to
3532
set the array of selectable options:
@@ -87,12 +84,10 @@ action are already wired up to the controlling `form.element` for you. Set any o
8784

8885
Please consult the [Ember Power Select documentation](http://www.ember-power-select.com/docs) for all available options.
8986

90-
Contributing
91-
------------------------------------------------------------------------------
87+
## Contributing
9288

9389
See the [Contributing](CONTRIBUTING.md) guide for details.
9490

95-
License
96-
------------------------------------------------------------------------------
91+
## License
9792

9893
This project is licensed under the [MIT License](LICENSE.md).

0 commit comments

Comments
 (0)