Merge pull request #12 from joshuaconner/more-slack-options

Add support for `iconURL` and `iconEmoji` config props

Author: LevelbossMike

README.md

@@ -70,6 +70,14 @@ The channel in slack that the notification should be displayed in in Slack.
 
 The username that will send the message in Slack.
 
+###iconURL
+
+URL to an image to use as the message's icon.
+
+###iconEmoji
+
+Slack emoji code to use as the message's icon (like `:heart_eyes_cat:` or `:saxophone:`).
+
 ## Customization
 
 `ember-cli-deploy-slack` will send default messages on the `didDeploy`- and

index.js

@@ -136,12 +136,16 @@ module.exports = {
 
         var channel   = this.readConfig('channel');
         var username  = this.readConfig('username');
+        var iconURL  = this.readConfig('iconURL');
+        var iconEmoji  = this.readConfig('iconEmoji');
 
         return this.readConfig('slackNotifier') || new SlackNotifier({
           enabled: enabled,
           webhookURL: webhookURL,
           channel: channel,
-          username: username
+          username: username,
+          iconURL: iconURL,
+          iconEmoji: iconEmoji
         });
       }
     });

lib/slack-notifier.js

@@ -6,10 +6,7 @@ module.exports = CoreObject.extend({
   init: function(data) {
     this._super(data);
 
-    this.slack = new Slack(this.webhookURL, {
-      channel: this.channel,
-      username: this.username
-    });
+    this.slack = new Slack(this.webhookURL, this._getSlackOptions());
 
     this.notify = function(message) {
       return new Promise(function(resolve, reject) {
@@ -24,5 +21,19 @@ module.exports = CoreObject.extend({
         }
       }.bind(this));
     }
+  },
+
+  _getSlackOptions: function () {
+    var options = {
+      channel: this.channel,
+      username: this.username
+    };
+    if (this.iconURL) {
+      options.icon_url = this.iconURL;
+    }
+    if (this.iconEmoji) {
+      options.icon_emoji = this.iconEmoji;
+    }
+    return options;
   }
 });

node-tests/unit/slack-test.js

@@ -38,6 +38,42 @@ describe('SlackNotifier', function() {
     expect(slack.username).to.eql(USER_NAME);
   });
 
+  describe('#_getSlackOptions', function() {
+    it("snake_cases and adds `iconURL` and/or `iconEmoji` options if they are set", function() {
+      var iconEmojiOnly = new SlackNotifier({
+        enabled: true,
+        webhookURL: WEBHOOK_URL,
+        channel: CHANNEL,
+        username: USER_NAME,
+        iconEmoji: ':dromedary_camel:'
+      });
+      var bothOptions = new SlackNotifier({
+        enabled: true,
+        webhookURL: WEBHOOK_URL,
+        channel: CHANNEL,
+        username: USER_NAME,
+        iconEmoji: ':dromedary_camel:',
+        iconURL: 'http://placehold.it/128x128'
+      });
+
+      expect(slack._getSlackOptions()).to.eql({
+        channel: CHANNEL,
+        username: USER_NAME
+      });
+      expect(iconEmojiOnly._getSlackOptions()).to.eql({
+        channel: CHANNEL,
+        username: USER_NAME,
+        icon_emoji: ':dromedary_camel:'
+      });
+      expect(bothOptions._getSlackOptions()).to.eql({
+        channel: CHANNEL,
+        username: USER_NAME,
+        icon_emoji: ':dromedary_camel:',
+        icon_url: 'http://placehold.it/128x128'
+      });
+    });
+  });
+
   describe('enabled', function() {
     describe('#notify', function() {
       it('is callable', function() {