Skip to content

Commit 12a716b

Browse files
author
Robert Jackson
committed
Add tests for Ember 3.27+ modules based API.
No changes were needed (we already supported a modules based API), but this documents the chagnes needed in [email protected] to avoid knock on deprecations.
1 parent f067606 commit 12a716b

File tree

6 files changed

+135
-57
lines changed

6 files changed

+135
-57
lines changed
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
2+
3+
if (true /* DEBUG */) {
4+
doStuff();
5+
}
6+
7+
(true && Ember.warn('This is a warning'));
8+
(true && !(foo) && Ember.assert('Hahahaha', foo));
9+
(true && !(false) && Ember.assert('without predicate'));
10+
(true && !(true) && Ember.deprecate('This thing is donzo', true, {
11+
id: 'donzo',
12+
until: '4.0.0',
13+
url: 'http://example.com'
14+
}));
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
if (true
2+
/* DEBUG */
3+
) {
4+
doStuff();
5+
}
6+
7+
(true && Ember.warn('This is a warning'));
8+
(true && !(foo) && Ember.assert('Hahahaha', foo));
9+
(true && !(false) && Ember.assert('without predicate'));
10+
(true && !(true) && Ember.deprecate('This thing is donzo', true, {
11+
id: 'donzo',
12+
until: '4.0.0',
13+
url: 'http://example.com'
14+
}));
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
import { warn, assert, deprecate } from '@ember/debug';
2+
import { DEBUG } from '@glimmer/env';
3+
4+
if (DEBUG) {
5+
doStuff();
6+
}
7+
8+
warn('This is a warning');
9+
10+
assert('Hahahaha', foo);
11+
assert('without predicate');
12+
13+
deprecate('This thing is donzo', true, {
14+
id: 'donzo',
15+
until: '4.0.0',
16+
url: 'http://example.com'
17+
});

fixtures/ember-cli-babel-config/expectation6.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
1+
import { warn, assert, deprecate } from '@ember/debug';
12

23

34
if (true /* DEBUG */) {
45
doStuff();
56
}
67

7-
(true && Ember.warn('This is a warning'));
8-
(true && !(foo) && Ember.assert('Hahahaha', foo));
9-
(true && !(false) && Ember.assert('without predicate'));
10-
(true && !(true) && Ember.deprecate('This thing is donzo', true, {
8+
(true && warn('This is a warning'));
9+
(true && !(foo) && assert('Hahahaha', foo));
10+
(true && !(false) && assert('without predicate'));
11+
(true && !(true) && deprecate('This thing is donzo', true, {
1112
id: 'donzo',
1213
until: '4.0.0',
1314
url: 'http://example.com'

fixtures/ember-cli-babel-config/expectation7.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,15 @@
1+
import { warn, assert, deprecate } from '@ember/debug';
2+
13
if (true
24
/* DEBUG */
35
) {
46
doStuff();
57
}
68

7-
(true && Ember.warn('This is a warning'));
8-
(true && !(foo) && Ember.assert('Hahahaha', foo));
9-
(true && !(false) && Ember.assert('without predicate'));
10-
(true && !(true) && Ember.deprecate('This thing is donzo', true, {
9+
(true && warn('This is a warning'));
10+
(true && !(foo) && assert('Hahahaha', foo));
11+
(true && !(false) && assert('without predicate'));
12+
(true && !(true) && deprecate('This thing is donzo', true, {
1113
id: 'donzo',
1214
until: '4.0.0',
1315
url: 'http://example.com'

tests/create-tests.js

Lines changed: 79 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -171,61 +171,91 @@ function createTests(options) {
171171
h.generateTest('global-external-helpers');
172172
});
173173

174-
describe('ember-cli-babel default configuration (legacy config API)', function() {
175-
beforeEach(function() {
176-
console.warn = () => {}; // eslint-disable-line
177-
});
174+
describe('ember-cli-babel configuration', function() {
175+
describe('Ember < 3.27', function() {
176+
describe('legacy config API', function() {
177+
beforeEach(function() {
178+
console.warn = () => {}; // eslint-disable-line
179+
});
178180

179-
let h = transformTestHelper({
180-
presets,
181-
plugins: [
182-
[
183-
DebugToolsPlugin,
184-
{
185-
externalizeHelpers: {
186-
global: 'Ember',
187-
},
188-
debugTools: {
189-
isDebug: true,
190-
source: '@ember/debug',
191-
assertPredicateIndex: 1,
192-
},
193-
envFlags: {
194-
source: '@glimmer/env',
195-
flags: {
196-
DEBUG: true,
181+
let h = transformTestHelper({
182+
presets,
183+
plugins: [
184+
[
185+
DebugToolsPlugin,
186+
{
187+
externalizeHelpers: {
188+
global: 'Ember',
189+
},
190+
debugTools: {
191+
isDebug: true,
192+
source: '@ember/debug',
193+
assertPredicateIndex: 1,
194+
},
195+
envFlags: {
196+
source: '@glimmer/env',
197+
flags: {
198+
DEBUG: true,
199+
},
200+
},
197201
},
198-
},
199-
},
200-
],
201-
],
202-
});
202+
],
203+
],
204+
});
203205

204-
h.generateTest('ember-cli-babel-config');
205-
});
206+
h.generateTest('ember-cli-babel-config-pre-3-27');
207+
});
206208

207-
describe('ember-cli-babel default configuration', function() {
208-
let h = transformTestHelper({
209-
presets,
210-
plugins: [
211-
[
212-
DebugToolsPlugin,
213-
{
214-
externalizeHelpers: {
215-
global: 'Ember',
216-
},
217-
debugTools: {
218-
isDebug: true,
219-
source: '@ember/debug',
220-
assertPredicateIndex: 1,
221-
},
222-
flags: [{ source: '@glimmer/env', flags: { DEBUG: true } }],
223-
},
224-
],
225-
],
209+
describe('default configuration', function() {
210+
let h = transformTestHelper({
211+
presets,
212+
plugins: [
213+
[
214+
DebugToolsPlugin,
215+
{
216+
externalizeHelpers: {
217+
global: 'Ember',
218+
},
219+
debugTools: {
220+
isDebug: true,
221+
source: '@ember/debug',
222+
assertPredicateIndex: 1,
223+
},
224+
flags: [{ source: '@glimmer/env', flags: { DEBUG: true } }],
225+
},
226+
],
227+
],
228+
});
229+
230+
h.generateTest('ember-cli-babel-config-pre-3-27');
231+
});
226232
});
227233

228-
h.generateTest('ember-cli-babel-config');
234+
describe('Ember >= 3.27', function() {
235+
describe('default configuration', function() {
236+
let h = transformTestHelper({
237+
presets,
238+
plugins: [
239+
[
240+
DebugToolsPlugin,
241+
{
242+
externalizeHelpers: {
243+
module: '@ember/debug',
244+
},
245+
debugTools: {
246+
isDebug: true,
247+
source: '@ember/debug',
248+
assertPredicateIndex: 1,
249+
},
250+
flags: [{ source: '@glimmer/env', flags: { DEBUG: true } }],
251+
},
252+
],
253+
],
254+
});
255+
256+
h.generateTest('ember-cli-babel-config');
257+
});
258+
});
229259
});
230260

231261
describe('Retain Module External Test Helpers', function() {

0 commit comments

Comments
 (0)