Merge pull request #77 from ember-cli/remove-error

Remove requirement for 'debugTools' options

Author: rwjblue

README.md

@@ -15,7 +15,7 @@ options.
 {
   plugins: [
     ['babel-debug-macros', {
-      // @required
+      // @optional
       debugTools: {
         isDebug: true,
         source: 'debug-tools',

fixtures/missing-debug-tools-options/expectation6.js

@@ -0,0 +1,8 @@
+import Bar from 'bar';
+import Baz from 'baz';
+
+export default class extends Bar {
+  static create() {
+    return new Baz(new this());
+  }
+}

fixtures/missing-debug-tools-options/expectation7.js

@@ -0,0 +1,8 @@
+import Bar from 'bar';
+import Baz from 'baz';
+export default class extends Bar {
+  static create() {
+    return new Baz(new this());
+  }
+
+}

fixtures/missing-debug-tools-options/sample.js

@@ -0,0 +1,8 @@
+import Bar from 'bar';
+import Baz from 'baz';
+
+export default class extends Bar {
+  static create() {
+    return new Baz(new this());
+  }
+}

src/utils/normalize-options.js

@@ -3,11 +3,11 @@
 const gt = require('semver').gt;
 
 function parseDebugTools(options) {
-  let debugTools = options.debugTools || {};
-
-  if (!debugTools) {
-    throw new Error('You must specify `debugTools.source`');
-  }
+  let debugTools = options.debugTools || {
+    isDebug: false,
+    source: '',
+    assertPredicateIndex: undefined,
+  };
 
   let isDebug = debugTools.isDebug;
   let debugToolsImport = debugTools.source;
@@ -17,10 +17,6 @@ function parseDebugTools(options) {
     isDebug = options.envFlags.flags.DEBUG;
   }
 
-  if (isDebug === undefined) {
-    throw new Error('You must specify `debugTools.isDebug`');
-  }
-
   return {
     isDebug,
     debugToolsImport,

tests/create-tests.js

@@ -80,6 +80,15 @@ function createTests(options) {
     h.generateTest('log-expansion');
   });
 
+  describe('Debug macros idempotnency', function() {
+    let h = transformTestHelper({
+      presets,
+      plugins: [[DebugToolsPlugin]],
+    });
+
+    h.generateTest('missing-debug-tools-options');
+  });
+
   describe('foreign debug imports', function() {
     let h = transformTestHelper({
       presets,

tests/normalize-options-test.js

@@ -9,6 +9,23 @@ describe('normalizeOptions', function() {
     Object.assign(console, originalConsole);
   });
 
+  it('does not require the `debugTools` options', function() {
+    let actual = normalizeOptions({});
+
+    let expected = {
+      debugTools: {
+        debugToolsImport: '',
+        assertPredicateIndex: undefined,
+        isDebug: false,
+      },
+      externalizeHelpers: undefined,
+      flags: {},
+      svelte: undefined,
+    };
+
+    expect(actual).toEqual(expected);
+  });
+
   it('converts "old style" options into the newer style (with deprecation)', function() {
     let warnings = [];
     console.warn = warning => warnings.push(warning); // eslint-disable-line