Skip to content

Commit e2453cc

Browse files
author
Chris Garrett
committed
Remove validation check for deprecation until
This transform currently verifies that `deprecate()` has a meta object with `id` and `until`. This info is helpful, but there are potential cases where the `until` may not be known, but we still want this stripping functionality. For instance, we're planning on adding `deprecate` to Glimmer VM. We still want the VM to be able to strip out these `deprecate` calls, but the VM ultimately isn't responsible for determining the major versions when the feature will be removed - that's up to the host environment. The plan is to have the host environment add `until` dynamically. I believe `id` is the only bit of metadata that is universal, so I decided to keep it.d
1 parent 76146b1 commit e2453cc

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

src/utils/builder.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -164,14 +164,6 @@ module.exports = class Builder {
164164
) {
165165
throw new ReferenceError(`deprecate's meta information requires an "id" field.`);
166166
}
167-
168-
if (
169-
meta &&
170-
meta.properties &&
171-
!meta.properties.some(prop => prop.key.name === 'until' || prop.key.value === 'until')
172-
) {
173-
throw new ReferenceError(`deprecate's meta information requires an "until" field.`);
174-
}
175167
},
176168
});
177169
}

0 commit comments

Comments
 (0)