chore: remove support for collecting deprecations without id

Simplifies the internal collector logic, to just collect a `Set` of ids.

Author: simonihmig

addon/index.js

@@ -5,7 +5,7 @@ const LOG_LIMIT = 100;
 export default function setupDeprecationWorkflow(config) {
   self.deprecationWorkflow = self.deprecationWorkflow || {};
   self.deprecationWorkflow.deprecationLog = {
-    messages: {},
+    messages: new Set(),
   };
 
   registerDeprecationHandler((message, options, next) =>
@@ -51,10 +51,10 @@ export function flushDeprecations({ handler = 'silence' } = {}) {
   let messages = self.deprecationWorkflow.deprecationLog.messages;
   let logs = [];
 
-  for (let [deprecation, matcher] of Object.entries(messages)) {
+  for (let id of messages.values()) {
     logs.push(
-      `    { handler: ${JSON.stringify(handler)}, ${matcher}: ${JSON.stringify(
-        deprecation,
+      `    { handler: ${JSON.stringify(handler)}, matchId: ${JSON.stringify(
+        id,
       )} }`,
     );
   }
@@ -108,10 +108,7 @@ export function handleDeprecationWorkflow(config, message, options, next) {
 }
 
 export function deprecationCollector(message, options, next) {
-  let key = (options && options.id) || message;
-  let matchKey = options && key === options.id ? 'matchId' : 'matchMessage';
-
-  self.deprecationWorkflow.deprecationLog.messages[key] = matchKey;
+  self.deprecationWorkflow.deprecationLog.messages.add(options.id);
 
   next(message, options);
 }

tests/acceptance/flush-deprecations-test.js

@@ -10,7 +10,7 @@ module('flushDeprecations', function (hooks) {
   });
 
   hooks.afterEach(function () {
-    window.deprecationWorkflow.deprecationLog = { messages: {} };
+    window.deprecationWorkflow.deprecationLog = { messages: new Set() };
     window.Testem.handleConsoleMessage = originalWarn;
   });
 

tests/acceptance/workflow-config-test.js

@@ -12,7 +12,7 @@ module('workflow config', function (hooks) {
   });
 
   hooks.afterEach(function () {
-    window.deprecationWorkflow.deprecationLog = { messages: {} };
+    window.deprecationWorkflow.deprecationLog = { messages: new Set() };
     window.Testem.handleConsoleMessage = originalWarn;
   });
 

tests/unit/deprecation-collector-test.js

@@ -17,7 +17,7 @@ module('deprecationCollector', function (hooks) {
     originalConfig = self.deprecationWorkflow = {
       config: null,
       deprecationLog: {
-        messages: {},
+        messages: new Set(),
       },
     };
   });
@@ -50,10 +50,10 @@ module('deprecationCollector', function (hooks) {
       () => {},
     );
 
-    assert.deepEqual(self.deprecationWorkflow.deprecationLog.messages, {
-      first: 'matchId',
-      second: 'matchId',
-    });
+    assert.deepEqual(
+      self.deprecationWorkflow.deprecationLog.messages,
+      new Set(['first', 'second']),
+    );
   });
 
   test('should call next', function (assert) {
@@ -119,9 +119,9 @@ module('deprecationCollector', function (hooks) {
       () => {},
     );
 
-    assert.deepEqual(self.deprecationWorkflow.deprecationLog.messages, {
-      first: 'matchId',
-      second: 'matchId',
-    });
+    assert.deepEqual(
+      self.deprecationWorkflow.deprecationLog.messages,
+      new Set(['first', 'second']),
+    );
   });
 });

tests/unit/flush-deprecations-test.js

@@ -16,22 +16,22 @@ module('flushDeprecations', function (hooks) {
     originalConfig = self.deprecationWorkflow = {
       config: null,
       deprecationLog: {
-        messages: [],
+        messages: new Set(),
       },
     };
   });
 
   hooks.afterEach(function () {
     self.deprecationWorkflow.config = originalConfig;
-    self.deprecationWorkflow.deprecationLog = { messages: {} };
+    self.deprecationWorkflow.deprecationLog = { messages: new Set() };
     console.warn = originalWarn;
   });
 
   test('calling flushDeprecations returns workflow config', function (assert) {
-    self.deprecationWorkflow.deprecationLog.messages = {
-      first: 'matchId',
-      second: 'matchId',
-    };
+    self.deprecationWorkflow.deprecationLog.messages = new Set([
+      'first',
+      'second',
+    ]);
 
     let deprecationsPayload = flushDeprecations();
     assert.strictEqual(
@@ -48,10 +48,10 @@ setupDeprecationWorkflow({
   });
 
   test('calling flushDeprecations with custom handler returns workflow config', function (assert) {
-    self.deprecationWorkflow.deprecationLog.messages = {
-      first: 'matchId',
-      second: 'matchId',
-    };
+    self.deprecationWorkflow.deprecationLog.messages = new Set([
+      'first',
+      'second',
+    ]);
 
     let deprecationsPayload = flushDeprecations({ handler: 'log' });
     assert.strictEqual(