Skip to content

Commit 2995a73

Browse files
committed
v3.25.2...v3.28.2
1 parent dd168b7 commit 2995a73

File tree

11 files changed

+297
-181
lines changed

11 files changed

+297
-181
lines changed

.eslintignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@
1414

1515
# misc
1616
/coverage/
17+
!.*
18+
.*/
19+
.eslintcache
1720

1821
# ember-try
1922
/.node_modules.ember-try/

.eslintrc.js

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,18 @@ module.exports = {
1515
// node files
1616
{
1717
files: [
18-
'.eslintrc.js',
19-
'.prettierrc.js',
20-
'.template-lintrc.js',
18+
'./.eslintrc.js',
19+
'./.prettierrc.js',
20+
'./.template-lintrc.js',
2121
'colocated-broccoli-plugin.js',
22-
'ember-cli-build.js',
22+
'./ember-cli-build.js',
2323
'lib/**/*.js',
24-
'testem.js',
25-
'blueprints/*/index.js',
26-
'config/**/*.js',
27-
'tests/dummy/config/**/*.js',
24+
'./testem.js',
25+
'./blueprints/*/index.js',
26+
'./config/**/*.js',
27+
'./tests/dummy/config/**/*.js',
2828
'tests/dummy/lib/**/*.js',
2929
],
30-
excludedFiles: ['addon/**', 'addon-test-support/**', 'app/**', 'tests/dummy/app/**'],
3130
parserOptions: {
3231
sourceType: 'script',
3332
ecmaVersion: 2018,
@@ -59,5 +58,10 @@ module.exports = {
5958
// add your custom rules and overrides for node files here
6059
}),
6160
},
61+
{
62+
// Test files:
63+
files: ['tests/**/*-test.{js,ts}'],
64+
extends: ['plugin:qunit/recommended'],
65+
},
6266
],
6367
};

.github/workflows/ci.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,13 +76,15 @@ jobs:
7676
matrix:
7777
ember-try-scenario:
7878
- ember-lts-3.8
79-
- ember-lts-3.12
80-
- ember-lts-3.16
79+
- ember-lts-3.20
80+
- ember-lts-3.24
8181
- ember-release
82-
- ember-octane
8382
- ember-beta
8483
- ember-canary
84+
- ember-classic
8585
- ember-default-with-jquery
86+
- embroider-safe
87+
- embroider-optimized
8688
- with-ember-cli-htmlbars-inline-precompile
8789

8890
steps:

.npmignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,18 @@
1212
/.eslintignore
1313
/.eslintrc.js
1414
/.gitignore
15+
/.prettierignore
16+
/.prettierrc.js
17+
/.template-lintrc.js
18+
/.travis.yml
1519
/.watchmanconfig
1620
/.travis.yml
1721
/bower.json
1822
/config/ember-try.js
1923
/ember-cli-build.js
2024
/testem.js
2125
/tests/
26+
/yarn-error.log
2227
/yarn.lock
2328
/node-tests/
2429
.gitkeep

config/ember-try.js

Lines changed: 74 additions & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -1,102 +1,98 @@
11
'use strict';
22

33
const getChannelURL = require('ember-source-channel-url');
4+
const { embroiderSafe, embroiderOptimized } = require('@embroider/test-setup');
45

5-
module.exports = function () {
6-
return Promise.all([
7-
getChannelURL('release'),
8-
getChannelURL('beta'),
9-
getChannelURL('canary'),
10-
]).then((urls) => {
11-
return {
12-
useYarn: true,
13-
scenarios: [
14-
{
15-
name: 'ember-lts-3.8',
16-
npm: {
17-
devDependencies: {
18-
'ember-source': '~3.8.0',
19-
},
6+
module.exports = async function () {
7+
return {
8+
useYarn: true,
9+
scenarios: [
10+
{
11+
name: 'ember-lts-3.8',
12+
npm: {
13+
devDependencies: {
14+
'ember-source': '~3.8.0',
2015
},
2116
},
22-
{
23-
name: 'ember-lts-3.12',
24-
npm: {
25-
devDependencies: {
26-
'ember-source': '~3.12.0',
27-
},
17+
},
18+
{
19+
name: 'ember-lts-3.20',
20+
npm: {
21+
devDependencies: {
22+
'ember-source': '~3.20.5',
2823
},
2924
},
30-
{
31-
name: 'ember-lts-3.16',
32-
npm: {
33-
devDependencies: {
34-
'ember-source': '~3.16.0',
35-
},
25+
},
26+
{
27+
name: 'ember-lts-3.24',
28+
npm: {
29+
devDependencies: {
30+
'ember-source': '~3.24.3',
3631
},
3732
},
38-
{
39-
name: 'ember-release',
40-
npm: {
41-
devDependencies: {
42-
'ember-source': urls[0],
43-
},
33+
},
34+
{
35+
name: 'ember-release',
36+
npm: {
37+
devDependencies: {
38+
'ember-source': await getChannelURL('release'),
4439
},
4540
},
46-
{
47-
name: 'ember-beta',
48-
npm: {
49-
devDependencies: {
50-
'ember-source': urls[1],
51-
},
41+
},
42+
{
43+
name: 'ember-beta',
44+
npm: {
45+
devDependencies: {
46+
'ember-source': await getChannelURL('beta'),
5247
},
5348
},
54-
{
55-
name: 'ember-canary',
56-
npm: {
57-
devDependencies: {
58-
'ember-source': urls[2],
59-
},
49+
},
50+
{
51+
name: 'ember-canary',
52+
npm: {
53+
devDependencies: {
54+
'ember-source': await getChannelURL('canary'),
6055
},
6156
},
62-
{
63-
name: 'ember-default',
64-
npm: {
65-
devDependencies: {},
66-
},
57+
},
58+
{
59+
name: 'ember-default-with-jquery',
60+
env: {
61+
EMBER_OPTIONAL_FEATURES: JSON.stringify({
62+
'jquery-integration': true,
63+
}),
6764
},
68-
{
69-
name: 'ember-octane',
70-
ENV: {
71-
// need to add a convienient API for this to @ember/edition-utils
72-
EMBER_EDITION: 'octane',
73-
},
74-
npm: {
75-
devDependencies: {},
65+
npm: {
66+
devDependencies: {
67+
'@ember/jquery': '^1.1.0',
7668
},
7769
},
78-
{
79-
name: 'with-ember-cli-htmlbars-inline-precompile',
80-
npm: {
81-
devDependencies: {
82-
'ember-cli-htmlbars-inline-precompile': '^3.0.0',
83-
},
84-
},
70+
},
71+
{
72+
name: 'ember-classic',
73+
env: {
74+
EMBER_OPTIONAL_FEATURES: JSON.stringify({
75+
'application-template-wrapper': true,
76+
'default-async-observers': false,
77+
'template-only-glimmer-components': false,
78+
}),
8579
},
86-
{
87-
name: 'ember-default-with-jquery',
88-
env: {
89-
EMBER_OPTIONAL_FEATURES: JSON.stringify({
90-
'jquery-integration': true,
91-
}),
80+
npm: {
81+
ember: {
82+
edition: 'classic',
9283
},
93-
npm: {
94-
devDependencies: {
95-
'@ember/jquery': '^0.5.1',
96-
},
84+
},
85+
},
86+
embroiderSafe(),
87+
embroiderOptimized(),
88+
{
89+
name: 'with-ember-cli-htmlbars-inline-precompile',
90+
npm: {
91+
devDependencies: {
92+
'ember-cli-htmlbars-inline-precompile': '^3.0.0',
9793
},
9894
},
99-
],
100-
};
101-
});
95+
},
96+
],
97+
};
10298
};

ember-cli-build.js

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,12 @@ module.exports = function (defaults) {
4949
behave. You most likely want to be modifying `./index.js` or app's build file
5050
*/
5151

52-
return app.toTree();
52+
const { maybeEmbroider } = require('@embroider/test-setup');
53+
return maybeEmbroider(app, {
54+
skipBabel: [
55+
{
56+
package: 'qunit',
57+
},
58+
],
59+
});
5360
};

package.json

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@
3232
"test:node:debug": "mocha debug node-tests/*.js"
3333
},
3434
"dependencies": {
35-
"babel-plugin-ember-template-compilation": "^1.0.0",
3635
"@ember/edition-utils": "^1.2.0",
36+
"babel-plugin-ember-template-compilation": "^1.0.0",
3737
"babel-plugin-htmlbars-inline-precompile": "^5.3.0",
3838
"broccoli-debug": "^0.6.5",
3939
"broccoli-persistent-filter": "^3.1.2",
@@ -57,6 +57,7 @@
5757
"@babel/runtime": "^7.13.8",
5858
"@ember/optional-features": "^2.0.0",
5959
"@ember/test-helpers": "^2.4.2",
60+
"@embroider/test-setup": "^0.43.5",
6061
"babel-eslint": "^10.1.0",
6162
"babel-plugin-debug-macros": "^0.3.3",
6263
"broccoli-merge-trees": "^4.2.0",
@@ -67,26 +68,27 @@
6768
"console-ui": "^3.1.2",
6869
"core-object": "^3.1.5",
6970
"ember-auto-import": "^2.2.0",
70-
"ember-cli": "~3.25.2",
71+
"ember-cli": "~3.28.2",
7172
"ember-cli-app-version": "^4.0.0",
72-
"ember-cli-babel": "^7.25.0",
73+
"ember-cli-babel": "^7.26.6",
7374
"ember-cli-dependency-checker": "^3.2.0",
7475
"ember-cli-inject-live-reload": "^2.1.0",
7576
"ember-export-application-global": "^2.0.1",
7677
"ember-load-initializers": "^2.1.1",
7778
"ember-maybe-import-regenerator": "^0.1.6",
7879
"ember-qunit": "^5.1.4",
7980
"ember-resolver": "^8.0.2",
80-
"ember-source": "~3.25.0",
81+
"ember-source": "~3.28.0",
8182
"ember-source-channel-url": "^3.0.0",
82-
"ember-template-lint": "^2.9.1",
83+
"ember-template-lint": "^3.6.0",
8384
"ember-try": "^1.4.0",
84-
"eslint": "^7.25.0",
85+
"eslint": "^7.32.0",
8586
"eslint-config-prettier": "^8.3.0",
86-
"eslint-plugin-ember": "^8.13.0",
87+
"eslint-plugin-ember": "^10.5.4",
8788
"eslint-plugin-mocha": "^8.0.0",
8889
"eslint-plugin-node": "^11.1.0",
89-
"eslint-plugin-prettier": "^3.4.0",
90+
"eslint-plugin-prettier": "^3.4.1",
91+
"eslint-plugin-qunit": "^6.2.0",
9092
"fixturify": "^2.1.1",
9193
"loader.js": "^4.7.0",
9294
"mocha": "^8.4.0",
@@ -99,7 +101,7 @@
99101
"webpack": "^5.58.2"
100102
},
101103
"engines": {
102-
"node": ">= 12.*"
104+
"node": "12.* || 14.* || >= 16"
103105
},
104106
"publishConfig": {
105107
"registry": "https://registry.npmjs.org"
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
{
2+
"schemaVersion": "1.0.0",
3+
"packages": [
4+
{
5+
"name": "ember-cli",
6+
"version": "3.28.2",
7+
"blueprints": [
8+
{
9+
"name": "addon",
10+
"outputRepo": "https://github.com/ember-cli/ember-addon-output",
11+
"codemodsSource": "ember-addon-codemods-manifest@1",
12+
"isBaseBlueprint": true,
13+
"options": [
14+
"--yarn",
15+
"--no-welcome"
16+
]
17+
}
18+
]
19+
}
20+
]
21+
}

tests/dummy/config/targets.js

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,20 @@
22

33
const browsers = ['last 1 Chrome versions', 'last 1 Firefox versions', 'last 1 Safari versions'];
44

5-
const isCI = !!process.env.CI;
6-
const isProduction = process.env.EMBER_ENV === 'production';
7-
8-
if (isCI || isProduction) {
9-
browsers.push('ie 11');
10-
}
5+
// Ember's browser support policy is changing, and IE11 support will end in
6+
// v4.0 onwards.
7+
//
8+
// See https://deprecations.emberjs.com/v3.x#toc_3-0-browser-support-policy
9+
//
10+
// If you need IE11 support on a version of Ember that still offers support
11+
// for it, uncomment the code block below.
12+
//
13+
// const isCI = Boolean(process.env.CI);
14+
// const isProduction = process.env.EMBER_ENV === 'production';
15+
//
16+
// if (isCI || isProduction) {
17+
// browsers.push('ie 11');
18+
// }
1119

1220
module.exports = {
1321
browsers,

tests/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
</div>
2929
</div>
3030

31-
<script src="/testem.js" integrity=""></script>
31+
<script src="/testem.js" integrity="" data-embroider-ignore></script>
3232
<script src="{{rootURL}}assets/vendor.js"></script>
3333
<script src="{{rootURL}}assets/test-support.js"></script>
3434
<script src="{{rootURL}}assets/dummy.js"></script>

0 commit comments

Comments
 (0)