legacy AST plugins are dropped in ember 4

Author: ef4

tests/dummy/lib/module-name-inliner/index.js

@@ -10,7 +10,6 @@ module.exports = {
   setupPreprocessorRegistry(type, registry) {
     // can only add the plugin with this style on newer Ember versions
     registry.add('htmlbars-ast-plugin', this.buildPlugin());
-    registry.add('htmlbars-ast-plugin', this.buildLegacyPlugin());
   },
 
   buildPlugin() {
@@ -44,42 +43,4 @@ module.exports = {
       },
     };
   },
-
-  // this type of plugin has worked since at least Ember 2.4+
-  buildLegacyPlugin() {
-    return {
-      name: 'module-name-inliner',
-      baseDir() {
-        return __dirname;
-      },
-      parallelBabel: {
-        requireFile: __filename,
-        buildUsing: 'buildLegacyPlugin',
-        params: {},
-      },
-
-      plugin: class LegacyPlugin {
-        constructor(options) {
-          this.options = options;
-        }
-
-        transform(ast) {
-          let { meta } = this.options;
-          let b = this.syntax.builders;
-
-          this.syntax.traverse(ast, {
-            // replacing the mustache with text, like this
-            // {{module-name-reverser}} -> `some-module-name`
-            MustacheStatement(node) {
-              if (node.path.original === 'module-name-reverser') {
-                return b.text(meta.moduleName.split('').reverse().join(''));
-              }
-            },
-          });
-
-          return ast;
-        }
-      },
-    };
-  },
 };

tests/integration/components/ast-plugins-test.js

@@ -6,15 +6,6 @@ import { hbs } from 'ember-cli-htmlbars';
 module('tests/integration/components/ast-plugins-test', function (hooks) {
   setupRenderingTest(hooks);
 
-  test('stand alone templates have "legacy" AST plugins ran', async function (assert) {
-    await render(hbs`{{x-module-name-reversed-component}}`);
-
-    assert.equal(
-      this.element.textContent.trim(),
-      'sbh.tnenopmoc-desrever-eman-eludom-x/stnenopmoc/setalpmet/ymmud'
-    );
-  });
-
   test('stand alone templates have AST plugins ran', async function (assert) {
     await render(hbs`{{x-module-name-inlined-component}}`);
 

tests/integration/components/test-inline-precompile-test.js

@@ -33,12 +33,6 @@ module('tests/integration/components/test-inline-precompile', function (hooks) {
     assert.equal(this.element.textContent.trim(), 'Wheeeee');
   });
 
-  test('inline templates have "legacy" AST plugins ran', async function (assert) {
-    await render(hbsThree('{{module-name-reverser}}', { moduleName: 'hello-template.hbs' }));
-
-    assert.equal(this.element.textContent.trim(), 'sbh.etalpmet-olleh');
-  });
-
   test('inline templates have AST plugins ran', async function (assert) {
     await render(hbsThree('{{module-name-inliner}}', { moduleName: 'hello-template.hbs' }));