Skip to content

Commit b61b91b

Browse files
committed
Fix incorrect ember-source version check
Found this bug in a monorepo setup with multiple apps, where one app was using an older version (3.26, so needed the modules API polyfill) while the others were on 3.28. With most dependencies being hoisted in the central `/node_modules`, for any addon that depends on ember-cli-htmlbars it would find the wrong ember-source package, namely `/node_modules/ember-source` instead of `apps/foo-app/node_modules/ember-source` (the correct 3.26 version). Fixes #687
1 parent ff397bb commit b61b91b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/ember-addon-main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ module.exports = {
170170

171171
let isProduction = process.env.EMBER_ENV === 'production';
172172

173-
let checker = new VersionChecker(this.parent).for('ember-source', 'npm');
173+
let checker = new VersionChecker(this.project).for('ember-source', 'npm');
174174
this._requiresModuleApiPolyfill = checker.exists() && checker.lt('3.27.0-alpha.1');
175175

176176
// add the babel-plugin-htmlbars-inline-precompile to the list of plugins

0 commit comments

Comments
 (0)