Merge pull request #788 from ember-cli/update-min-node

update minimum node version

Author: ef4

.github/workflows/ci.yml

@@ -5,27 +5,27 @@ on:
     branches:
       - master
       - main
-      - 'v*'
+      - "v*"
   pull_request: {}
   schedule:
-  - cron:  '0 6 * * 0' # weekly, on sundays
+    - cron: "0 6 * * 0" # weekly, on sundays
 
 jobs:
   lint:
     name: Linting
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-node@v3
-      with:
-        node-version: 18.x
-    - name: install dependencies
-      run: yarn install --frozen-lockfile
-    - name: lint:js
-      run: yarn lint:js
-    - name: lint:hbs
-      run: yarn lint:hbs
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 20.x
+      - name: install dependencies
+        run: yarn install --frozen-lockfile
+      - name: lint:js
+        run: yarn lint:js
+      - name: lint:hbs
+        run: yarn lint:hbs
 
   test:
     name: Tests
@@ -35,19 +35,19 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu, windows]
-        node-version: [18.x, 20.x]
+        node-version: [20.x, 24.x]
 
     steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-node@v3
-      with:
-        node-version: ${{ matrix.node-version }}
-    - name: install dependencies
-      run: yarn install --ignore-engines --frozen-lockfile
-    - name: node tests
-      run: yarn test:node
-    - name: ember test
-      run: yarn test:ember
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+      - name: install dependencies
+        run: yarn install --ignore-engines --frozen-lockfile
+      - name: node tests
+        run: yarn test:node
+      - name: ember test
+        run: yarn test:ember
 
   floating-dependencies:
     name: Floating Deps
@@ -56,16 +56,16 @@ jobs:
     needs: [test, lint]
 
     steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-node@v3
-      with:
-        node-version: 18.x
-    - name: install dependencies
-      run: yarn install --ignore-lockfile
-    - name: node tests
-      run: yarn test:node
-    - name: ember test
-      run: yarn test:ember
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 20.x
+      - name: install dependencies
+        run: yarn install --ignore-lockfile
+      - name: node tests
+        run: yarn test:node
+      - name: ember test
+        run: yarn test:ember
 
   try-scenarios:
     name: ${{ matrix.ember-try-scenario }}
@@ -78,21 +78,21 @@ jobs:
       fail-fast: false
       matrix:
         ember-try-scenario:
-         - ember-lts-4.12
-         - ember-release
-         - ember-beta
-         - ember-canary
-         - embroider-safe
-         - embroider-optimized
+          - ember-lts-4.12
+          - ember-release
+          - ember-beta
+          - ember-canary
+          - embroider-safe
+          - embroider-optimized
 
     steps:
-    - uses: actions/checkout@v3
-    - uses: actions/setup-node@v3
-      with:
-        node-version: 18.x
-    - name: install dependencies
-      run: yarn install
-    - name: test
-      env:
-        EMBER_TRY_SCENARIO: ${{ matrix.ember-try-scenario }}
-      run: node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 20.x
+      - name: install dependencies
+        run: yarn install
+      - name: test
+        env:
+          EMBER_TRY_SCENARIO: ${{ matrix.ember-try-scenario }}
+        run: node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO

README.md

@@ -7,7 +7,7 @@
 * Ember.js v4.12 or above
 * Ember CLI v4.12 or above
 * `@embroider/compat` 3.4.3 or above (optional)
-* Node.js v18 or above
+* Node.js v20 or above
 
 ## Adding Custom Plugins
 

package.json

@@ -43,13 +43,13 @@
     "heimdalljs-logger": "^0.1.10",
     "js-string-escape": "^1.0.1",
     "silent-error": "^1.1.1",
-    "walk-sync": "^2.2.0"
+    "walk-sync": "^4.0.1"
   },
   "devDependencies": {
     "@babel/core": "^7.23.6",
     "@babel/eslint-parser": "^7.23.3",
-    "@babel/plugin-transform-class-properties": "^7.23.3",
     "@babel/plugin-proposal-decorators": "^7.23.6",
+    "@babel/plugin-transform-class-properties": "^7.23.3",
     "@babel/plugin-transform-runtime": "^7.13.15",
     "@babel/plugin-transform-typescript": "^7.10.1",
     "@babel/runtime": "^7.13.8",
@@ -102,7 +102,7 @@
     "ember-source": ">= 4.0.0"
   },
   "engines": {
-    "node": ">= 18"
+    "node": ">= 20"
   },
   "publishConfig": {
     "registry": "https://registry.npmjs.org"

…ents/x-module-name-inlined-component.hbs …ents/x-module-name-inlined-component.hbstests/dummy/app/templates/components/x-module-name-inlined-component.hbs renamed to tests/dummy/app/components/x-module-name-inlined-component.hbs tests/dummy/app/templates/components/x-module-name-inlined-component.hbs renamed to tests/dummy/app/components/x-module-name-inlined-component.hbs

@@ -11,7 +11,7 @@ module('tests/integration/components/ast-plugins-test', function (hooks) {
 
     assert.strictEqual(
       this.element.textContent.trim(),
-      'dummy/templates/components/x-module-name-inlined-component.hbs',
+      'dummy/components/x-module-name-inlined-component.hbs',
     );
   });
 });