Skip to content

Commit a6571e1

Browse files
Kelly Seldenkellyselden
authored andcommitted
extract tmp helper
1 parent 62265a2 commit a6571e1

File tree

5 files changed

+16
-12
lines changed

5 files changed

+16
-12
lines changed

src/download-package.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
'use strict';
22

33
const path = require('path');
4-
const { promisify } = require('util');
5-
const tmpDir = promisify(require('tmp').dir);
4+
const { createTmpDir } = require('./tmp');
65
const npa = require('npm-package-arg');
76
const run = require('./run');
87

@@ -17,7 +16,7 @@ async function downloadPackage(name, url, range) {
1716
url += `#semver:${range}`;
1817
}
1918

20-
let newTmpDir = await tmpDir();
19+
let newTmpDir = await createTmpDir();
2120
let output = await run(`npm install ${url}`, { cwd: newTmpDir });
2221
// if (!name) {
2322
// name = output.match(/^\+ (.*)@\d\.\d\.\d.*$/m)[1];

src/tmp.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
'use strict';
2+
3+
const { promisify } = require('util');
4+
const createTmpDir = promisify(require('tmp').dir);
5+
6+
module.exports = {
7+
createTmpDir
8+
};

test/integration/check-for-blueprint-updates-test.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,15 @@ const { expect } = require('../helpers/chai');
55
const checkForBlueprintUpdates = require('../../src/check-for-blueprint-updates');
66
const { initBlueprint } = require('../helpers/blueprint');
77
const loadSafeBlueprintFile = require('../../src/load-safe-blueprint-file');
8-
const { promisify } = require('util');
9-
const tmpDir = promisify(require('tmp').dir);
8+
const { createTmpDir } = require('../../src/tmp');
109

1110
describe(checkForBlueprintUpdates, function() {
1211
this.timeout(30 * 1000);
1312

1413
let tmpPath;
1514

1615
beforeEach(async function() {
17-
tmpPath = await tmpDir();
16+
tmpPath = await createTmpDir();
1817
});
1918

2019
it('works', async function() {

test/integration/download-package-test.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ const { initBlueprint } = require('../helpers/blueprint');
88
const parseBlueprintPackage = require('../../src/parse-blueprint-package');
99
const downloadPackage = require('../../src/download-package');
1010
const loadSafeBlueprintFile = require('../../src/load-safe-blueprint-file');
11-
const { promisify } = require('util');
12-
const tmpDir = promisify(require('tmp').dir);
11+
const { createTmpDir } = require('../../src/tmp');
1312
const fs = require('fs-extra');
1413

1514
describe(downloadPackage, function() {
@@ -18,7 +17,7 @@ describe(downloadPackage, function() {
1817
let tmpPath;
1918

2019
beforeEach(async function() {
21-
tmpPath = path.join(await tmpDir(), 'app');
20+
tmpPath = path.join(await createTmpDir(), 'app');
2221
await fs.mkdir(tmpPath);
2322
});
2423

test/integration/save-blueprint-file-test.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,14 @@
33
const { describe, it } = require('../helpers/mocha');
44
const { expect } = require('../helpers/chai');
55
const path = require('path');
6-
const { promisify } = require('util');
7-
const tmpDir = promisify(require('tmp').dir);
6+
const { createTmpDir } = require('../../src/tmp');
87
const saveBlueprintFile = require('../../src/save-blueprint-file');
98

109
describe(saveBlueprintFile, function() {
1110
let tmpPath;
1211

1312
beforeEach(async function() {
14-
tmpPath = await tmpDir();
13+
tmpPath = await createTmpDir();
1514
});
1615

1716
it('works', async function() {

0 commit comments

Comments
 (0)