Skip to content

Commit 14ce97c

Browse files
committed
breaking: drops Node < 16.13 & Ember 3 tests
1 parent 7ad5c3c commit 14ce97c

File tree

4 files changed

+44
-78
lines changed

4 files changed

+44
-78
lines changed

.github/workflows/CI.yml

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
name: "Linting"
1717
runs-on: ubuntu-latest
1818
steps:
19-
- uses: actions/checkout@v2
19+
- uses: actions/checkout@v3
2020
- run: yarn install --frozen-lockfile --non-interactive
2121
- run: yarn lint:js
2222

@@ -26,10 +26,10 @@ jobs:
2626
runs-on: ubuntu-latest
2727
strategy:
2828
matrix:
29-
node-version: ["12"]
29+
node-version: ["18"]
3030

3131
steps:
32-
- uses: actions/checkout@v2
32+
- uses: actions/checkout@v3
3333
with:
3434
node-version: ${{ matrix.node-version }}
3535
- run: yarn install --frozen-lockfile --non-interactive
@@ -41,10 +41,10 @@ jobs:
4141
runs-on: ubuntu-latest
4242
strategy:
4343
matrix:
44-
node-version: ["12"]
44+
node-version: ["18"]
4545

4646
steps:
47-
- uses: actions/checkout@v2
47+
- uses: actions/checkout@v3
4848
with:
4949
node-version: ${{ matrix.node-version }}
5050
- run: yarn install --frozen-lockfile --non-interactive
@@ -56,10 +56,10 @@ jobs:
5656
runs-on: ubuntu-latest
5757
strategy:
5858
matrix:
59-
node-version: ["12"]
59+
node-version: ["18"]
6060

6161
steps:
62-
- uses: actions/checkout@v2
62+
- uses: actions/checkout@v3
6363
with:
6464
node-version: ${{ matrix.node-version }}
6565
- run: yarn install --frozen-lockfile --non-interactive
@@ -71,10 +71,10 @@ jobs:
7171
runs-on: ubuntu-latest
7272
strategy:
7373
matrix:
74-
node-version: ["12"]
74+
node-version: ["18"]
7575

7676
steps:
77-
- uses: actions/checkout@v2
77+
- uses: actions/checkout@v3
7878
with:
7979
node-version: ${{ matrix.node-version }}
8080
- run: yarn install --frozen-lockfile --non-interactive
@@ -91,22 +91,22 @@ jobs:
9191
fail-fast: true
9292
matrix:
9393
ember-try-scenario:
94-
- ember-lts-3.4
95-
- ember-lts-3.8
96-
- ember-lts-3.12
97-
- ember-lts-3.16
98-
- ember-lts-3.20
99-
- ember-lts-3.24
94+
- ember-default
95+
- ember-lts-4.4
96+
- ember-lts-4.8
97+
- ember-lts-5.4
10098
- ember-release
10199
- ember-beta
102-
allow-failure: [false]
103-
include:
104-
- ember-try-scenario: ember-canary
105-
allow-failure: true
100+
- ember-canary
101+
- embroider-safe
102+
- embroider-optimized
103+
106104
steps:
107-
- uses: actions/checkout@v2
105+
- uses: actions/checkout@v3
106+
- name: Install Node
107+
uses: actions/setup-node@v3
108108
with:
109-
node-version: 12.x
109+
node-version: 18.x
110110
- name: install dependencies
111111
run: yarn install
112112
- name: test

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ HTML5 [fetch](https://fetch.spec.whatwg.org) polyfill from [github](https://gith
1919

2020
* Ember.js v4.4 or above
2121
* Ember CLI v4.4 or above
22-
* Node.js v14 or above
22+
* Node.js >=16.13 or >=18.*
2323

2424
ember-fetch requries ember-cli 2.13 or above.
2525

config/ember-try.js

Lines changed: 21 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -1,106 +1,72 @@
1-
'use strict';
2-
1+
// eslint-disable-next-line n/no-unpublished-require
32
const getChannelURL = require('ember-source-channel-url');
43

4+
const { embroiderSafe, embroiderOptimized } = require('@embroider/test-setup');
5+
56
module.exports = async function () {
67
return {
78
useYarn: true,
89
scenarios: [
910
{
10-
name: 'ember-lts-3.4',
11-
npm: {
12-
devDependencies: {
13-
'ember-source': '~3.4.0',
14-
},
15-
},
16-
},
17-
{
18-
name: 'ember-lts-3.8',
19-
npm: {
20-
devDependencies: {
21-
'ember-source': '~3.8.0',
22-
},
23-
},
24-
},
25-
{
26-
name: 'ember-lts-3.12',
27-
npm: {
28-
devDependencies: {
29-
'ember-source': '~3.12.0',
30-
},
31-
},
32-
},
33-
{
34-
name: 'ember-lts-3.16',
11+
name: 'ember-lts-4.4',
3512
npm: {
3613
devDependencies: {
37-
'ember-source': '~3.16.0',
14+
'ember-source': '~4.4.0',
3815
},
3916
},
4017
},
4118
{
42-
name: 'ember-lts-3.20',
19+
name: 'ember-lts-4.8',
4320
npm: {
4421
devDependencies: {
45-
'ember-source': '~3.20.0',
22+
'ember-source': '~4.8.0',
4623
},
4724
},
4825
},
4926
{
50-
name: 'ember-lts-3.24',
27+
name: 'ember-lts-5.4',
5128
npm: {
5229
devDependencies: {
53-
'ember-source': '~3.24.0',
30+
'ember-source': '~5.4.0',
31+
'ember-data': '~5.3.0',
5432
},
5533
},
5634
},
5735
{
5836
name: 'ember-release',
5937
npm: {
6038
devDependencies: {
61-
'ember-source': await getChannelURL('release'),
62-
},
39+
'ember-source': await getChannelURL('release')
40+
}
6341
},
42+
allowedToFail: true
6443
},
6544
{
6645
name: 'ember-beta',
6746
npm: {
6847
devDependencies: {
69-
'ember-source': await getChannelURL('beta'),
70-
},
48+
'ember-source': await getChannelURL('beta')
49+
}
7150
},
51+
allowedToFail: true
7252
},
7353
{
7454
name: 'ember-canary',
7555
npm: {
7656
devDependencies: {
77-
'ember-source': await getChannelURL('canary'),
78-
},
57+
'ember-source': await getChannelURL('canary')
58+
}
7959
},
60+
allowedToFail: true
8061
},
81-
// The default `.travis.yml` runs this scenario via `npm test`,
82-
// not via `ember try`. It's still included here so that running
83-
// `ember try:each` manually or from a customized CI config will run it
84-
// along with all the other scenarios.
8562
{
8663
name: 'ember-default',
8764
npm: {
8865
devDependencies: {},
8966
},
9067
},
91-
{
92-
name: 'ember-default-with-jquery',
93-
env: {
94-
EMBER_OPTIONAL_FEATURES: JSON.stringify({
95-
'jquery-integration': true,
96-
}),
97-
},
98-
npm: {
99-
devDependencies: {
100-
'@ember/jquery': '^0.5.1',
101-
},
102-
},
103-
},
68+
embroiderSafe({ allowedToFail: true }),
69+
embroiderOptimized({ allowedToFail: true })
10470
],
10571
};
10672
};

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@
112112
"ember-source": "^4.0.0"
113113
},
114114
"engines": {
115-
"node": "14.* || 16.* || >= 18"
115+
"node": ">=16.13 || >= 18"
116116
},
117117
"publishConfig": {
118118
"registry": "https://registry.npmjs.org/"

0 commit comments

Comments
 (0)