Skip to content

Commit 944c69e

Browse files
committed
breaking: drops Node < 16.13
1 parent c449a3d commit 944c69e

File tree

4 files changed

+58
-38
lines changed

4 files changed

+58
-38
lines changed

.github/workflows/CI.yml

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
name: "Linting"
1717
runs-on: ubuntu-latest
1818
steps:
19-
- uses: actions/checkout@v2
19+
- uses: actions/checkout@v3
2020
- run: yarn install --frozen-lockfile --non-interactive
2121
- run: yarn lint:js
2222

@@ -26,10 +26,10 @@ jobs:
2626
runs-on: ubuntu-latest
2727
strategy:
2828
matrix:
29-
node-version: ["12"]
29+
node-version: ["18"]
3030

3131
steps:
32-
- uses: actions/checkout@v2
32+
- uses: actions/checkout@v3
3333
with:
3434
node-version: ${{ matrix.node-version }}
3535
- run: yarn install --frozen-lockfile --non-interactive
@@ -41,10 +41,10 @@ jobs:
4141
runs-on: ubuntu-latest
4242
strategy:
4343
matrix:
44-
node-version: ["12"]
44+
node-version: ["18"]
4545

4646
steps:
47-
- uses: actions/checkout@v2
47+
- uses: actions/checkout@v3
4848
with:
4949
node-version: ${{ matrix.node-version }}
5050
- run: yarn install --frozen-lockfile --non-interactive
@@ -56,10 +56,10 @@ jobs:
5656
runs-on: ubuntu-latest
5757
strategy:
5858
matrix:
59-
node-version: ["12"]
59+
node-version: ["18"]
6060

6161
steps:
62-
- uses: actions/checkout@v2
62+
- uses: actions/checkout@v3
6363
with:
6464
node-version: ${{ matrix.node-version }}
6565
- run: yarn install --frozen-lockfile --non-interactive
@@ -71,10 +71,10 @@ jobs:
7171
runs-on: ubuntu-latest
7272
strategy:
7373
matrix:
74-
node-version: ["12"]
74+
node-version: ["18"]
7575

7676
steps:
77-
- uses: actions/checkout@v2
77+
- uses: actions/checkout@v3
7878
with:
7979
node-version: ${{ matrix.node-version }}
8080
- run: yarn install --frozen-lockfile --non-interactive
@@ -91,22 +91,28 @@ jobs:
9191
fail-fast: true
9292
matrix:
9393
ember-try-scenario:
94+
- ember-default
9495
- ember-lts-3.4
9596
- ember-lts-3.8
9697
- ember-lts-3.12
9798
- ember-lts-3.16
9899
- ember-lts-3.20
99100
- ember-lts-3.24
101+
- ember-lts-4.4
102+
- ember-lts-4.8
103+
- ember-lts-5.4
100104
- ember-release
101105
- ember-beta
102-
allow-failure: [false]
103-
include:
104-
- ember-try-scenario: ember-canary
105-
allow-failure: true
106+
- ember-canary
107+
- embroider-safe
108+
- embroider-optimized
109+
106110
steps:
107-
- uses: actions/checkout@v2
111+
- uses: actions/checkout@v3
112+
- name: Install Node
113+
uses: actions/setup-node@v3
108114
with:
109-
node-version: 12.x
115+
node-version: 18.x
110116
- name: install dependencies
111117
run: yarn install
112118
- name: test

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ HTML5 [fetch](https://fetch.spec.whatwg.org) polyfill from [github](https://gith
1919

2020
* Ember.js v4.4 or above
2121
* Ember CLI v4.4 or above
22-
* Node.js v14 or above
22+
* Node.js >=16.13 or >=18.*
2323

2424
ember-fetch requries ember-cli 2.13 or above.
2525

config/ember-try.js

Lines changed: 35 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
'use strict';
2-
1+
// eslint-disable-next-line n/no-unpublished-require
32
const getChannelURL = require('ember-source-channel-url');
43

4+
const { embroiderSafe, embroiderOptimized } = require('@embroider/test-setup');
5+
56
module.exports = async function () {
67
return {
78
useYarn: true,
@@ -55,52 +56,65 @@ module.exports = async function () {
5556
},
5657
},
5758
{
58-
name: 'ember-release',
59+
name: 'ember-lts-4.4',
5960
npm: {
6061
devDependencies: {
61-
'ember-source': await getChannelURL('release'),
62+
'ember-source': '~4.4.0',
6263
},
6364
},
6465
},
6566
{
66-
name: 'ember-beta',
67+
name: 'ember-lts-4.8',
6768
npm: {
6869
devDependencies: {
69-
'ember-source': await getChannelURL('beta'),
70+
'ember-source': '~4.8.0',
7071
},
7172
},
7273
},
7374
{
74-
name: 'ember-canary',
75+
name: 'ember-lts-5.4',
7576
npm: {
7677
devDependencies: {
77-
'ember-source': await getChannelURL('canary'),
78+
'ember-source': '~5.4.0',
79+
'ember-data': '~5.3.0',
7880
},
7981
},
8082
},
81-
// The default `.travis.yml` runs this scenario via `npm test`,
82-
// not via `ember try`. It's still included here so that running
83-
// `ember try:each` manually or from a customized CI config will run it
84-
// along with all the other scenarios.
8583
{
86-
name: 'ember-default',
84+
name: 'ember-release',
8785
npm: {
88-
devDependencies: {},
86+
devDependencies: {
87+
'ember-source': await getChannelURL('release')
88+
}
8989
},
90+
allowedToFail: true
9091
},
9192
{
92-
name: 'ember-default-with-jquery',
93-
env: {
94-
EMBER_OPTIONAL_FEATURES: JSON.stringify({
95-
'jquery-integration': true,
96-
}),
93+
name: 'ember-beta',
94+
npm: {
95+
devDependencies: {
96+
'ember-source': await getChannelURL('beta')
97+
}
9798
},
99+
allowedToFail: true
100+
},
101+
{
102+
name: 'ember-canary',
98103
npm: {
99104
devDependencies: {
100-
'@ember/jquery': '^0.5.1',
101-
},
105+
'ember-source': await getChannelURL('canary')
106+
}
107+
},
108+
allowedToFail: true
109+
},
110+
{
111+
name: 'ember-default',
112+
npm: {
113+
devDependencies: {},
102114
},
103115
},
116+
embroiderSafe({ allowedToFail: true }),
117+
embroiderOptimized({ allowedToFail: true })
104118
],
105119
};
106120
};

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@
112112
"ember-source": "^4.0.0"
113113
},
114114
"engines": {
115-
"node": "14.* || 16.* || >= 18"
115+
"node": ">=16.13 || >= 18"
116116
},
117117
"publishConfig": {
118118
"registry": "https://registry.npmjs.org/"

0 commit comments

Comments
 (0)