Merge pull request #986 from ember-cli/add-modules-api

Extending withModules module to support dynamically added modules

Author: ef4

addon/addon/index.js

@@ -63,7 +63,7 @@ export default class Resolver {
   constructor(props) {
     Object.assign(this, props);
     if (!this._moduleRegistry) {
-      const explicitModules = this.constructor.explicitModules;
+      let explicitModules = this.constructor.explicitModules;
       if (explicitModules) {
         this._moduleRegistry = {
           moduleNames() {
@@ -75,6 +75,9 @@ export default class Resolver {
           get(name) {
             return explicitModules[name];
           },
+          addModules(modules) {
+            explicitModules = Object.assign({}, explicitModules, modules);
+          },
         };
       } else {
         if (typeof globalThis.requirejs.entries === 'undefined') {
@@ -204,6 +207,9 @@ export default class Resolver {
   }
 
   resolve(fullName) {
+    if (fullName === 'resolver:current') {
+      return { create: () => this };
+    }
     let parsedName = this.parseName(fullName);
     let resolveMethodName = parsedName.resolveMethodName;
     let resolved;
@@ -219,6 +225,15 @@ export default class Resolver {
     return resolved;
   }
 
+  addModules(modules) {
+    if (!this._moduleRegistry.addModules) {
+      throw new Error(
+        `addModules is only supported when your Resolver has been configured to use static modules via Resolver.withModules()`
+      );
+    }
+    this._moduleRegistry.addModules(modules);
+  }
+
   _normalize(fullName) {
     // A) Convert underscores to dashes
     // B) Convert camelCase to dash-case, except for components (their

addon/index.d.ts

@@ -6,6 +6,7 @@ export default class Resolver {
 }
 export default interface Resolver extends Required<ResolverContract> {
     pluralizedTypes: Record<string, string>;
+    addModules(modules: Record<string, unknown>): void;
 }
 
 

test-app/tests/unit/resolvers/classic/with-modues-test.js

@@ -15,4 +15,31 @@ module('ember-resolver withModules', function () {
 
     assert.strictEqual((0, resolver.resolve('component:hello'))(), 'it works');
   });
+
+  test('can resolve self', function (assert) {
+    let resolver = Resolver.create({ namespace: { modulePrefix: 'alpha' } });
+    assert.strictEqual(resolver, resolver.resolve('resolver:current').create());
+  });
+
+  test('can addModules', function (assert) {
+    let startingModules = {};
+    let resolver = Resolver.withModules({}).create({
+      namespace: { modulePrefix: 'alpha' },
+    });
+
+    resolver.addModules({
+      'alpha/components/hello': {
+        default: function () {
+          return 'it works';
+        },
+      },
+    });
+
+    assert.strictEqual((0, resolver.resolve('component:hello'))(), 'it works');
+    assert.deepEqual(
+      [],
+      Object.keys(startingModules),
+      'did not mutate starting modules'
+    );
+  });
 });