Skip to content

Commit 032233e

Browse files
committed
Merge pull request #299 from Gaurav0/ember-resolver-addon
Use latest ember-resolver addon instead of legacy bower_component
2 parents c3deafc + 97901f1 commit 032233e

File tree

4 files changed

+17
-10
lines changed

4 files changed

+17
-10
lines changed

app/services/ember-cli.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -376,12 +376,6 @@ function babelOpts(moduleName) {
376376
* @return {Array} Code buffer
377377
*/
378378
function contentForAppBoot (content, config) {
379-
// Add in a shim for ember-resolver => ember/resolver for now since we are still bringing in old bower component
380-
// TODO: Once we support included addons, bring in new ember-resolver addon
381-
content.push(' define("ember-resolver", ["exports", "ember/resolver"],\n' +
382-
' function(exports, Resolver) {\n' +
383-
' exports["default"] = Resolver;\n' +
384-
' });\n');
385379

386380
// Some modules are not actually transpiled so Babel
387381
// doesn't recognize them properly...

bower.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
"ember-data": "2.2.1",
88
"ember-load-initializers": "0.1.7",
99
"ember-qunit-notifications": "0.1.0",
10-
"ember-resolver": "0.1.21",
1110
"jquery": "^1.11.3",
1211
"loader.js": "ember-cli/loader.js#3.5.0",
1312
"qunit": "~1.20.0",

ember-cli-build.js

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ module.exports = function() {
55
var concat = require('broccoli-concat');
66
var mergeTrees = require('broccoli-merge-trees');
77
var pickFiles = require('broccoli-static-compiler');
8+
var babelTranspiler = require('broccoli-babel-transpiler');
89
var env = EmberApp.env();
910
var isProductionLikeBuild = ['production', 'staging'].indexOf(env) > -1;
1011
var prepend = null;
@@ -58,12 +59,24 @@ module.exports = function() {
5859
destDir: '/assets'
5960
});
6061

61-
var twiddleVendorTree = concat(funnel('bower_components'),{
62+
var bowerTree = funnel('bower_components');
63+
var baseResolverTree = funnel('node_modules/ember-resolver/addon', {
64+
destDir: 'ember-resolver'
65+
});
66+
67+
var transpiledResolverTree = babelTranspiler(baseResolverTree, {
68+
loose: true,
69+
moduleIds: true,
70+
modules: 'amdStrict'
71+
});
72+
var mergedDepsTree = mergeTrees([bowerTree, transpiledResolverTree]);
73+
74+
var twiddleVendorTree = concat(mergedDepsTree, {
6275
inputFiles: [
6376
'loader.js/loader.js',
64-
'ember-resolver/dist/modules/ember-resolver.js',
6577
'ember-cli-shims/app-shims.js',
66-
'ember-load-initializers/ember-load-initializers.js'
78+
'ember-load-initializers/ember-load-initializers.js',
79+
'ember-resolver/**/*.js'
6780
],
6881
outputFile: '/assets/twiddle-deps.js'
6982
});

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"license": "MIT",
2121
"devDependencies": {
2222
"broccoli-asset-rev": "^2.2.0",
23+
"broccoli-babel-transpiler": "~5.4.5",
2324
"broccoli-concat": "0.0.13",
2425
"broccoli-funnel": "^1.0.0",
2526
"broccoli-merge-trees": "^1.0.0",

0 commit comments

Comments
 (0)