default export support

Author: ef4

lib/rules/template-missing-invokable.js

@@ -42,14 +42,12 @@ module.exports = {
           const matched = context.options[0]?.invokables?.[node.path.head.name];
           if (matched) {
             const [name, module] = matched;
+            const importStatement = buildImportStatement(node.path.head.name, name, module);
             context.report({
               node: node.path,
               messageId: 'missing-invokable',
               fix(fixer) {
-                return fixer.insertTextBeforeRange(
-                  [0, 0],
-                  `import { ${name} } from '${module}';\n`
-                );
+                return fixer.insertTextBeforeRange([0, 0], `${importStatement};\n`);
               },
             });
           }
@@ -78,3 +76,13 @@ function isBound(node, scope) {
   }
   return Boolean(ref.resolved);
 }
+
+function buildImportStatement(consumedName, exportedName, module) {
+  if (exportedName === 'default') {
+    return `import ${consumedName} from '${module}'`;
+  } else {
+    return consumedName === exportedName
+      ? `import { ${consumedName} } from '${module}'`
+      : `import { ${exportedName} as ${consumedName} } from '${module}'`;
+  }
+}

tests/lib/rules/template-missing-invokable.js

@@ -166,6 +166,7 @@ ruleTester.run('template-missing-invokable', rule, {
       ],
       errors: [{ type: 'GlimmerPathExpression', message: rule.meta.messages['missing-invokable'] }],
     },
+
     // Multiple copies of a fixable invocation
     {
       code: `
@@ -214,5 +215,33 @@ ruleTester.run('template-missing-invokable', rule, {
         { type: 'GlimmerPathExpression', message: rule.meta.messages['missing-invokable'] },
       ],
     },
+
+    // Auto-fix with a default export
+    {
+      code: `
+      <template>
+        {{#if (eq 1 1)}}
+          They're equal
+        {{/if}}
+      </template>
+      `,
+      output: `import eq from 'ember-truth-helpers/helpers/equal';
+
+      <template>
+        {{#if (eq 1 1)}}
+          They're equal
+        {{/if}}
+      </template>
+      `,
+      options: [
+        {
+          invokables: {
+            eq: ['default', 'ember-truth-helpers/helpers/equal'],
+          },
+        },
+      ],
+
+      errors: [{ type: 'GlimmerPathExpression', message: rule.meta.messages['missing-invokable'] }],
+    },
   ],
 });