Merge pull request #1944 from patricklx/gts/gjs-configs

gts/gjs configs

Author: NullVoxPopuli

.eslintignore

@@ -1,6 +1,8 @@
 coverage/
 node_modules
 lib/recommended-rules.js
+lib/recommended-rules-gjs.js
+lib/recommended-rules-gts.js
 
 # Contains <template> in js markdown
-docs/rules/no-empty-glimmer-component-classes.md
+docs/rules/no-empty-glimmer-component-classes.md

README.md

@@ -53,9 +53,42 @@ learn more [here](https://github.com/ember-template-imports/ember-template-impor
 module.exports = {
   overrides: [
     {
-      files: ['**/*.gts', '**/*.gjs'],
+      files: ['**/*.{js,ts,gjs,gts}'],
+      plugins: ['ember'],
+      extends: [
+        'eslint:recommended',
+        'plugin:ember/gts-recommended', // or other configuration
+      ],
+      rules: {
+        // override / enable optional rules
+        'ember/no-replace-test-comments': 'error'
+      }
+    },
+    {
+      files: ['**/*.gts'],
+      parser: 'eslint-plugin-ember/gjs-gts-parser',
+      plugins: ['ember'],
+      extends: [
+        'eslint:recommended',
+        'plugin:ember/gts-recommended', // or other configuration
+      ],
+    },
+    {
+      files: ['**/*.gjs'],
       parser: 'eslint-plugin-ember/gjs-gts-parser',
-    }
+      plugins: ['ember'],
+      extends: [
+        'eslint:recommended',
+        'plugin:ember/gjs-recommended', // or other configuration
+      ],
+    },
+    {
+      files: ['tests/**/*.{js,ts,gjs,gts}'],
+      rules: {
+        // override / enable optional rules
+        'ember/no-replace-test-comments': 'error'
+      }
+    },
   ],
 };
 ```
@@ -107,9 +140,12 @@ html does not have the distinction of line or block comments, which is why block
 
 <!-- begin auto-generated configs list -->
 
-|    | Name          |
-| :- | :------------ |
-| ✅  | `recommended` |
+|    | Name              |
+| :- | :---------------- |
+|    | `base`            |
+| ✅  | `recommended`     |
+|    | `recommended-gjs` |
+|    | `recommended-gts` |
 
 <!-- end auto-generated configs list -->
 

docs/svgs/gjs.svg

@@ -0,0 +1,27 @@
+module.exports = {
+  root: true,
+
+  parserOptions: {
+    ecmaVersion: 2020,
+    sourceType: 'module',
+  },
+
+  env: {
+    browser: true,
+    es2020: true,
+  },
+
+  plugins: ['ember'],
+
+  overrides: [
+    /**
+     * We don't want to *always* have the preprocessor active,
+     * it's only relevant on gjs and gts files to detect if eslint config is correctly setup for this files.
+     */
+    {
+      files: ['**/*.{gts,gjs}'],
+      parser: 'eslint-plugin-ember/gjs-gts-parser',
+      processor: 'ember/<noop>',
+    },
+  ],
+};

docs/svgs/gts.svg

@@ -0,0 +1,7 @@
+const base = require('./base');
+const gjsRules = require('../recommended-rules-gjs');
+
+module.exports = {
+  ...base,
+  rules: gjsRules,
+};

lib/config/base.js

@@ -0,0 +1,7 @@
+const base = require('./base');
+const gtsRules = require('../recommended-rules-gts');
+
+module.exports = {
+  ...base,
+  rules: gtsRules,
+};

lib/config/recommended-gjs.js

@@ -1,36 +1,7 @@
+const base = require('./base');
 const rules = require('../recommended-rules');
 
 module.exports = {
-  root: true,
-
-  parserOptions: {
-    ecmaVersion: 2020,
-    sourceType: 'module',
-  },
-
-  env: {
-    browser: true,
-    es2020: true,
-  },
-
-  plugins: ['ember'],
-
+  ...base,
   rules,
-
-  overrides: [
-    /**
-     * We don't want to *always* have the preprocessor active,
-     * it's only relevant on gjs and gts files.
-     *
-     * Additionally, we need to declare a global (which is private API)
-     * so that ESLint doesn't report errors about the variable being undefined.
-     * While this is true, it's a temporary thing for babel to do further processing
-     * on -- and isn't relevant to user-land code.
-     */
-    {
-      files: ['**/*.gts', '**/*.gjs'],
-      parser: 'eslint-plugin-ember/gjs-gts-parser',
-      processor: 'ember/<noop>',
-    },
-  ],
 };

lib/config/recommended-gts.js

@@ -0,0 +1,7 @@
+/*
+ * IMPORTANT!
+ * This file has been automatically generated.
+ * In order to update its content based on rules'
+ * definitions, execute "npm run update"
+ */
+module.exports = {}

lib/config/recommended.js

@@ -0,0 +1,7 @@
+/*
+ * IMPORTANT!
+ * This file has been automatically generated.
+ * In order to update its content based on rules'
+ * definitions, execute "npm run update"
+ */
+module.exports = {}