Ignore findBy calls from ember-cli-mirage in no-array-prototype-extensions (#2331)

* Ignore `findBy` calls from `ember-cli-mirage` in `no-array-prototype-extensions`

* Add tests for ember-cli-mirage exceptions for `findBy`

* Fix prettier errors

* Remove `window|undefined` from exception regexp

Author: VasylMarchuk

lib/rules/no-array-prototype-extensions.js

@@ -89,6 +89,14 @@ const KNOWN_NON_ARRAY_FUNCTION_CALLS = new Set([
   'sessionStorage.clear()',
 ]);
 
+/**
+ * Ignore these function calls using RegExps.
+ */
+const KNOWN_NON_ARRAY_FUNCTION_CALLS_REGEXP = new Set([
+  // ember-cli-mirage
+  /\.server\.schema\.(.*)\.findBy\(\)/,
+]);
+
 /**
  * Ignore objects of these names.
  */
@@ -692,6 +700,13 @@ module.exports = {
           return;
         }
 
+        for (const expression of KNOWN_NON_ARRAY_FUNCTION_CALLS_REGEXP) {
+          // Ignore any known non-array function calls matching a regular expression to reduce false positives.
+          if (expression.test(name)) {
+            return;
+          }
+        }
+
         for (const functionName of FN_NAMES_TO_KNOWN_NON_ARRAY_WORDS.keys()) {
           const words = FN_NAMES_TO_KNOWN_NON_ARRAY_WORDS.get(functionName);
           if (

tests/lib/rules/no-array-prototype-extensions.js

@@ -247,6 +247,12 @@ ruleTester.run('no-array-prototype-extensions', rule, {
 
     // TODO: handle non-Identifier property names:
     'foo["clear"]();',
+
+    // Common ember-cli-mirage calls
+    'this.server.schema.users.findBy()',
+    'this.server.schema.devices.findBy()',
+    'this.server.schema.users.findBy({ foo: "bar" })',
+    'this.server.schema.devices.findBy({ foo: "bar" })',
   ],
   invalid: [
     {