diff --git a/README.md b/README.md index 6e4848c37f..0e338e18eb 100644 --- a/README.md +++ b/README.md @@ -241,7 +241,7 @@ rules in templates can be disabled with eslint directives with mustache or html | [no-empty-glimmer-component-classes](docs/rules/no-empty-glimmer-component-classes.md) | disallow empty backing classes for Glimmer components | ✅ | | | | [no-tracked-properties-from-args](docs/rules/no-tracked-properties-from-args.md) | disallow creating @tracked properties from this.args | ✅ | | | | [template-indent](docs/rules/template-indent.md) | enforce consistent indentation for gts/gjs templates | | 🔧 | | -| [template-no-let-reference](docs/rules/template-no-let-reference.md) | disallow referencing let variables in \ | | | | +| [template-no-let-reference](docs/rules/template-no-let-reference.md) | disallow referencing let variables in \ | ✅ | | | ### jQuery diff --git a/docs/rules/template-no-let-reference.md b/docs/rules/template-no-let-reference.md index 1f25a1176a..8880792fdb 100644 --- a/docs/rules/template-no-let-reference.md +++ b/docs/rules/template-no-let-reference.md @@ -1,5 +1,7 @@ # ember/template-no-let-reference +💼 This rule is enabled in the ✅ `recommended` [config](https://github.com/ember-cli/eslint-plugin-ember#-configurations). + Disallows referencing let/var variables in templates. diff --git a/lib/recommended-rules.js b/lib/recommended-rules.js index 360f10628b..f4af8b112e 100644 --- a/lib/recommended-rules.js +++ b/lib/recommended-rules.js @@ -73,6 +73,7 @@ module.exports = { "ember/require-tagless-components": "error", "ember/require-valid-css-selector-in-test-helpers": "error", "ember/routes-segments-snake-case": "error", + "ember/template-no-let-reference": "error", "ember/use-brace-expansion": "error", "ember/use-ember-data-rfc-395-imports": "error" } \ No newline at end of file diff --git a/lib/rules/template-no-let-reference.js b/lib/rules/template-no-let-reference.js index 9cdea62d82..4ba6d17340 100644 --- a/lib/rules/template-no-let-reference.js +++ b/lib/rules/template-no-let-reference.js @@ -5,7 +5,7 @@ module.exports = { docs: { description: 'disallow referencing let variables in \\', category: 'Ember Octane', - recommended: false, + recommended: true, url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-let-reference.md', }, fixable: null, diff --git a/tests/__snapshots__/recommended.js.snap b/tests/__snapshots__/recommended.js.snap index 196daa7e78..dc84b8f836 100644 --- a/tests/__snapshots__/recommended.js.snap +++ b/tests/__snapshots__/recommended.js.snap @@ -70,6 +70,7 @@ exports[`recommended rules has the right list 1`] = ` "require-tagless-components", "require-valid-css-selector-in-test-helpers", "routes-segments-snake-case", + "template-no-let-reference", "use-brace-expansion", "use-ember-data-rfc-395-imports", ]