Skip to content

Commit 86c3cc2

Browse files
author
Robert Jackson
committed
Fixup tests for addon support.
1 parent de51777 commit 86c3cc2

File tree

4 files changed

+56
-7
lines changed

4 files changed

+56
-7
lines changed

test/fixtures/addon/example-js/classic-to-nested.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ module.exports = {
6565
'layout-property-classic': {
6666
'index.js': [
6767
'import Component from "@ember/component";',
68-
'export default Component.extend({});',
68+
'import SomeMixin from "my-addon/mixins/whatever";',
69+
'export default Component.extend(SomeMixin, {});',
6970
].join('\n'),
7071
'index.hbs': '{{!-- layout-property-classic.hbs --}}',
7172
},
@@ -87,16 +88,17 @@ module.exports = {
8788
},
8889

8990
// A template imported into multiple component classes
90-
'first-repeated-import': [
91-
'// first-repeated-import.ts',
91+
'first-repeated-import.js': [
92+
'// first-repeated-import.js',
9293
'import Component from "@ember/component"',
9394
'import { layout } from "@ember-decorators/component";',
9495
'import template from "my-addon/templates/components/repeatedly-imported";',
9596
'@layout(template)',
9697
'export default class FirstRepeatedImport extends Component {}',
9798
].join('\n'),
98-
'second-repeated-import': [
99-
'// second-repeated-import.ts',
99+
100+
'second-repeated-import.js': [
101+
'// second-repeated-import.js',
100102
'import Component from "@ember/component"',
101103
'import { layout } from "@ember-decorators/component";',
102104
'import template from "my-addon/templates/components/repeatedly-imported";',

test/fixtures/addon/example-ts/classic-to-nested.js

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,49 @@ module.exports = {
5050
].join('\n'),
5151
},
5252

53+
'layout-decorator': {
54+
'index.hbs': '{{!-- layout-decorator-template.hbs --}}',
55+
'index.ts': [
56+
'import Component from "@ember/component";',
57+
'export default class LayoutDecorator extends Component {}',
58+
].join('\n'),
59+
},
60+
61+
'layout-property-classic': {
62+
'index.hbs': '{{!-- layout-property-classic.hbs --}}',
63+
'index.ts': [
64+
'import Component from "@ember/component";',
65+
'import SomeMixin from "my-addon/mixins/whatever";',
66+
'export default Component.extend(SomeMixin, {});',
67+
].join('\n'),
68+
},
69+
70+
'layout-property-native': {
71+
'index.hbs': '{{!-- layout-property-native.hbs --}}',
72+
'index.ts': [
73+
'import Component from "@ember/component";',
74+
'export default class NativeProperty extends Component {}',
75+
].join('\n'),
76+
},
77+
78+
// A template imported into multiple component classes
79+
'first-repeated-import.ts': [
80+
'// first-repeated-import.ts',
81+
'import Component from "@ember/component"',
82+
'import { layout } from "@ember-decorators/component";',
83+
'import template from "my-addon/templates/components/repeatedly-imported";',
84+
'@layout(template)',
85+
'export default class FirstRepeatedImport extends Component {}',
86+
].join('\n'),
87+
'second-repeated-import.ts': [
88+
'// second-repeated-import.ts',
89+
'import Component from "@ember/component"',
90+
'import { layout } from "@ember-decorators/component";',
91+
'import template from "my-addon/templates/components/repeatedly-imported";',
92+
'@layout(template)',
93+
'export default class SecondRepeatedImport extends Component {}',
94+
].join('\n'),
95+
5396
// A component with partial
5497
partials: {
5598
'with-partial': {
@@ -78,6 +121,7 @@ module.exports = {
78121
'partial-two-template.hbs': '{{!-- partial-two-template.hbs --}}',
79122
'-partial-three-template.hbs': '{{!-- partial-three-template.hbs --}}',
80123
},
124+
'repeatedly-imported.hbs': '{{!-- repeatedly-imported.hbs --}}',
81125
},
82126
},
83127
},

test/fixtures/app/example-js/classic-to-nested.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,9 @@ module.exports = {
9696
'partial-two-template.hbs': '{{!-- partial-two-template.hbs --}}',
9797
'-partial-three-template.hbs': '{{!-- partial-three-template.hbs --}}',
9898
},
99-
},
10099

101-
'repeatedly-imported.hbs': '{{!-- repeatedly-imported.hbs --}}',
100+
'repeatedly-imported.hbs': '{{!-- repeatedly-imported.hbs --}}',
101+
},
102102
},
103103
},
104104
};

test/lib/migrator/classic-to-nested-test.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,20 @@ const fse = require('fs-extra');
33
const fixturify = require('fixturify');
44
const path = require('path');
55
const Migrator = require('../../../lib/migrator');
6+
const { setupConsole, resetConsole } = require('../../helpers');
67

78
assertDiff.options.strict = true;
89

910
describe('structure = nested', function () {
1011
beforeEach(function () {
1112
this.tmpPath = 'tmp/process-files';
1213
fse.mkdirsSync(this.tmpPath);
14+
setupConsole();
1315
});
1416

1517
afterEach(function () {
1618
fse.removeSync(this.tmpPath);
19+
resetConsole();
1720
});
1821

1922
describe('For an app with component classes written in JavaScript', function () {

0 commit comments

Comments
 (0)