Skip to content

Commit 6439846

Browse files
authored
Merge pull request #4 from ember-codemods/fix-import-migrations
Fix import migrations
2 parents 09e04a3 + fdbc520 commit 6439846

File tree

4 files changed

+30
-3
lines changed

4 files changed

+30
-3
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ember-test-onerror-codemod",
3-
"version": "1.0.1",
3+
"version": "1.0.2",
44
"scripts": {
55
"test": "codemod-cli test",
66
"update-docs": "codemod-cli update-docs"
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
import { module, test } from 'qunit';
2+
3+
module('foo', function() {
4+
test('foo test', async function(assert) {
5+
assert.expect(1);
6+
7+
sinon.stub(Ember, 'foo', function() {});
8+
sinon.stub(Ember, 'foo', () => {});
9+
sinon.stub(Ember, 'foo', fn);
10+
});
11+
});
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
import { module, test } from 'qunit';
2+
3+
module('foo', function() {
4+
test('foo test', async function(assert) {
5+
assert.expect(1);
6+
7+
sinon.stub(Ember, 'foo', function() {});
8+
sinon.stub(Ember, 'foo', () => {});
9+
sinon.stub(Ember, 'foo', fn);
10+
});
11+
});

transforms/remove-onerror-sinon-stubs/index.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ const { addImportStatement, writeImportStatements } = require('../utils');
44
module.exports = function transformer(file, api) {
55
const j = getParser(api);
66
const root = j(file.source);
7+
let requiresImport = false;
78

89
const replacer = path => {
910
let node = path.node;
@@ -15,6 +16,7 @@ module.exports = function transformer(file, api) {
1516
return node;
1617
}
1718

19+
requiresImport = true;
1820
return j.callExpression(j.identifier('setupOnerror'), [onErrorFn]);
1921
};
2022

@@ -33,8 +35,11 @@ module.exports = function transformer(file, api) {
3335

3436
if (replacements.length > 0) {
3537
replacements.replaceWith(replacer);
36-
addImportStatement(['setupOnerror']);
37-
writeImportStatements(j, root);
38+
39+
if (requiresImport) {
40+
addImportStatement(['setupOnerror']);
41+
writeImportStatements(j, root);
42+
}
3843
}
3944

4045
return root.toSource({ quote: 'single' });

0 commit comments

Comments
 (0)