replace ember-cli-eslint with eslint

Author: SergeAstapov

.eslintignore

@@ -0,0 +1,25 @@
+# unconventional js
+/blueprints/*/files/
+/vendor/
+
+# compiled output
+/dist/
+/tmp/
+
+# dependencies
+/bower_components/
+/node_modules/
+
+# misc
+/coverage/
+!.*
+.*/
+.eslintcache
+
+# ember-try
+/.node_modules.ember-try/
+/bower.json.ember-try
+/npm-shrinkwrap.json.ember-try
+/package.json.ember-try
+/package-lock.json.ember-try
+/yarn.lock.ember-try

.eslintrc.js

@@ -1,45 +1,66 @@
+'use strict';
+
 module.exports = {
   root: true,
+  parser: '@babel/eslint-parser',
   parserOptions: {
-    ecmaVersion: 2018,
-    sourceType: 'module'
+    ecmaVersion: 2022,
+    sourceType: 'module',
+    ecmaFeatures: {
+      legacyDecorators: true,
+    },
+    requireConfigFile: false,
+    babelOptions: {
+      plugins: [['@babel/plugin-proposal-decorators', { legacy: true }]],
+    },
   },
-  extends: 'eslint:recommended',
+  plugins: ['ember'],
+  extends: [
+    'eslint:recommended',
+    'plugin:ember/recommended',
+  ],
   env: {
-    browser: true
+    browser: true,
   },
   rules: {
+    'ember/new-module-imports': 'off',
+    'ember/no-get': 'off',
+    'ember/no-private-routing-service': 'off'
   },
   overrides: [
     // node files
     {
       files: [
-        '.eslintrc.js',
-        '.template-lintrc.js',
-        'ember-cli-build.js',
-        'index.js',
-        'testem.js',
-        'blueprints/*/index.js',
-        'config/**/*.js',
-        'tests/dummy/config/**/*.js'
-      ],
-      excludedFiles: [
-        'addon/**',
-        'addon-test-support/**',
-        'app/**',
-        'tests/dummy/app/**'
+        './.eslintrc.js',
+        './.prettierrc.js',
+        './.template-lintrc.js',
+        './ember-cli-build.js',
+        './index.js',
+        './testem.js',
+        './blueprints/*/index.js',
+        './config/**/*.js',
+        './lib/**/*.js',
+        './node-tests/**/*.js',
+        './tests/dummy/config/**/*.js',
       ],
       parserOptions: {
-        sourceType: 'script'
+        sourceType: 'script',
       },
       env: {
         browser: false,
-        node: true
+        node: true,
       },
       plugins: ['node'],
-      rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
-        // add your custom rules and overrides for node files here
-      })
-    }
-  ]
+      extends: ['plugin:node/recommended'],
+      rules: {
+        'ember/avoid-leaking-state-in-ember-objects': 'off',
+        'node/no-extraneous-require': ['error', {
+          allowModules: ['ember-source-channel-url']
+        }],
+        'node/no-unpublished-require': ['error', {
+          allowModules: ['ember-cli']
+        }]
+      }
+    },
+  ],
 };

.github/workflows/ci.yml

@@ -23,10 +23,13 @@ jobs:
         with:
           node-version: 14.x
           cache: yarn
+
       - name: Install Dependencies
         run: yarn install --frozen-lockfile
-#      - name: Lint
-#        run: yarn lint
+
+      - name: Lint
+        run: yarn lint
+
       - name: Run Tests
         run: yarn test
 
@@ -40,8 +43,10 @@ jobs:
         with:
           node-version: 14.x
           cache: yarn
+
       - name: Install Dependencies
         run: yarn install --no-lockfile
+
       - name: Run Tests
         run: yarn test
 
@@ -72,7 +77,9 @@ jobs:
         with:
           node-version: 14.x
           cache: yarn
+
       - name: Install Dependencies
         run: yarn install --frozen-lockfile
+
       - name: Run Tests
         run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}

.gitignore

@@ -9,6 +9,7 @@
 /bower_components
 
 # misc
+/.eslintcache
 /.sass-cache
 /connect.lock
 /coverage/*

package.json

@@ -14,19 +14,24 @@
   "repository": "https://github.com/ember-engines/ember-asset-loader",
   "scripts": {
     "build": "ember build",
+    "lint": "npm-run-all --aggregate-output --continue-on-error --parallel \"lint:!(fix)\"",
+    "lint:fix": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*:fix",
+    "lint:js": "eslint . --cache",
+    "lint:js:fix": "eslint . --fix",
     "start": "ember server",
     "test": "ember test",
     "test:sauce": "ember test --config-file testem.sauce.js --test-port 7000",
     "test:node": "mocha node-tests",
     "prepublish": "./bin/install-test-addons.sh"
   },
   "devDependencies": {
+    "@babel/eslint-parser": "^7.17.0",
+    "@babel/plugin-proposal-decorators": "^7.17.9",
     "broccoli-asset-rev": "^3.0.0",
     "broccoli-test-helper": "^2.0.0",
     "co": "^4.6.0",
     "ember-cli": "~3.12.0",
     "ember-cli-dependency-checker": "^3.1.0",
-    "ember-cli-eslint": "^5.1.0",
     "ember-cli-htmlbars": "^3.0.1",
     "ember-cli-htmlbars-inline-precompile": "^2.1.0",
     "ember-cli-inject-live-reload": "^2.0.1",
@@ -40,9 +45,12 @@
     "ember-resolver": "^5.1.3",
     "ember-source": "~3.12.0",
     "ember-try": "^2.0.0",
-    "eslint-plugin-node": "^11.0.0",
+    "eslint": "^8.13.0",
+    "eslint-plugin-ember": "^10.6.0",
+    "eslint-plugin-node": "^11.1.0",
     "loader.js": "^4.7.0",
     "mocha": "^6.0.2",
+    "npm-run-all": "^4.1.5",
     "test-generator-plugin": "link:./tests/dummy/lib/test-generator-plugin"
   },
   "dependencies": {

testem.sauce.js

@@ -1,4 +1,4 @@
-/*jshint node:true*/
+/* eslint-env node */
 module.exports = {
   "framework": "qunit",
   "test_page": "tests/index.html?hidepassed",

tests/.eslintrc.js

@@ -45,7 +45,7 @@ module.exports = function(environment) {
   }
 
   if (environment === 'production') {
-
+    // here you can enable a production-specific feature
   }
 
   return ENV;

tests/dummy/config/environment.js

@@ -1,11 +1,11 @@
-/*jshint node:true*/
+/* eslint-env node */
 var ManifestGenerator = require('../../../../lib/manifest-generator');
 
 module.exports = ManifestGenerator.extend({
   name: 'test-generator-plugin',
 
-  manifestOptions: {
+  manifestOptions: Object.freeze({
     bundlesLocation: 'test-dist',
     supportedTypes: [ 'js', 'css' ]
-  }
+  })
 });

tests/dummy/lib/test-generator-plugin/index.js

@@ -1,3 +1,4 @@
+/* global define */
 define('loaded-asset-state', function() {
   return {
     default: 'you should reset me'