Skip to content

Commit acf9a70

Browse files
committed
make sure that you a prompted to add node: current to targets
1 parent 75f436c commit acf9a70

File tree

3 files changed

+27
-7
lines changed

3 files changed

+27
-7
lines changed

packages/ember-cli-fastboot/blueprints/ember-cli-fastboot/index.js

Lines changed: 24 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,35 @@
11
/* eslint-env node */
22
const recast = require('recast');
33
const { readFileSync, writeFileSync } = require('fs');
4+
const { join, dirname } = require('path')
5+
const tmp = require('tmp');
6+
const mkdirp = require('mkdirp');
47

58
module.exports = {
69
description: '',
710
normalizeEntityName() {
811
// no-op
912
},
1013

11-
afterInstall() {
12-
let targetsFile = './config/targets.js'
14+
filesPath() {
15+
return this._filesPath;
16+
},
17+
18+
_targetsFile(project) {
19+
let configPath = 'config';
1320

14-
if(this.project.isEmberCLIAddon()) {
15-
targetsFile = './tests/dummy/config/targets.js';
21+
if (project.pkg['ember-addon'] && project.pkg['ember-addon']['configPath']) {
22+
configPath = project.pkg['ember-addon']['configPath'];
1623
}
1724

25+
return join(configPath, 'targets.js');
26+
},
27+
28+
install(options) {
29+
this._filesPath = tmp.dirSync().name;
30+
31+
const targetsFile = this._targetsFile(options.project);
32+
1833
const targetsAst = recast.parse(readFileSync(targetsFile));
1934

2035
recast.visit(targetsAst, {
@@ -39,6 +54,10 @@ module.exports = {
3954
}
4055
});
4156

42-
writeFileSync(targetsFile, recast.print(targetsAst, { tabWidth: 2, quote: 'single' }).code);
57+
let newFile = join(this._filesPath, targetsFile);
58+
mkdirp.sync(dirname(newFile));
59+
writeFileSync(newFile, recast.print(targetsAst, { tabWidth: 2, quote: 'single' }).code);
60+
61+
return this._super.install.apply(this, arguments);
4362
}
4463
};

packages/ember-cli-fastboot/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,9 @@
3939
"fs-extra": "^7.0.0",
4040
"json-stable-stringify": "^1.0.1",
4141
"md5-hex": "^2.0.0",
42+
"mkdirp": "^1.0.4",
4243
"recast": "^0.19.1",
43-
"silent-error": "^1.1.0"
44+
"tmp": "^0.2.1"
4445
},
4546
"devDependencies": {
4647
"body-parser": "^1.18.3",

yarn.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10843,7 +10843,7 @@ mkdirp@^0.5.0, mkdirp@^0.5.1, mkdirp@^0.5.3, mkdirp@^0.5.5, mkdirp@~0.5.0:
1084310843
dependencies:
1084410844
minimist "^1.2.5"
1084510845

10846-
mkdirp@^1.0.3:
10846+
mkdirp@^1.0.3, mkdirp@^1.0.4:
1084710847
version "1.0.4"
1084810848
resolved "https://registry.yarnpkg.com/mkdirp/-/mkdirp-1.0.4.tgz#3eb5ed62622756d79a5f0e2a221dfebad75c2f7e"
1084910849
integrity sha512-vVqVZQyf3WLx2Shd0qJ9xuvqgAyKPLAiqITEtqW0oIUjzo3PePDd6fW9iFz30ef7Ysp/oiWqbhszeGWW2T6Gzw==

0 commit comments

Comments
 (0)