Merge pull request #902 from mikrostew/fix-ci

Update CI and drop support for Node 12

Author: ef4

.github/workflows/ci.yml

@@ -25,7 +25,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [14.x, 12.x]
+        node-version: [16.x, 14.x]
         os: [ubuntu-latest, windows-latest]
 
     steps:
@@ -54,7 +54,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [14.x, 12.x]
+        node-version: [16.x, 14.x]
         os: [ubuntu-latest, windows-latest]
 
     steps:
@@ -76,7 +76,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [14.x, 12.x]
+        node-version: [16.x, 14.x]
         os: [ubuntu-latest, windows-latest]
 
     steps:
@@ -103,7 +103,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node-version: [14.x, 12.x]
+        node-version: [16.x, 14.x]
 
     steps:
       - name: Checkout Code

package.json

@@ -58,7 +58,7 @@
     "npm": false
   },
   "volta": {
-    "node": "14.17.3",
-    "yarn": "1.22.10"
+    "node": "16.18.1",
+    "yarn": "1.22.19"
   }
 }

packages/ember-cli-fastboot/config/ember-try.js

@@ -6,6 +6,10 @@ const { embroiderSafe, embroiderOptimized } = require('@embroider/test-setup');
 module.exports = async function () {
   return {
     useYarn: true,
+    // don't use default `--no-lockfile` option, which has been causing these to fail
+    buildManagerOptions(/* scenario */) {
+      return ['--ignore-engines'];
+    },
     scenarios: [
       {
         name: 'ember-lts-3.16',

packages/ember-cli-fastboot/package.json

@@ -101,7 +101,7 @@
     "webpack": "^5.58.1"
   },
   "engines": {
-    "node": "12.* || 14.* || >=16"
+    "node": "14.* || 16.* || >=18"
   },
   "publishConfig": {
     "registry": "https://registry.npmjs.org/"

packages/ember-cli-fastboot/test/fastboot-config-test.js

@@ -16,14 +16,15 @@ describe('FastBoot config', function () {
 
     return app
       .create('fastboot-config', {
-        skipNpm: true,
         emberVersion: 'latest',
         emberDataVersion: 'latest',
       })
       .then(function () {
         app.editPackageJSON((pkg) => {
           delete pkg.devDependencies['ember-fetch'];
           delete pkg.devDependencies['ember-welcome-page'];
+          // needed because @ember-data/store does `FastBoot.require('crypto')`
+          pkg.fastbootDependencies = ['crypto'];
         });
         return app.run('npm', 'install');
       })

packages/ember-cli-fastboot/test/fastboot-location-config-test.js

@@ -16,14 +16,15 @@ describe('FastBootLocation Configuration', function () {
 
     return app
       .create('fastboot-location-config', {
-        skipNpm: true,
         emberVersion: 'latest',
         emberDataVersion: 'latest',
       })
       .then(function () {
         app.editPackageJSON((pkg) => {
           delete pkg.devDependencies['ember-fetch'];
           delete pkg.devDependencies['ember-welcome-page'];
+          // needed because @ember-data/store does `FastBoot.require('crypto')`
+          pkg.fastbootDependencies = ['crypto'];
         });
         return app.run('npm', 'install');
       })

packages/ember-cli-fastboot/test/fastboot-location-test.js

@@ -15,14 +15,15 @@ describe('FastBootLocation', function () {
 
     return app
       .create('fastboot-location', {
-        skipNpm: true,
         emberVersion: 'latest',
         emberDataVersion: 'latest',
       })
       .then(function () {
         app.editPackageJSON((pkg) => {
           delete pkg.devDependencies['ember-fetch'];
           delete pkg.devDependencies['ember-welcome-page'];
+          // needed because @ember-data/store does `FastBoot.require('crypto')`
+          pkg.fastbootDependencies = ['crypto'];
         });
         return app.run('npm', 'install');
       })

packages/ember-cli-fastboot/test/package-json-test.js

@@ -18,14 +18,15 @@ describe('generating package.json', function () {
     before(function () {
       return customApp
         .create('customized-outputpaths', {
-          skipNpm: true,
           emberVersion: 'latest',
           emberDataVersion: 'latest',
         })
         .then(function () {
           customApp.editPackageJSON((pkg) => {
             delete pkg.devDependencies['ember-fetch'];
             delete pkg.devDependencies['ember-welcome-page'];
+            // needed because @ember-data/store does `FastBoot.require('crypto')`
+            pkg.fastbootDependencies = ['crypto'];
           });
           return customApp.run('npm', 'install');
         })

packages/ember-cli-fastboot/test/request-details-test.js

@@ -18,6 +18,8 @@ function injectMiddlewareAddon(app) {
     };
     delete pkg.devDependencies['ember-fetch'];
     delete pkg.devDependencies['ember-welcome-page'];
+    // needed because @ember-data/store does `FastBoot.require('crypto')`
+    pkg.fastbootDependencies = ['crypto'];
   });
   return app.run('npm', 'install');
 }
@@ -32,7 +34,6 @@ describe('request details', function () {
 
     return app
       .create('request', {
-        skipNpm: true,
         emberVersion: 'latest',
         emberDataVersion: 'latest',
       })

packages/ember-cli-fastboot/test/root-url-test.js

@@ -16,14 +16,15 @@ describe('rootUrl acceptance', function () {
 
     return app
       .create('root-url', {
-        skipNpm: true,
         emberVersion: 'latest',
         emberDataVersion: 'latest',
       })
       .then(function () {
         app.editPackageJSON((pkg) => {
           delete pkg.devDependencies['ember-fetch'];
           delete pkg.devDependencies['ember-welcome-page'];
+          // needed because @ember-data/store does `FastBoot.require('crypto')`
+          pkg.fastbootDependencies = ['crypto'];
         });
         return app.run('npm', 'install');
       })