Standardized on hostAllowList

Author: kiwiupover

README.md

@@ -273,23 +273,23 @@ module.exports = function(environment) {
     },
 
     fastboot: {
-      hostAllowlist: ['example.com', 'subdomain.example.com', /^localhost:\d+$/]
+      hostAllowList: ['example.com', 'subdomain.example.com', /^localhost:\d+$/]
     }
   };
   // ...
 };
 ```
 
-The `hostAllowlist` can be a string or RegExp to match multiple hosts.
+The `hostAllowList` can be a string or RegExp to match multiple hosts.
 Care should be taken when using a RegExp, as the host function relies on
 the `Host` HTTP header, which can be forged. You could potentially allow
 a malicious request if your RegExp is too permissive when using the `host`
 when making subsequent requests.
 
 Retrieving `host` will error on 2 conditions:
 
- 1. you do not have a `hostAllowlist` defined
- 2. the `Host` header does not match an entry in your `hostAllowlist`
+ 1. you do not have a `hostAllowList` defined
+ 2. the `Host` header does not match an entry in your `hostAllowList`
 
 ### Query Parameters
 

packages/ember-cli-fastboot/fastboot/initializers/ajax.js

@@ -14,7 +14,7 @@ var nodeAjax = function(options) {
     try {
       options.url = protocol + '//' + get(this, 'fastboot.request.host') + options.url;
     } catch (fbError) {
-      throw new Error('You are using Ember Data with no host defined in your adapter. This will attempt to use the host of the FastBoot request, which is not configured for the current host of this request. Please set the hostAllowlist property for in your environment.js. FastBoot Error: ' + fbError.message);
+      throw new Error('You are using Ember Data with no host defined in your adapter. This will attempt to use the host of the FastBoot request, which is not configured for the current host of this request. Please set the hostAllowList property for in your environment.js. FastBoot Error: ' + fbError.message);
     }
   }
 

packages/ember-cli-fastboot/lib/broccoli/fastboot-config.js

@@ -162,7 +162,7 @@ module.exports = class FastBootConfig extends Plugin {
   buildHostAllowList() {
     if (this.fastbootAppConfig) {
       if ('hostWhitelist' in this.fastbootAppConfig) {
-        this.ui.writeLine('Please update your fastboot config to use `hostAllowList` of the deprecated `hostWhitelist`');
+        this.ui.writeLine('Please update your fastboot config to use `hostAllowList` instead of the deprecated `hostWhitelist`');
       }
       this.hostAllowList = this.fastbootAppConfig.hostAllowList || this.fastbootAppConfig.hostWhitelist
     }

packages/ember-cli-fastboot/test/fastboot-config-test.js

@@ -54,6 +54,6 @@ describe('FastbootConfig', function() {
       'package.json': `{"dependencies":{},"fastboot":{"appName":"app","config":{"app":{"modulePrefix":"app"}},"hostAllowList":["example.com","subdomain.example.com"],"manifest":{"appFiles":["app.js","app-fastboot.js"],"htmlFile":"index.html","vendorFiles":["vendor.js"]},"moduleAllowlist":[],"schemaVersion":3}}`
     });
 
-    expect(output.builder.outputNode.ui.output).to.contain('Please update your fastboot config to use `hostAllowList` of the deprecated `hostWhitelist`');
+    expect(output.builder.outputNode.ui.output).to.contain('Please update your fastboot config to use `hostAllowList` instead of the deprecated `hostWhitelist`');
   });
 });

packages/ember-cli-fastboot/test/fixtures/fastboot-config/config/environment.js

@@ -19,7 +19,7 @@ module.exports = function(environment) {
     },
 
     fastboot: {
-      hostAllowlist: ['example.com', 'subdomain.example.com', /localhost:\d+/]
+      hostAllowList: ['example.com', 'subdomain.example.com', /localhost:\d+/]
     }
   };
 

packages/ember-cli-fastboot/test/fixtures/fastboot-location-config/config/environment.js

@@ -8,7 +8,7 @@ module.exports = function(environment) {
     modulePrefix: 'fastboot-location-config',
     fastboot: {
       fastbootHeaders: false,
-      hostAllowlist: [/localhost:\d+/],
+      hostAllowList: [/localhost:\d+/],
       redirectCode: 302,
     }
   };

packages/ember-cli-fastboot/test/fixtures/fastboot-location/config/environment.js

@@ -8,7 +8,7 @@ module.exports = function(environment) {
     modulePrefix: 'fastboot-location',
     fastboot: {
       fastbootHeaders: true,
-      hostAllowlist: [/localhost:\d+/]
+      hostAllowList: [/localhost:\d+/]
     }
   };
 

packages/ember-cli-fastboot/test/fixtures/request/config/environment.js

@@ -19,7 +19,7 @@ module.exports = function(environment) {
     },
 
     fastboot: {
-      hostAllowlist: ['example.com', 'subdomain.example.com', /localhost:\d+/]
+      hostAllowList: ['example.com', 'subdomain.example.com', /localhost:\d+/]
     }
   };
 

test-packages/basic-app/test/package-json-test.js

@@ -76,7 +76,7 @@ describe("generating package.json", function () {
     it("contains a list of allowed hosts from environment.js", function () {
       let pkg = fs.readJSONSync("dist/package.json");
 
-      expect(pkg.fastboot.hostAllowlist).to.deep.equal([
+      expect(pkg.fastboot.hostAllowList).to.deep.equal([
         "example.com",
         "subdomain.example.com",
         "/localhost:\\d+/",
@@ -117,7 +117,7 @@ describe("generating package.json", function () {
           autoboot: false,
         },
         fastboot: {
-          hostAllowlist: [
+          hostAllowList: [
             "example.com",
             "subdomain.example.com",
             "/localhost:\\d+/",