Skip to content

Commit db0e990

Browse files
authored
Merge pull request #866 from SergeAstapov/fix-ci
Make edition=octane and update deps for Ember v4 compatibility
2 parents 193e13d + e3637f3 commit db0e990

File tree

37 files changed

+546
-873
lines changed

37 files changed

+546
-873
lines changed

packages/ember-cli-fastboot/config/ember-try.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,9 @@ module.exports = async function () {
8686
}),
8787
},
8888
npm: {
89+
devDependencies: {
90+
'ember-source': '~3.28.0',
91+
},
8992
ember: {
9093
edition: 'classic',
9194
},

packages/ember-cli-fastboot/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
},
5252
"devDependencies": {
5353
"@ember/optional-features": "^2.0.0",
54-
"@ember/test-helpers": "^2.2.5",
54+
"@ember/test-helpers": "^2.6.0",
5555
"@embroider/test-setup": "^0.37.0",
5656
"@glimmer/component": "^1.0.4",
5757
"@glimmer/tracking": "^1.0.4",
@@ -64,7 +64,7 @@
6464
"chai-fs": "^2.0.0",
6565
"chai-string": "^1.4.0",
6666
"ember-auto-import": "^2.2.1",
67-
"ember-cli": "~3.26.1",
67+
"ember-cli": "~4.1.0",
6868
"ember-cli-addon-tests": "^0.11.1",
6969
"ember-cli-dependency-checker": "^3.2.0",
7070
"ember-cli-inject-live-reload": "^2.0.2",
@@ -74,8 +74,8 @@
7474
"ember-export-application-global": "^2.0.1",
7575
"ember-load-initializers": "^2.1.2",
7676
"ember-maybe-import-regenerator-for-testing": "^1.0.0",
77-
"ember-page-title": "^6.2.1",
78-
"ember-qunit": "^5.1.4",
77+
"ember-page-title": "^7.0.0",
78+
"ember-qunit": "^5.1.5",
7979
"ember-resolver": "^8.0.2",
8080
"ember-sinon": "^2.2.0",
8181
"ember-source": "~3.26.1",
@@ -107,7 +107,7 @@
107107
"registry": "https://registry.npmjs.org/"
108108
},
109109
"ember": {
110-
"edition": "classic"
110+
"edition": "octane"
111111
},
112112
"ember-addon": {
113113
"configPath": "tests/dummy/config",

packages/ember-cli-fastboot/test/fastboot-config-test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@ describe('FastBoot config', function () {
1818
.create('fastboot-config', {
1919
skipNpm: true,
2020
emberVersion: 'latest',
21-
emberDataVersion: '~3.19.0',
21+
emberDataVersion: 'latest',
2222
})
2323
.then(function () {
2424
app.editPackageJSON((pkg) => {
2525
delete pkg.devDependencies['ember-fetch'];
26+
delete pkg.devDependencies['ember-welcome-page'];
2627
});
2728
return app.run('npm', 'install');
2829
})

packages/ember-cli-fastboot/test/fastboot-location-config-test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@ describe('FastBootLocation Configuration', function () {
1818
.create('fastboot-location-config', {
1919
skipNpm: true,
2020
emberVersion: 'latest',
21-
emberDataVersion: '~3.19.0',
21+
emberDataVersion: 'latest',
2222
})
2323
.then(function () {
2424
app.editPackageJSON((pkg) => {
2525
delete pkg.devDependencies['ember-fetch'];
26+
delete pkg.devDependencies['ember-welcome-page'];
2627
});
2728
return app.run('npm', 'install');
2829
})

packages/ember-cli-fastboot/test/fastboot-location-test.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,12 @@ describe('FastBootLocation', function () {
1717
.create('fastboot-location', {
1818
skipNpm: true,
1919
emberVersion: 'latest',
20-
emberDataVersion: '~3.19.0',
20+
emberDataVersion: 'latest',
2121
})
2222
.then(function () {
2323
app.editPackageJSON((pkg) => {
2424
delete pkg.devDependencies['ember-fetch'];
25+
delete pkg.devDependencies['ember-welcome-page'];
2526
});
2627
return app.run('npm', 'install');
2728
})
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<h2 id="title">Welcome to Ember</h2>
2+
3+
{{outlet}}
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
'use strict';
2+
3+
const browsers = [
4+
'last 1 Chrome versions',
5+
'last 1 Firefox versions',
6+
'last 1 Safari versions',
7+
];
8+
9+
module.exports = {
10+
browsers,
11+
node: 'current',
12+
};

packages/ember-cli-fastboot/test/fixtures/fastboot-config/config/environment.js

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,21 @@
11
/* jshint node: true */
2+
'use strict';
23

3-
module.exports = function(environment) {
4-
var ENV = {
4+
module.exports = function (environment) {
5+
let ENV = {
56
modulePrefix: 'fastboot-config',
6-
environment: environment,
7-
baseURL: '/',
7+
environment,
8+
rootURL: '/',
89
locationType: 'auto',
910
EmberENV: {
1011
FEATURES: {
1112
// Here you can enable experimental features on an ember canary build
12-
// e.g. 'with-controller': true
13-
}
13+
// e.g. EMBER_NATIVE_DECORATOR_SUPPORT: true
14+
},
15+
EXTEND_PROTOTYPES: {
16+
// Prevent Ember Data from overriding Date.parse.
17+
Date: false,
18+
},
1419
},
1520

1621
APP: {
@@ -19,8 +24,8 @@ module.exports = function(environment) {
1924
},
2025

2126
fastboot: {
22-
hostWhitelist: ['example.com', 'subdomain.example.com', /localhost:\d+/]
23-
}
27+
hostWhitelist: ['example.com', 'subdomain.example.com', /localhost:\d+/],
28+
},
2429
};
2530

2631
if (environment === 'development') {
@@ -33,18 +38,18 @@ module.exports = function(environment) {
3338

3439
if (environment === 'test') {
3540
// Testem prefers this...
36-
ENV.baseURL = '/';
3741
ENV.locationType = 'none';
3842

3943
// keep test console output quieter
4044
ENV.APP.LOG_ACTIVE_GENERATION = false;
4145
ENV.APP.LOG_VIEW_LOOKUPS = false;
4246

4347
ENV.APP.rootElement = '#ember-testing';
48+
ENV.APP.autoboot = false;
4449
}
4550

4651
if (environment === 'production') {
47-
52+
// here you can enable a production-specific feature
4853
}
4954

5055
return ENV;
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
'use strict';
2+
3+
const browsers = [
4+
'last 1 Chrome versions',
5+
'last 1 Firefox versions',
6+
'last 1 Safari versions',
7+
];
8+
9+
module.exports = {
10+
browsers,
11+
node: 'current',
12+
};
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<h2 id="title">Welcome to Ember</h2>
2+
3+
{{outlet}}

0 commit comments

Comments
 (0)