Skip to content

Commit bfc5c73

Browse files
aklkvJen Weber
authored andcommitted
Feature/alex check (#17)
* adding alex linting with some obvious ignore rules * make travis build fail if any linter is failing * adding travis badge * fixing alex linting warnings
1 parent e4c22ec commit bfc5c73

File tree

8 files changed

+796
-8
lines changed

8 files changed

+796
-8
lines changed

.alexrc

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"allow": [
3+
"host-hostess",
4+
"watchman-watchwoman",
5+
"disabled"
6+
]
7+
}

.travis.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,7 @@ before_install:
1414
- npm config set spin false
1515

1616
script:
17+
- set -o errexit
1718
- npm run lint:md
19+
- npm run lint:alex
1820
- npm test

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,10 +65,10 @@ Give enough information to form the mental models and show how things are connec
6565
Avoid voice altogether whenever you can. When some voice is needed, use first person plural (“we”, “our”, “let’s”)
6666

6767

68-
- Needs revision: “There is an entire ecosystem of adapters that allow our Ember app to talk to different types of servers…”
69-
- Better: “There is an entire ecosystem of adapters that allow our Ember app to talk to different types of servers …”
70-
- Best: “There is an entire ecosystem of adapters that allows Ember apps to talk to different types of servers …”
68+
- Needs revision: “There is an entire ecosystem of adapters that allow our Ember app to talk to different types of servers…”
69+
- Better: “There is an entire ecosystem of adapters that allow our Ember app to talk to different types of servers …”
70+
- Best: “There is an entire ecosystem of adapters that allows Ember apps to talk to different types of servers …”
7171

7272
#### Inclusive language
73-
73+
<!--alex disable her-him-->
7474
“They/Them” is used in place of him/he/she/her/etc. Do not use gender in code examples. Avoid terms like “just, simply, obviously” etc.

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
## Ember-Cli Guides Source
22

3+
[![Build Status](https://travis-ci.org/ember-learn/cli-guides-source.svg?branch=master)](https://travis-ci.org/ember-learn/cli-guides-source)
4+
35
This repository is part of a Work-In-Progress project to refresh and replace the CLI guides content of [https://ember-cli.com](https://ember-cli.com).
46

57
## Contributing

guides/basic-use/cli-commands.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ ember generate <type of file> <the name to give it>
7676

7777
### What it does
7878

79-
`ember generate` creates new files within your app. For example, you can use it to create components, routes, services, models, and more. For a full list, type `ember generate --help`.
79+
`ember generate` creates new files within your app. For example, you can use it to create components, routes, services, models, and more. For a full list, type `ember generate --help`.
8080

8181
The new files will contain the necessary boilerplate, they will go in the right place, and the CLI will make sure that file naming conventions are followed. For example, components must always have a dash in their names. Creating files by hand is not recommended because mistakes can lead to confusing error messages.
8282

@@ -129,7 +129,7 @@ ember test [options]
129129
```
130130

131131
### What it does
132-
132+
<!--alex disable failed-->
133133
`ember test` runs all of the tests found in the `tests` folder of the app. By default, it runs all the tests once and displays the results. We'll see things like syntax errors, linting problems, deprecations, and failed assertions in the command line output. By default, these tests are run in Headless Chrome. What headless means is, we won't see the visual output of the browser, but it's running them in a Chrome environment. This makes the test suite faster. To watch tests in the browser as they run, visit `http://localhost:4200/tests` while the local server is running.
134134

135135
### Example
@@ -174,7 +174,7 @@ ember build --environment production
174174
<!-- link to guides and maybe super rentals -->
175175

176176

177-
<!--
177+
<!--
178178
## Table of Contents
179179
Basic use (explain options of each)
180180
- using the "help" commmand

guides/reference/windows.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ still need to start your shell using `Run as Administrator`.
6969
![Enabling Symlinks](/assets/images/enabling-symlinks.png)
7070

7171
### Issues With npm: `EEXISTS`, Path too Long, etc
72-
72+
<!--alex disable executed-->
7373
There were always two major issues with running Node.js on Windows: first and
7474
foremost, the operating system maintains a maximum length for path names, which
7575
clashes with Node's traditional way of nesting modules in `node_modules`. The

0 commit comments

Comments
 (0)