Skip to content

Commit abddcd7

Browse files
fix linting issues
1 parent 4625c7a commit abddcd7

File tree

3 files changed

+15
-31
lines changed

3 files changed

+15
-31
lines changed

lib/create-project-versions.js

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -27,24 +27,17 @@ export default function createProjectVersions(versions, projectName) {
2727
classes: {
2828
data: jsonapidoc.data
2929
.filter(item => item.type === 'class' && item.static !== 1)
30-
.map(({ id }) => ({
31-
id,
32-
type: 'class',
33-
})),
30+
.map(({ id }) => ({ id, type: 'class' })),
3431
},
3532
modules: {
36-
data: jsonapidoc.data.filter(({ type }) => type === 'module').map(({ id }) => ({
37-
id,
38-
type: 'module',
39-
})),
33+
data: jsonapidoc.data
34+
.filter(({ type }) => type === 'module')
35+
.map(({ id }) => ({ id, type: 'module' })),
4036
},
4137
namespaces: {
4238
data: jsonapidoc.data
4339
.filter(item => item.type === 'class' && item.static === 1)
44-
.map(({ id }) => ({
45-
id,
46-
type: 'namespace',
47-
})),
40+
.map(({ id }) => ({ id, type: 'namespace' })),
4841
},
4942
project: {
5043
data: {

lib/modules-transform.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ function addSubModulesParentAttribute(moduleObj) {
77

88
function filterStaticAndDerived(classes, className) {
99
let included =
10-
(classes.hasOwnProperty(className) &&
11-
!classes[className].hasOwnProperty('static') &&
12-
classes[className].hasOwnProperty('file')) ||
13-
!classes.hasOwnProperty(className)
10+
(_.has(classes, className) &&
11+
!_.has(classes[className], 'static') &&
12+
_.has(classes[className], 'file')) ||
13+
!_.has(classes, className)
1414
return included
1515
}
1616

@@ -21,7 +21,7 @@ function addPrivatePublicClassesAttributes(module, classes) {
2121
return (
2222
classes[className].access === 'private' ||
2323
classes[className].deprecated === true ||
24-
!classes[className].hasOwnProperty('access')
24+
!_.has(classes[className], 'access')
2525
)
2626
})
2727
module.publicclasses = partitionedClasses[1]

lib/normalize-ids.js

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,7 @@ function removeLongDocsBecauseEmber1HasWeirdDocs({ id }) {
1111
}
1212

1313
function extractRelationship({ id, type }) {
14-
return {
15-
id,
16-
type,
17-
}
14+
return { id, type }
1815
}
1916

2017
function filterForVersion(version) {
@@ -65,12 +62,10 @@ function normalizeIDs(pVersions, projectName) {
6562

6663
let namespaces = classes.filter(({ attributes }) => attributes.static === 1)
6764
classes = classes.filter(
68-
({ attributes }) => attributes.static !== 1 && attributes.hasOwnProperty('file')
65+
({ attributes }) => attributes.static !== 1 && _.has(attributes, 'file')
6966
)
7067

71-
namespaces.forEach(ns => {
72-
ns.type = 'namespace'
73-
})
68+
namespaces.forEach(ns => (ns.type = 'namespace'))
7469

7570
let modules = findType(jsonapidoc, 'module')
7671
.filter(filterForVersion(version))
@@ -121,18 +116,14 @@ function normalizeIDs(pVersions, projectName) {
121116
})
122117

123118
let versionDocs = RSVP.map(projectVersions, projectVersion => {
124-
let doc = {
125-
data: projectVersion,
126-
}
119+
let doc = { data: projectVersion }
127120

128121
let version = projectVersion.attributes.version
129122

130123
return saveDoc(doc, projectName, version)
131124
})
132125

133-
let doc = {
134-
data: jsonapidoc.data.concat(projectVersions),
135-
}
126+
let doc = { data: jsonapidoc.data.concat(projectVersions) }
136127
return versionDocs.then(() => doc)
137128
}
138129

0 commit comments

Comments
 (0)