Skip to content

Commit 532a213

Browse files
mansonamansona
authored
Merge pull request #108 from aklkv/feature/hbs-linting
turn on template lint
2 parents 5298627 + 82b00ce commit 532a213

File tree

10 files changed

+61
-60
lines changed

10 files changed

+61
-60
lines changed

‎.template-lintrc.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,4 @@
22

33
module.exports = {
44
extends: 'recommended',
5-
ignore: [
6-
'addon/**/**/*',
7-
],
85
};

‎addon/components/es-navbar/template.hbs

Lines changed: 23 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,32 @@
11
<div class="container">
22
{{#bs-navbar
3-
backgroundColor='inverse'
4-
type='inverse' as |navbar|}}
3+
backgroundColor="inverse"
4+
type="inverse"
5+
as |navbar|
6+
}}
57
<a class="navbar-brand" href="https://www.emberjs.com">
68
{{svg-jar "ember-logo-1c-white"}}
79
</a>
810
{{navbar.toggle}}
911
{{#navbar.content}}
1012
{{#navbar.nav class="mr-auto" as |nav|}}
1113
{{#each links as |link|}}
12-
{{#if (eq link.type 'link')}}
14+
{{#if (eq link.type "link")}}
1315
{{#nav.item}}
14-
<a href="{{link.href}}" class="nav-link">{{link.name}}</a>
16+
<a href={{link.href}} class="nav-link">{{link.name}}</a>
1517
{{/nav.item}}
1618
{{/if}}
17-
{{#if (eq link.type 'dropdown')}}
19+
{{#if (eq link.type "dropdown")}}
1820
{{#nav.dropdown tagName="li" as |dd|}}
1921
{{#dd.toggle}}{{link.name}} <span class="caret"></span>{{/dd.toggle}}
2022
{{#dd.menu as |menu|}}
2123
{{#each link.items as |item|}}
22-
{{#if (eq item.type 'link')}}
24+
{{#if (eq item.type "link")}}
2325
{{#menu.item}}
24-
<a href="{{item.href}}" class="dropdown-item">{{item.name}}</a>
26+
<a href={{item.href}} class="dropdown-item">{{item.name}}</a>
2527
{{/menu.item}}
2628
{{/if}}
27-
{{#if (eq item.type 'divider')}}
29+
{{#if (eq item.type "divider")}}
2830
{{menu.divider}}
2931
{{/if}}
3032
{{/each}}
@@ -34,24 +36,25 @@
3436

3537
{{/each}}
3638
{{/navbar.nav}}
37-
{{#navbar.nav as |nav|}}
39+
{{#navbar.nav}}
3840
{{#if hasBlock}}
3941
{{yield}}
4042
{{else}}
4143
<form class="navbar-form navbar-right searchbox">
4244
<div class="input-group">
4345
<label for="search-input" class="control-label sr-only">Search</label>
44-
<input type="text"
45-
class="form-control search input ds-input"
46-
placeholder="Search..."
47-
id="search-input"
48-
role="combobox"
49-
aria-expanded="false"
50-
aria-owns="algolia-autocomplete-listbox-0"
51-
autocorrect="off"
52-
autocapitalize="none"
53-
spellcheck="false"
54-
/>
46+
<input
47+
type="text"
48+
class="form-control search input ds-input"
49+
placeholder="Search..."
50+
id="search-input"
51+
role="combobox"
52+
aria-expanded="false"
53+
aria-owns="algolia-autocomplete-listbox-0"
54+
autocorrect="off"
55+
autocapitalize="none"
56+
spellcheck="false"
57+
>
5558
<span></span>
5659
</div>
5760
</form>

‎addon/templates/components/es-accordion/es-item.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
class="button-icon"
1717
data-role="accordion-item-button"
1818
aria-label="expand collapse"
19-
aria-expanded="{{isExpanded}}"
19+
aria-expanded={{isExpanded}}
2020
>
2121
<i class="fa fa-chevron-down" aria-hidden="true"></i>
2222
</button>

‎addon/templates/components/es-blog-heading.hbs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,5 @@
55
{{else}}
66
<h1 class="post-title page-view">{{postTitle}}</h1>
77
{{/if}}
8-
<div class="post-date">{{moment-format postDate 'MMM DD, YYYY' 'MM-DD-YYYY'}}</div>
8+
<div class="post-date">{{moment-format postDate "MMM DD, YYYY" "MM-DD-YYYY"}}</div>
99
<div class="post-author {{if isGuestPost "guest"}}">By {{author}}</div>
10-

‎addon/templates/components/es-footer.hbs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
<div class="footer responsive">
22
<div class="container">
33

4-
{{yield (hash
5-
info = (component 'es-footer/es-info')
6-
statement = (component 'es-footer/es-statement')
7-
contributions = (component 'es-footer/es-contributions')
8-
)}}
4+
{{yield
5+
(hash
6+
info = (component "es-footer/es-info")
7+
statement = (component "es-footer/es-statement")
8+
contributions = (component "es-footer/es-contributions")
9+
)
10+
}}
911

1012
{{#unless hasBlock}}
1113

‎addon/templates/components/es-footer/es-info.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ Copyright {{currentYear}}
66
{{#each infoLinks as |link index|}}
77
<a href={{link.href}}>{{link.name}}</a>
88
{{#if link.lineBreak}}
9-
<br/>
9+
<br>
1010
{{else if (not-eq index infoLinksLastIndex)}}
11-
|
11+
|
1212
{{/if}}
1313
{{/each}}
1414
{{/if}}

‎addon/templates/components/es-heading.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{{#if hasBlock}}
2-
{{yield}}
2+
{{yield}}
33
{{else}}
4-
{{headingText}}
4+
{{headingText}}
55
{{/if}}

‎addon/templates/components/es-main.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
{{#if hasAside}}
33
<div class="row">
44
{{#es-aside}}
5-
{{!--//aside content--}}
5+
{{!--//aside content--}}
66
{{/es-aside}}
77
<div class="col-xs-12 col-md-8 col-lg-9">
88
{{yield}}
@@ -11,4 +11,4 @@
1111
{{else}}
1212
{{yield}}
1313
{{/if}}
14-
</div>
14+
</div>

‎addon/templates/components/es-note.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@
99
{{/if}}
1010
</div>
1111
</div>
12-
<img src={{imageUrl}} role="presentation">
12+
<img src={{imageUrl}} role="presentation" alt="Ember Mascot">
1313
</div>

‎addon/templates/components/es-ulist.hbs

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
1-
<div class="list-title {{if isTitleVisible sr-only}}" id="{{listId}}">{{listTitle}}</div>
1+
<div class="list-title {{if isTitleVisible sr-only}}" id={{listId}}>{{listTitle}}</div>
2+
23
{{#if isUnorderedList}}
3-
<ul aria-labelledby="{{listId}}" class="list list-default">
4-
{{#each listItems as |item|}}
5-
<li class="list-item">
6-
{{#if hasLink}}
7-
<a href="{{item.link}}" class="list-item-link">
8-
{{#if hasImage}}
9-
<img src="{{item.image}}" class="list-item-image" />
10-
{{/if}}
11-
{{item.text}}
12-
</a>
13-
{{else}}
14-
{{#if hasImage}}
15-
<img src="{{item.image}}" class="list-item-image" />
16-
{{/if}}
17-
{{item.text}}
18-
{{/if}}
19-
</li>
20-
{{/each}}
21-
</ul>
4+
<ul aria-labelledby={{listId}} class="list list-default">
5+
{{#each listItems as |item|}}
6+
<li class="list-item">
7+
{{#if hasLink}}
8+
<a href={{item.link}} class="list-item-link">
9+
{{#if hasImage}}
10+
<img src={{item.image}} class="list-item-image" alt={{item.alt}}>
11+
{{/if}}
12+
{{item.text}}
13+
</a>
14+
{{else}}
15+
{{#if hasImage}}
16+
<img src={{item.image}} class="list-item-image" alt={{item.alt}}>
17+
{{/if}}
18+
{{item.text}}
19+
{{/if}}
20+
</li>
21+
{{/each}}
22+
</ul>
2223
{{else}}
23-
24-
{{/if}}
2524

25+
{{/if}}

0 commit comments

Comments
 (0)