Skip to content

Commit 6638f3d

Browse files
committed
upgrade using ember-cli-update
1 parent 9b1c612 commit 6638f3d

22 files changed

+32978
-26422
lines changed

.eslintignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
# misc
1414
/coverage/
1515
!.*
16+
.eslintcache
1617

1718
# ember-try
1819
/.node_modules.ember-try/

.eslintrc.js

Lines changed: 15 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -7,53 +7,49 @@ module.exports = {
77
ecmaVersion: 2018,
88
sourceType: 'module',
99
ecmaFeatures: {
10-
legacyDecorators: true
11-
}
10+
legacyDecorators: true,
11+
},
1212
},
13-
plugins: [
14-
'ember'
15-
],
13+
plugins: ['ember'],
1614
extends: [
1715
'eslint:recommended',
18-
'plugin:ember/recommended'
16+
'plugin:ember/recommended',
17+
'plugin:prettier/recommended',
1918
],
2019
env: {
21-
browser: true
22-
},
23-
rules: {
24-
'ember/no-jquery': 'error'
20+
browser: true,
2521
},
22+
rules: {},
2623
overrides: [
2724
// node files
2825
{
2926
files: [
3027
'.eslintrc.js',
3128
'.stylelintrc.js',
29+
'.prettierrc.js',
3230
'.template-lintrc.js',
3331
'ember-cli-build.js',
3432
'index.js',
3533
'testem.js',
3634
'blueprints/*/index.js',
3735
'config/**/*.js',
38-
'tests/dummy/config/**/*.js'
36+
'tests/dummy/config/**/*.js',
3937
],
4038
excludedFiles: [
4139
'addon/**',
4240
'addon-test-support/**',
4341
'app/**',
44-
'tests/dummy/app/**'
42+
'tests/dummy/app/**',
4543
],
4644
parserOptions: {
47-
sourceType: 'script'
45+
sourceType: 'script',
4846
},
4947
env: {
5048
browser: false,
51-
node: true
49+
node: true,
5250
},
5351
plugins: ['node'],
54-
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
55-
// add your custom rules and overrides for node files here
56-
})
57-
}
58-
]
52+
extends: ['plugin:node/recommended'],
53+
},
54+
],
5955
};

.github/workflows/ci.yml

Lines changed: 11 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ on:
44
push:
55
branches:
66
- master
7-
- website-redesign-rfc
87
tags:
98
- v[0-9]+.[0-9]+.[0-9]+
109
pull_request:
@@ -16,7 +15,7 @@ env:
1615

1716
jobs:
1817
lint:
19-
name: Lint files
18+
name: Lint and Test
2019
runs-on: ubuntu-latest
2120
timeout-minutes: 3
2221
steps:
@@ -45,6 +44,15 @@ jobs:
4544
- name: Lint
4645
run: npm run lint
4746

47+
- name: Test
48+
uses: percy/[email protected]
49+
with:
50+
custom-command: npm run test:ember
51+
env:
52+
PERCY_PARALLEL_NONCE: ${{ env.PERCY_PARALLEL_NONCE }}
53+
PERCY_PARALLEL_TOTAL: ${{ env.PERCY_PARALLEL_TOTAL }}
54+
PERCY_TOKEN: ee0a9d5c1122d6a21852edf19b5b309aaec18077fb3900c98995c90bc48ed240
55+
4856

4957
test-addon-floating:
5058
name: Test addon (floating dependencies)
@@ -65,53 +73,13 @@ jobs:
6573
- name: Test
6674
run: npm run test:ember
6775

68-
69-
test-addon-locked:
70-
name: Test addon (locked dependencies)
71-
runs-on: ubuntu-latest
72-
timeout-minutes: 5
73-
steps:
74-
- name: Check out a copy of the repo
75-
uses: actions/checkout@v2
76-
77-
- name: Use Node.js ${{ env.NODE_VERSION }}
78-
uses: actions/setup-node@v2-beta
79-
with:
80-
node-version: ${{ env.NODE_VERSION }}
81-
82-
- name: Cache npm cache and node_modules
83-
id: cache-dependencies
84-
uses: actions/cache@v2
85-
with:
86-
path: |
87-
~/.npm
88-
node_modules
89-
key: ${{ runner.os }}-${{ env.NODE_VERSION }}-${{ hashFiles('**/package-lock.json') }}
90-
restore-keys: ${{ runner.os }}-${{ env.NODE_VERSION }}-
91-
92-
- name: Install dependencies
93-
run: npm install
94-
if: steps.cache-dependencies.outputs.cache-hit != 'true'
95-
96-
- name: Test
97-
uses: percy/[email protected]
98-
with:
99-
custom-command: npm run test:ember
100-
env:
101-
PERCY_PARALLEL_NONCE: ${{ env.PERCY_PARALLEL_NONCE }}
102-
PERCY_PARALLEL_TOTAL: ${{ env.PERCY_PARALLEL_TOTAL }}
103-
PERCY_TOKEN: ee0a9d5c1122d6a21852edf19b5b309aaec18077fb3900c98995c90bc48ed240
104-
105-
10676
test-compatibility:
10777
name: Test compatibility
10878
runs-on: ubuntu-latest
10979
strategy:
11080
fail-fast: true
11181
matrix:
11282
scenario:
113-
- 'ember-lts-3.8'
114-
- 'ember-lts-3.12'
11583
- 'ember-lts-3.16'
11684
- 'ember-lts-3.20'
11785
- 'ember-release'
@@ -144,4 +112,4 @@ jobs:
144112
if: steps.cache-dependencies.outputs.cache-hit != 'true'
145113

146114
- name: Test
147-
run: npm run test:ember-compatibility ${{ matrix.scenario }}
115+
run: npx ember try:one $EMBER_TRY_SCENARIO ${{ matrix.scenario }}

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
/.env*
1313
/.pnp*
1414
/.sass-cache
15+
/.eslintcache
1516
/connect.lock
1617
/coverage/
1718
/libpeerconnection.log

.npmignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
/.editorconfig
1111
/.ember-cli
1212
/.env*
13+
/.eslintcache
1314
/.eslintignore
1415
/.eslintrc.js
1516
/.git/

.prettierignore

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# unconventional js
2+
/blueprints/*/files/
3+
/vendor/
4+
5+
# compiled output
6+
/dist/
7+
/tmp/
8+
9+
# dependencies
10+
/bower_components/
11+
/node_modules/
12+
13+
# misc
14+
/coverage/
15+
!.*
16+
.eslintcache
17+
18+
# ember-try
19+
/.node_modules.ember-try/
20+
/bower.json.ember-try
21+
/package.json.ember-try

.prettierrc.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
'use strict';
2+
3+
module.exports = {
4+
singleQuote: true,
5+
};

.template-lintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
'use strict';
22

33
module.exports = {
4-
extends: 'octane'
4+
extends: 'octane',
55
};

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ This addon is intended to provide basic components for easier style coordination
1111
Compatibility
1212
------------------------------------------------------------------------------
1313

14-
* Ember.js v3.8 or above
14+
* Ember.js v3.16 or above
1515
* Ember CLI v2.13 or above
1616
* Node.js v10 or above
1717

config/ember-try.js

Lines changed: 28 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -2,93 +2,77 @@
22

33
const getChannelURL = require('ember-source-channel-url');
44

5-
module.exports = async function() {
5+
module.exports = async function () {
66
return {
77
scenarios: [
8-
{
9-
name: 'ember-lts-3.8',
10-
npm: {
11-
devDependencies: {
12-
'ember-source': '~3.8.0'
13-
}
14-
}
15-
},
16-
{
17-
name: 'ember-lts-3.12',
18-
npm: {
19-
devDependencies: {
20-
'ember-source': '~3.12.0'
21-
}
22-
}
23-
},
248
{
259
name: 'ember-lts-3.16',
2610
npm: {
2711
devDependencies: {
28-
'ember-source': '~3.16.0'
29-
}
30-
}
12+
'ember-source': '~3.16.0',
13+
},
14+
},
3115
},
3216
{
3317
name: 'ember-lts-3.20',
3418
npm: {
3519
devDependencies: {
36-
'ember-source': '~3.20.5'
37-
}
38-
}
20+
'ember-source': '~3.20.5',
21+
},
22+
},
3923
},
4024
{
4125
name: 'ember-release',
4226
npm: {
4327
devDependencies: {
44-
'ember-source': await getChannelURL('release')
45-
}
46-
}
28+
'ember-source': await getChannelURL('release'),
29+
},
30+
},
4731
},
4832
{
4933
name: 'ember-beta',
5034
npm: {
5135
devDependencies: {
52-
'ember-source': await getChannelURL('beta')
53-
}
54-
}
36+
'ember-source': await getChannelURL('beta'),
37+
},
38+
},
5539
},
5640
{
5741
name: 'ember-canary',
5842
npm: {
5943
devDependencies: {
60-
'ember-source': await getChannelURL('canary')
61-
}
62-
}
44+
'ember-source': await getChannelURL('canary'),
45+
},
46+
},
6347
},
6448
{
6549
name: 'ember-default-with-jquery',
6650
env: {
6751
EMBER_OPTIONAL_FEATURES: JSON.stringify({
68-
'jquery-integration': true
69-
})
52+
'jquery-integration': true,
53+
}),
7054
},
7155
npm: {
7256
devDependencies: {
73-
'@ember/jquery': '^1.1.0'
74-
}
75-
}
57+
'@ember/jquery': '^1.1.0',
58+
},
59+
},
7660
},
7761
{
7862
name: 'ember-classic',
7963
env: {
8064
EMBER_OPTIONAL_FEATURES: JSON.stringify({
8165
'application-template-wrapper': true,
8266
'default-async-observers': false,
83-
'template-only-glimmer-components': false
84-
})
67+
'template-only-glimmer-components': false,
68+
}),
8569
},
8670
npm: {
8771
ember: {
88-
edition: 'classic'
89-
}
90-
}
91-
}
92-
]
72+
edition: 'classic',
73+
},
74+
},
75+
},
76+
],
9377
};
9478
};

0 commit comments

Comments
 (0)