Skip to content

Commit aee8f70

Browse files
committed
Merge branch 'master' into website-redesign-rfc
2 parents e407771 + f03492c commit aee8f70

File tree

12 files changed

+73
-69
lines changed

12 files changed

+73
-69
lines changed

CHANGELOG.md

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,44 @@
11

2+
v3.1.1 / 2019-06-24
3+
==================
4+
5+
* Fix navbar formatting #185 from @jenweber
6+
7+
v3.1.0 / 2018-06-22
8+
==================
9+
10+
* add es-section component #175 from @MelSumner
11+
* [Doc] Update the Help Wanted link in nav bar #178 from @vasind
12+
* Updated dnsimple target link in es-footer component from @sivakumar-kailasam
13+
14+
v3.0.0 / 2018-05-23
15+
==================
16+
17+
* Updated ember-cli-addon-docs
18+
* Update nav links to refer to new subdomains #173 from @sivakumar-kailasam
19+
* removing node 6, bumping LTS versions for ember-try #172 from @melsumner
20+
* Bump ember-bootstrap to get rid of ember.copy deprecation #170 from @sivakumar-kailasam
21+
* Convert es-footer to be an angle bracket component #125 from @esbanarango & @hakilebara
22+
* Add ember-angle-bracket-invocation-polyfill #163 from @amyrlam
23+
* Update legal and releases links #159 from @j-brennan
24+
* fixing accessibility bugs on navbar toggle button and footer links #149 from @alexpark90
25+
* Comply with axe-core 2.2 #150 from @wycats
26+
* Update _es-navbar.scss #147 from @melsumner
27+
* Navbar tweaks #146 from @mansona
28+
* Update _es-note.scss #144 from @melsumner
29+
* fixing z-index of dropdown #143 from @aklkv
30+
* Add closePopupMenu function to navbar service #142 from @patocallaghan
31+
* es-navbar: hide menu items when navbar is closed #140 from @mansona
32+
* Fixing default links #139 from @mansona
33+
* Fixing issue with element not being available when setting tabIndex #136 from @mansona
34+
* replacing → with → #137 from @mansona
35+
* Fully Accessible and Bootstrap-Free navbar #77 from @mansona
36+
* update `links.js` #132 from @locks
37+
* extract docs-note to a separate component #131 from @sivakumar-kailasam
38+
* use angle-bracket syntax for es-blog-heading component #128 from @jbailey4
39+
* use angle-bracket syntax for es-buttonbar component #127 from @jbailey4
40+
* use angle-bracket syntax for es-note component #126 from @jbailey4
41+
242
v2.5.0 / 2018-12-06
343
==================
444

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,4 @@ See the [Contributing](CONTRIBUTING.md) guide for details.
3333
* Each component must have the component name attached to the component as a CSS class.
3434
* It may feel as though there is duplicated code throughout these components; during the WIP process, we are favoring duplication over abstraction.
3535
* Font icons through [ember-fontawesome](https://fontawesome.com/how-to-use/on-the-web/using-with/ember) - it is supported by the font awesome team and they render to SVG.
36-
* The `es-pagewrapper` component has a property to indicate if there will be a sidebar or not. There might be a better way to do this.
3736
* In this addon, the `section` element is used as a container and is intended to span the full width of the viewport.

addon/components/es-pagewrapper.js

Lines changed: 0 additions & 10 deletions
This file was deleted.

addon/constants/es-footer.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const contributorLinks = [{
3535
}, {
3636
name: 'Resolved with:',
3737
title: "Dnsimple",
38-
href: 'https://dnsimple.com/resolving/emberjs',
38+
href: 'https://dnsimple.link/resolving-emberjs',
3939
class: 'dnsimple-logo-dark'
4040
}];
4141

addon/constants/links.js

Lines changed: 20 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export default [{
66
name: 'Ember.js Guides',
77
type: 'link'
88
}, {
9-
href: 'https://emberjs.com/api',
9+
href: 'https://api.emberjs.com',
1010
name: 'API Reference',
1111
type: 'link'
1212
}, {
@@ -24,34 +24,42 @@ export default [{
2424
name: 'Releases',
2525
type: 'dropdown',
2626
items: [{
27-
href: 'https://emberjs.com/builds',
28-
name: 'Channels',
27+
href: 'https://emberjs.com/releases',
28+
name: 'Overview',
2929
type: 'link'
3030
}, {
31-
href: 'https://emberjs.com/builds/release',
31+
href: 'https://emberjs.com/releases/lts',
32+
name: '→ LTS',
33+
type: 'link'
34+
}, {
35+
href: 'https://emberjs.com/releases/release',
3236
name: '→ Stable',
3337
type: 'link'
3438
}, {
35-
href: 'https://emberjs.com/builds/beta',
39+
href: 'https://emberjs.com/releases/beta',
3640
name: '→ Beta',
3741
type: 'link'
3842
}, {
39-
href: 'https://emberjs.com/builds/canary',
43+
href: 'https://emberjs.com/releases/canary',
4044
name: '→ Canary',
4145
type: 'link'
4246
}, {
4347
type: 'divider'
4448
}, {
45-
href: 'https://emberjs.com/deprecations',
49+
href: 'https://emberjs.com/editions',
50+
name: 'Editions',
51+
type: 'link'
52+
}, {
53+
href: 'https://deprecations.emberjs.com',
4654
name: 'Deprecations',
4755
type: 'link'
4856
}, {
49-
href: 'https://emberjs.com/statusboard',
50-
name: 'Status Board',
57+
href: 'https://github.com/emberjs/rfc-tracking/issues',
58+
name: 'RFC Tracking',
5159
type: 'link'
5260
}]
5361
}, {
54-
href: 'https://emberjs.com/blog',
62+
href: 'https://blog.emberjs.com',
5563
name: 'Blog',
5664
type: 'link'
5765
}, {
@@ -66,7 +74,7 @@ export default [{
6674
name: 'Guidelines',
6775
type: 'link'
6876
}, {
69-
href: 'http://github.com/emberjs/',
77+
href: 'https://help-wanted.emberjs.com/',
7078
name: 'Contribute (Github)',
7179
type: 'link'
7280
}, {
@@ -116,7 +124,7 @@ export default [{
116124
}, {
117125
type: 'divider'
118126
}, {
119-
href: 'https://emberjs.com/legal',
127+
href: 'https://emberjs.com/about/legal',
120128
name: 'Legal',
121129
type: 'link'
122130
}, {

addon/templates/components/es-note.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@
99
{{/if}}
1010
</div>
1111
</div>
12-
<img src={{imageUrl}} role="presentation" alt="Ember Mascot" class="hide-in-percy">
13-
</div>
12+
<img src={{imageUrl}} role="presentation" alt="" class="hide-in-percy">
13+
</div>

addon/templates/components/es-pagewrapper.hbs

Lines changed: 0 additions & 1 deletion
This file was deleted.

app/components/es-pagewrapper.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ember-styleguide",
3-
"version": "2.5.0",
3+
"version": "3.1.1",
44
"description": "Addon to help standardize the ember family of websites",
55
"keywords": [
66
"ember-addon"
Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,18 @@
1-
import { module, skip } from 'qunit';
1+
import { module, test } from 'qunit';
22
import { setupRenderingTest } from 'ember-qunit';
33
import { render } from '@ember/test-helpers';
44
import hbs from 'htmlbars-inline-precompile';
55

66
module('Integration | Component | es footer', function(hooks) {
77
setupRenderingTest(hooks);
88

9-
skip('it renders', async function(assert) {
10-
await render(hbs`{{es-footer}}`);
9+
test('it renders', async function(assert) {
10+
await render(hbs`<EsFooter/>`);
1111

12-
const footerSocialLinks = document.querySelectorAll('.footer-social a');
13-
const footerContribtuionsLinks = document.querySelectorAll('.footer-contributions .contributor');
14-
const footer = document.querySelector('.footer');
15-
const footerStyle = window.getComputedStyle(footer, null);
16-
const footerBgColor = footerStyle.getPropertyValue('background-color');
12+
const footerSocialLinks = this.element.querySelectorAll('.footer-social a');
13+
const footerContribtuionsLinks = this.element.querySelectorAll('.footer-contributions a');
1714

1815
assert.equal(footerSocialLinks.length, 3, 'social links are loading');
1916
assert.equal(footerContribtuionsLinks.length, 4, 'contributors links are loading');
20-
assert.equal(footerBgColor, 'rgb(242, 236, 233)', 'background color is rendering');
2117
});
2218
});

0 commit comments

Comments
 (0)