Skip to content

Commit e7a5215

Browse files
authored
Merge pull request #249 from ember-learn/redesign/helpers
Cleanup existing CSS helper classes
2 parents 96529d8 + 1659a92 commit e7a5215

31 files changed

+851
-674
lines changed

addon/styles/addon.css

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,24 @@
1+
/* Reset */
12
@import 'normalize.css';
23

4+
/* Globals */
35
@import 'global.css';
46
@import 'typography.css';
7+
8+
/* Helpers */
9+
@import 'helpers/index.css';
10+
11+
/* Modules */
512
@import 'colors.css';
6-
@import 'helpers.css';
713
@import 'container.css';
814
@import 'layout.css';
915
@import 'grid.css';
10-
@import 'flex.css';
1116
@import 'icon.css';
1217
@import 'background-shapes.css';
1318

14-
@import 'components/es-header.css';
15-
@import 'components/es-page-header.css';
19+
/* Components */
1620
@import 'components/es-button.css';
1721
@import 'components/es-card.css';
1822
@import 'components/es-footer.css';
23+
@import 'components/es-header.css';
24+
@import 'components/es-page-header.css';

addon/styles/colors.css

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,12 @@
1717

1818
.bg-light {
1919
background-color: var(--color-gray-100);
20+
color: var(--color-gray-700);
2021
}
2122

2223
.bg-light-muted {
2324
background-color: var(--color-gray-200);
25+
color: var(--color-gray-700);
2426
}
2527

2628
.bg-dark {
@@ -46,7 +48,7 @@
4648
}
4749

4850
.text-light {
49-
color: var(--color-brand-text);
51+
color: var(--color-white);
5052

5153
& h1,
5254
& h2,

addon/styles/components/es-button.css

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,18 @@
11
.es-button {
22
background-color: var(--color-brand);
33
color: var(--color-white);
4-
padding-left: 1.5em;
5-
padding-right: 1.5em;
6-
padding-top: 1em;
7-
padding-bottom: 1em;
8-
border-radius: 4px;
4+
padding-left: var(--spacing-3);
5+
padding-right: var(--spacing-3);
6+
padding-top: var(--spacing-1);
7+
padding-bottom: var(--spacing-1);
8+
border: 0;
9+
border-radius: var(--radius-lg);
10+
font-size: var(--font-size-md);
11+
line-height: var(--line-height-md);
12+
}
13+
14+
.es-button:active {
15+
background: var(--color-brand-hc-dark);
916
}
1017

1118
a.es-button {

addon/styles/components/es-footer.css

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,4 +59,9 @@
5959
justify-content: space-between;
6060
align-items: center;
6161
}
62+
63+
& .footer-contributor-logo {
64+
height: 1.6875rem;
65+
max-width: 4rem;
66+
}
6267
}

addon/styles/container.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22
max-width: var(--container-width);
33
margin-left: auto;
44
margin-right: auto;
5-
padding: var(--spacing-4) var(--grid-margin);
5+
padding: var(--spacing-6) var(--grid-margin);
66
box-sizing: content-box;
77
}

addon/styles/global.css

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
:root {
22
/* Vertical rhythm is based on multiples of 8. */
33

4-
--font-family-sans: "Inter var", "Inter web", -apple-system,
5-
BlinkMacSystemFont, Segoe UI, Helvetica, Arial, sans-serif,
6-
Apple Color Emoji, Segoe UI Emoji;
4+
--font-family-sans: 'Inter var', 'Inter web', -apple-system, BlinkMacSystemFont, Segoe UI,
5+
Helvetica, Arial, sans-serif, Apple Color Emoji, Segoe UI Emoji;
76

87
--color-white: #fff;
98
--color-gray-100: #f4f6f8;
@@ -28,21 +27,21 @@
2827
--color-warning: #fcffc9;
2928
--color-info: #e3eefc;
3029

31-
--font-size-xs: 0.8125rem; /* 13px, use sparsly! */
30+
--font-size-sm: 0.8125rem; /* 13px, use sparsly! */
3231
--font-size-base: 0.9375rem; /* p = 15px */
3332
--font-size-md: 0.9375rem; /* h3 = 15px */
3433
--font-size-lg: 1.1875rem; /* h2 = 19px */
3534
--font-size-xl: 1.5625rem; /* h1 = 25px */
36-
--font-size-display-1: 1.8754rem; /* display 1 = 30px */
37-
--font-size-display-2: 0.9375rem; /* display 2 = 15px */
35+
--font-size-hero-1: 1.8754rem; /* display 1 = 30px */
36+
--font-size-hero-2: 0.9375rem; /* display 2 = 15px */
3837

3938
--line-height-xs: calc(16 / 13); /* 16px */
4039
--line-height-base: 1.6; /* 24px */
4140
--line-height-md: 1.6; /* 24px */
4241
--line-height-lg: calc(24 / 19); /* 24px */
4342
--line-height-xl: 2; /* 32px */
44-
--line-height-display-1: calc(32 / 30); /* 32px */
45-
--line-height-display-2: 1.6; /* 24px */
43+
--line-height-hero-1: calc(32 / 30); /* 32px */
44+
--line-height-hero-2: 1.6; /* 24px */
4645

4746
--font-weight-1: 200;
4847
--font-weight-2: 400;
@@ -69,21 +68,21 @@
6968
/* Vertical rhythm is based on multiples of 9. */
7069

7170
:root {
72-
--font-size-xs: 0.875rem; /* 14px, use sparsly! */
71+
--font-size-sm: 0.875rem; /* 14px, use sparsly! */
7372
--font-size-base: 1rem; /* 16px */
7473
--font-size-md: 1.0625rem; /* 17px */
7574
--font-size-lg: 1.25rem; /* 20px */
7675
--font-size-xl: 2.25rem; /* 36px */
77-
--font-size-display-1: 3rem; /* 48px */
78-
--font-size-display-2: 1.125rem; /* 18px */
76+
--font-size-hero-1: 3rem; /* 48px */
77+
--font-size-hero-2: 1.125rem; /* 18px */
7978

8079
--line-height-xs: calc(16 / 14); /* 16px */
8180
--line-height-base: 1.6875; /* 27px */
8281
--line-height-md: calc(27 / 17); /* 27px */
8382
--line-height-lg: 1.35; /* 27px */
8483
--line-height-xl: 1.25; /* 45px */
85-
--line-height-display-1: 1.125; /* 54px */
86-
--line-height-display-2: 1.5; /* 27px */
84+
--line-height-hero-1: 1.125; /* 54px */
85+
--line-height-hero-2: 1.5; /* 27px */
8786

8887
--spacing-1: 0.5625rem; /* 9px */
8988
--spacing-2: 1.125rem; /* 18px */
@@ -118,6 +117,10 @@ body {
118117
line-height: var(--line-height-base);
119118
}
120119

120+
main {
121+
background-color: var(--color-gray-100);
122+
}
123+
121124
a {
122125
color: var(--color-brand);
123126
}

addon/styles/grid.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212

1313
.grid > * {
1414
grid-column: span 1;
15+
align-items: stretch;
1516
}
1617

1718
@media (max-width: 1007px) {

0 commit comments

Comments
 (0)