Skip to content

Commit f6264da

Browse files
Fixing review comments on heading tag placement
1 parent 2638b0a commit f6264da

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

addon/templates/components/es-ulist.hbs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<div>
2-
<ul aria-describedby="{{ariaDescribedby}}">
3-
{{es-heading headingText=title tagName="h3" class="title"}}
4-
2+
{{es-heading headingText=title tagName="h3" class="title"}}
3+
4+
<ul aria-describedby="{{ariaDescribedby}}">
55
{{#each listItems as |item|}}
66
<li>
77
{{yield item}}

tests/integration/components/es-ulist-test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ test('it render normal - list', function(assert) {
3838
{{/es-ulist}}
3939
`);
4040

41-
assert.equal(this.$('.es-ulist ul .title').text().trim(), model.name, 'List title rendered');
41+
assert.equal(this.$('.es-ulist .title').text().trim(), model.name, 'List title rendered');
4242
assert.equal(this.$('.es-ulist ul li:eq(0)').text().trim(), model.items[0].text, 'First Item rendered correctly');
4343
assert.equal(this.$('.es-ulist ul li:eq(2)').text().trim(), model.items[2].text, 'Third item in the list rendered correctly');
4444
});
@@ -69,7 +69,7 @@ test('it render list with left image', function(assert) {
6969
{{/es-ulist}}
7070
`);
7171

72-
assert.equal(this.$('.es-ulist ul .title').text().trim(), model.name, 'List Title rendered');
72+
assert.equal(this.$('.es-ulist .title').text().trim(), model.name, 'List Title rendered');
7373
assert.equal(this.$('.es-ulist ul li:eq(0) .es-ulist-image').length > 0, true, 'List with Image rendered');
7474
});
7575

@@ -163,7 +163,7 @@ test('should render icons on the left', function(assert) {
163163
{{/es-ulist}}
164164
`);
165165

166-
assert.equal(this.$('.es-ulist ul .title').text().trim(), model.name, 'Title rendered');
166+
assert.equal(this.$('.es-ulist .title').text().trim(), model.name, 'Title rendered');
167167
assert.equal(this.$('.es-ulist ul li:eq(0) .es-ulist-image .icons').length > 0, true, 'List with icons rendered');
168168
});
169169

@@ -190,7 +190,7 @@ test('it renders a list with links', function(assert) {
190190
{{/es-ulist}}
191191
`);
192192

193-
assert.equal(this.$('.es-ulist ul .title').text().trim(), model.name, 'List title rendered');
193+
assert.equal(this.$('.es-ulist .title').text().trim(), model.name, 'List title rendered');
194194
assert.equal(this.$('.es-ulist ul li:eq(0) a').length > 0, true, 'List items rendered');
195195
});
196196

0 commit comments

Comments
 (0)