fix replace-url-versions script to be idempotent

Author: mansona

node-tests/replace-url-versions.js

@@ -17,12 +17,13 @@ describe('replace url versions', function () {
         '3.15'
       )
     ).to.equal('https://api.emberjs.com/ember/3.15');
+    // the script is idempotent now so will only replace /release/ links
     expect(
       replaceURLVersions('https://api.emberjs.com/ember/3.20/', '3.15', '3.15')
-    ).to.equal('https://api.emberjs.com/ember/3.15/');
+    ).to.equal('https://api.emberjs.com/ember/3.20/');
     expect(
       replaceURLVersions('https://api.emberjs.com/ember/3.20', '3.15', '3.15')
-    ).to.equal('https://api.emberjs.com/ember/3.15');
+    ).to.equal('https://api.emberjs.com/ember/3.20');
     expect(
       replaceURLVersions(
         'https://api.emberjs.com/ember/release/classes/Application',
@@ -65,20 +66,22 @@ describe('replace url versions', function () {
         '3.15'
       )
     ).to.equal('https://api.emberjs.com/ember-data/3.15/classes/Model/');
+
+    // the script is idempotent now so will only replace /release/ links
     expect(
       replaceURLVersions(
         'https://api.emberjs.com/ember-data/3.20/classes/Model/',
         '3.15',
         '3.15'
       )
-    ).to.equal('https://api.emberjs.com/ember-data/3.15/classes/Model/');
+    ).to.equal('https://api.emberjs.com/ember-data/3.20/classes/Model/');
     expect(
       replaceURLVersions(
         'https://api.emberjs.com/ember-data/3.20/classes/Model/',
         '3.15',
         '3.12'
       )
-    ).to.equal('https://api.emberjs.com/ember-data/3.12/classes/Model/');
+    ).to.equal('https://api.emberjs.com/ember-data/3.20/classes/Model/');
     expect(
       replaceURLVersions(
         'https://api.emberjs.com/ember/release/classes/@ember%2Fapplication/methods/getOwner',

scripts/helpers/replace-url-versions.js

@@ -10,26 +10,26 @@ module.exports = function replaceURLVersions(
     ? emberVersion
     : emberVersion + '.0';
   output = str.replace(
-    /https:\/\/guides.emberjs.com\/(release|v\d+\.\d+.\d+)(\/?)/g,
+    /https:\/\/guides.emberjs.com\/(release)(\/?)/g,
     `https://guides.emberjs.com/v${emberPatchVersion}$2`
   );
 
   const emberDataPatchVersion = /\d+\.\d+.\d+/.test(emberDataVersion)
     ? emberDataVersion
     : emberDataVersion + '.0';
   output = str.replace(
-    /https:\/\/guides.emberjs.com\/(release|v\d+\.\d+.\d+)(\/?)/g,
+    /https:\/\/guides.emberjs.com\/(release)(\/?)/g,
     `https://guides.emberjs.com/v${emberDataPatchVersion}$2`
   );
 
   // apis use `3.20` version format
   output = output.replace(
-    /https:\/\/api.emberjs.com\/(ember)\/(release|\d+\.\d+)(\/?)/g,
+    /https:\/\/api.emberjs.com\/(ember)\/(release)(\/?)/g,
     `https://api.emberjs.com/$1/${emberVersion}$3`
   );
 
   output = output.replace(
-    /https:\/\/api.emberjs.com\/(ember-data)\/(release|\d+\.\d+)(\/?)/g,
+    /https:\/\/api.emberjs.com\/(ember-data)\/(release)(\/?)/g,
     `https://api.emberjs.com/$1/${emberDataVersion}$3`
   );