fix tests

Author: jaredgalanis

node-tests/replace-url-versions.js

@@ -1,45 +1,19 @@
 const { expect } = require('chai');
-const replaceURLsVersions = require('../scripts/helpers/replace-url-versions');
+const replaceURLVersions = require('../scripts/helpers/replace-url-versions');
 
 describe('replace url versions', function () {
   it('works', function () {
-    let test;
-
-    console.log('Running tests...');
-
-    expect(replaceURLsVersions('https://api.emberjs.com/ember/release/', '3.15')).to.equal('https://api.emberjs.com/ember/3.15/')
-
-    test = replaceURLsVersions('https://api.emberjs.com/ember/release', '3.15');
-    console.log(test === 'https://api.emberjs.com/ember/3.15' ? '✅' : '❌', test);
-
-    test = replaceURLsVersions('https://api.emberjs.com/ember/3.20/', '3.15');
-    console.log(test === 'https://api.emberjs.com/ember/3.15/' ? '✅' : '❌', test);
-
-    test = replaceURLsVersions('https://api.emberjs.com/ember/3.20', '3.15');
-    console.log(test === 'https://api.emberjs.com/ember/3.15' ? '✅' : '❌', test);
-
-    test = replaceURLsVersions('https://api.emberjs.com/ember/release/classes/Application', '3.15');
-    console.log(test === 'https://api.emberjs.com/ember/3.15/classes/Application' ? '✅' : '❌', test);
-
-    test = replaceURLsVersions('https://api.emberjs.com/ember-data/release/', '3.15');
-    console.log(test === 'https://api.emberjs.com/ember-data/3.15/' ? '✅' : '❌', test);
-
-    test = replaceURLsVersions('https://api.emberjs.com/ember-data/release', '3.15');
-    console.log(test === 'https://api.emberjs.com/ember-data/3.15' ? '✅' : '❌', test);
-
-    test = replaceURLsVersions('https://api.emberjs.com/ember-data/release/classes/Model/', '3.15');
-    console.log(test === 'https://api.emberjs.com/ember-data/3.15/classes/Model/' ? '✅' : '❌', test);
-
-    test = replaceURLsVersions('https://api.emberjs.com/ember-data/3.20/classes/Model/', '3.15');
-    console.log(test === 'https://api.emberjs.com/ember-data/3.15/classes/Model/' ? '✅' : '❌', test);
-
-    test = replaceURLsVersions('https://api.emberjs.com/ember/release/classes/@ember%2Fapplication/methods/getOwner', '3.15');
-    console.log(test === 'https://api.emberjs.com/ember/3.15/classes/@ember%2Fapplication/methods/getOwner' ? '✅' : '❌', test);
-
-    test = replaceURLsVersions('https://guides.emberjs.com/release/getting-started/', '3.15');
-    console.log(test === 'https://guides.emberjs.com/v3.15.0/getting-started/' ? '✅' : '❌', test);
-
-    test = replaceURLsVersions('https://guides.emberjs.com/release/getting-started/', '3.16.0');
-    console.log(test === 'https://guides.emberjs.com/v3.16.0/getting-started/' ? '✅' : '❌', test);
-  })
-})
+    expect(replaceURLVersions('https://api.emberjs.com/ember/release/', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember/3.15/');
+    expect(replaceURLVersions('https://api.emberjs.com/ember/release', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember/3.15');
+    expect(replaceURLVersions('https://api.emberjs.com/ember/3.20/', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember/3.15/');
+    expect(replaceURLVersions('https://api.emberjs.com/ember/3.20', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember/3.15');
+    expect(replaceURLVersions('https://api.emberjs.com/ember/release/classes/Application', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember/3.15/classes/Application');
+    expect(replaceURLVersions('https://api.emberjs.com/ember-data/release/', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember-data/3.15/');
+    expect(replaceURLVersions('https://api.emberjs.com/ember-data/release', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember-data/3.15');
+    expect(replaceURLVersions('https://api.emberjs.com/ember-data/release/classes/Model/', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember-data/3.15/classes/Model/');
+    expect(replaceURLVersions('https://api.emberjs.com/ember-data/3.20/classes/Model/', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember-data/3.15/classes/Model/');
+    expect(replaceURLVersions('https://api.emberjs.com/ember/release/classes/@ember%2Fapplication/methods/getOwner', '3.15', '3.15')).to.equal('https://api.emberjs.com/ember/3.15/classes/@ember%2Fapplication/methods/getOwner');
+    expect(replaceURLVersions('https://guides.emberjs.com/release/getting-started/', '3.15', '3.15')).to.equal('https://guides.emberjs.com/v3.15.0/getting-started/');
+    expect(replaceURLVersions('https://guides.emberjs.com/release/getting-started/', '3.16.0', '3.16.0')).to.equal('https://guides.emberjs.com/v3.16.0/getting-started/');
+  });
+});

scripts/helpers/replace-url-versions.js

@@ -2,10 +2,16 @@ module.exports = function replaceURLVersions(str, emberVersion, emberDataVersion
   let output;
 
   // guides use `v3.20.0` version format
-  const patchVersion = /\d+\.\d+.\d+/.test(version) ? version : version + '.0';
+  const emberPatchVersion = /\d+\.\d+.\d+/.test(emberVersion) ? emberVersion : emberVersion + '.0';
   output = str.replace(
     /https:\/\/guides.emberjs.com\/(release|v\d+\.\d+.\d+)(\/?)/g,
-    `https://guides.emberjs.com/v${patchVersion}$2`
+    `https://guides.emberjs.com/v${emberPatchVersion}$2`
+  );
+
+  const emberDataPatchVersion = /\d+\.\d+.\d+/.test(emberDataVersion) ? emberDataVersion : emberDataVersion + '.0';
+  output = str.replace(
+    /https:\/\/guides.emberjs.com\/(release|v\d+\.\d+.\d+)(\/?)/g,
+    `https://guides.emberjs.com/v${emberDataPatchVersion}$2`
   );
 
   // apis use `3.20` version format